From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 021C5C433EF for ; Wed, 8 Jun 2022 08:47:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F46810E9E1; Wed, 8 Jun 2022 08:47:26 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CAC110E9E1 for ; Wed, 8 Jun 2022 08:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654678046; x=1686214046; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=T43dlwiyjN420SHreJR82ARUXKr+XK+I0lyuNQ+m2JM=; b=lEABwjJMv6ZOS78PXJukP+GTZY57hTzTBnaQ7gBtXORPdQHgQPMzJYqu MI0aIK2jfXljI6Ya8Yqu4VU1GartVQZa8TSJiN/oCjUij37gC/D/IHuH7 SOC/dPHmnNMMNxF4pGUlsd1WrWV/xgQuQcy+mgnCzkm50B84A3/isRzEg 2AFDWjLCIPw1TuzLHL968RFCsm76NFwzRWIDWVn1YkD7lhvGsTeVPgwre 9qo2psAxfkS1yn/q4I8SmHaUsiSrvgeeg22Q1BtRM/tHBJSdtIeaiebt4 Ne8J0+y4XiERIouz7g9ZfqAzjvbHd/7qe3/ks/jPyw/GHFoeCDxMg4QJl A==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="274346557" X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="274346557" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 01:47:19 -0700 X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="636685354" Received: from jkosticx-mobl.amr.corp.intel.com (HELO localhost) ([10.252.58.130]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 01:47:18 -0700 From: Jani Nikula To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220516081015.1058987-1-jani.nikula@intel.com> Date: Wed, 08 Jun 2022 11:47:15 +0300 Message-ID: <87tu8vo830.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915/overlay: remove redundant GEM_BUG_ON() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 08 Jun 2022, Tvrtko Ursulin wrote: > On 16/05/2022 09:10, Jani Nikula wrote: >> There's an early return for !engine->kernel_context. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/display/intel_overlay.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c >> index ee46561b5ae8..79ed8bd04a07 100644 >> --- a/drivers/gpu/drm/i915/display/intel_overlay.c >> +++ b/drivers/gpu/drm/i915/display/intel_overlay.c >> @@ -1399,8 +1399,6 @@ void intel_overlay_setup(struct drm_i915_private *dev_priv) >> >> overlay->i915 = dev_priv; >> overlay->context = engine->kernel_context; >> - GEM_BUG_ON(!overlay->context); >> - >> overlay->color_key = 0x0101fe; >> overlay->color_key_enabled = true; >> overlay->brightness = -19; > > Reviewed-by: Tvrtko Ursulin Thanks, pushed to din. BR, Jani. > > Regards, > > Tvrtko -- Jani Nikula, Intel Open Source Graphics Center