From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113EBC433EF for ; Fri, 19 Nov 2021 09:37:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C578D6139F for ; Fri, 19 Nov 2021 09:37:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C578D6139F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 223896F99C; Fri, 19 Nov 2021 09:37:19 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E4C06F99C for ; Fri, 19 Nov 2021 09:37:17 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10172"; a="214417903" X-IronPort-AV: E=Sophos;i="5.87,246,1631602800"; d="scan'208";a="214417903" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2021 01:37:16 -0800 X-IronPort-AV: E=Sophos;i="5.87,246,1631602800"; d="scan'208";a="507834419" Received: from sgconnee-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.21.83]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2021 01:37:14 -0800 From: Jani Nikula To: "Navare, Manasi" , intel-gfx@lists.freedesktop.org In-Reply-To: <20211118224721.GA29932@labuser-Z97X-UD5H> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211111230949.28590-1-manasi.d.navare@intel.com> <20211118224721.GA29932@labuser-Z97X-UD5H> Date: Fri, 19 Nov 2021 11:37:06 +0200 Message-ID: <87tug8jxkt.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH] drm/i915/display/dsc: Clamp the max DSC input BPP to connector's max bpp X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 18 Nov 2021, "Navare, Manasi" wrote: > @Jani , @Ville, can you take a look at this, this was how the original DS= C patches > clamped the max bpp, but with latest DSC changes looks like this is not > obeyed anymore and needs to be fixed. When was this changed? Fixes: ? > > Manasi > > On Thu, Nov 11, 2021 at 03:09:49PM -0800, Manasi Navare wrote: >> Pipe_bpp limits are decided by connectors max bpp as computed in >> compute_sink_pipe_bpp() before computing link and DSC config. >> Currently dsc_compute_config() sets the max input bpp only based >> on DSC Input BPPs supported and max bpc requested for the connector >> but does not clamp it based on connector's max bpp. >> This patch fixes that. >>=20 >> Cc: Jani Nikula >> Cc: Vandita Kulkarni >> Cc: Ville Syrj=C3=A4l=C3=A4 >> Signed-off-by: Manasi Navare >> --- >> drivers/gpu/drm/i915/display/intel_dp.c | 1 + >> 1 file changed, 1 insertion(+) >>=20 >> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i= 915/display/intel_dp.c >> index 45373c213d9e..82209d995969 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >> @@ -1400,6 +1400,7 @@ static int intel_dp_dsc_compute_config(struct inte= l_dp *intel_dp, >> return -EINVAL; >>=20=20 >> pipe_bpp =3D intel_dp_dsc_compute_bpp(intel_dp, conn_state->max_reques= ted_bpc); >> + pipe_bpp =3D min(pipe_bpp, limits->max_bpp); >>=20=20 >> /* Min Input BPC for ICL+ is 8 */ >> if (pipe_bpp < 8 * 3) { >> --=20 >> 2.19.1 >>=20 --=20 Jani Nikula, Intel Open Source Graphics Center