From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A847C433E2 for ; Fri, 28 Aug 2020 14:05:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26BA62086A for ; Fri, 28 Aug 2020 14:05:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26BA62086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5E606E4B3; Fri, 28 Aug 2020 14:05:10 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C99A6E4B3 for ; Fri, 28 Aug 2020 14:05:09 +0000 (UTC) IronPort-SDR: l557PKeOwUaidb7RTNv/tE8tmzFVMwICZ1bVZBpUs0IF5upwPlvU2tA2cEhG8A6ljUEPelltMt VMcH+c8N55HA== X-IronPort-AV: E=McAfee;i="6000,8403,9726"; a="144413206" X-IronPort-AV: E=Sophos;i="5.76,363,1592895600"; d="scan'208";a="144413206" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 07:05:08 -0700 IronPort-SDR: dK9gviBjKEnclbB16DwwGzSs9323lMVMwaGN1DL7jl4vI629FjdiNj/AQg35ASep+uAQrdg7EP 6knmfqcfT0Wg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,363,1592895600"; d="scan'208";a="282409672" Received: from gaia.fi.intel.com ([10.237.72.192]) by fmsmga008.fm.intel.com with ESMTP; 28 Aug 2020 07:05:07 -0700 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id F10495C277F; Fri, 28 Aug 2020 17:04:10 +0300 (EEST) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200826132811.17577-6-chris@chris-wilson.co.uk> References: <20200826132811.17577-1-chris@chris-wilson.co.uk> <20200826132811.17577-6-chris@chris-wilson.co.uk> Date: Fri, 28 Aug 2020 17:04:10 +0300 Message-ID: <87tuwmzx2d.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 06/39] drm/i915/gt: Wait for CSB entries on Tigerlake X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > On Tigerlake, we are seeing a repeat of commit d8f505311717 ("drm/i915/icl: > Forcibly evict stale csb entries") where, presumably, due to a missing > Global Observation Point synchronisation, the write pointer of the CSB > ringbuffer is updated _prior_ to the contents of the ringbuffer. That is > we see the GPU report more context-switch entries for us to parse, but > those entries have not been written, leading us to process stale events, > and eventually report a hung GPU. > > However, this effect appears to be much more severe than we previously > saw on Icelake (though it might be best if we try the same approach > there as well and measure), and Bruce suggested the good idea of resetting > the CSB entry after use so that we can detect when it has been updated by > the GPU. By instrumenting how long that may be, we can set a reliable > upper bound for how long we should wait for: > > 513 late, avg of 61 retries (590 ns), max of 1061 retries (10099 ns) > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2045 > References: d8f505311717 ("drm/i915/icl: Forcibly evict stale csb entries") References: HSDES#1508287568 > Suggested-by: Bruce Chang > Signed-off-by: Chris Wilson > Cc: Bruce Chang > Cc: Mika Kuoppala > Cc: stable@vger.kernel.org # v5.4 > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index d6e0f62337b4..d75712a503b7 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -2498,9 +2498,22 @@ invalidate_csb_entries(const u64 *first, const u64 *last) > */ > static inline bool gen12_csb_parse(const u64 *csb) > { > - u64 entry = READ_ONCE(*csb); > - bool ctx_away_valid = GEN12_CSB_CTX_VALID(upper_32_bits(entry)); > - bool new_queue = > + bool ctx_away_valid; > + bool new_queue; > + u64 entry; > + > + /* HSD#22011248461 */ s/220011248461/1508287568 > + entry = READ_ONCE(*csb); > + if (unlikely(entry == -1)) { > + preempt_disable(); As this seems to rather rare, consider falling back to mmio read for this entry without the poll? -Mika > + if (wait_for_atomic_us((entry = READ_ONCE(*csb)) != -1, 50)) > + GEM_WARN_ON("50us CSB timeout"); > + preempt_enable(); > + } > + WRITE_ONCE(*(u64 *)csb, -1); > + > + ctx_away_valid = GEN12_CSB_CTX_VALID(upper_32_bits(entry)); > + new_queue = > lower_32_bits(entry) & GEN12_CTX_STATUS_SWITCHED_TO_NEW_QUEUE; > > /* > @@ -4004,6 +4017,8 @@ static void reset_csb_pointers(struct intel_engine_cs *engine) > WRITE_ONCE(*execlists->csb_write, reset_value); > wmb(); /* Make sure this is visible to HW (paranoia?) */ > > + /* Check that the GPU does indeed update the CSB entries! */ > + memset(execlists->csb_status, -1, (reset_value + 1) * sizeof(u64)); > invalidate_csb_entries(&execlists->csb_status[0], > &execlists->csb_status[reset_value]); > > -- > 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx