From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C49EC10DCE for ; Wed, 18 Mar 2020 09:39:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBADF2076F for ; Wed, 18 Mar 2020 09:38:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBADF2076F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 72EC06E3AE; Wed, 18 Mar 2020 09:38:59 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67A036E3AE for ; Wed, 18 Mar 2020 09:38:58 +0000 (UTC) IronPort-SDR: E5ZU+ubTfQiJFMxl6uKHnz8ebzbIoh2vU1fSwAu+6LaWS5xWthyqkIGpzLDNJNkseW3RqIPmn1 WlUbA8Ro3XSQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 02:38:57 -0700 IronPort-SDR: T3/CwIfY/PlX18qD/Xo+PmdLIeVx7TRle+443jUf+5Vo9dpCyQuVUZlOX7uNSGiX1xCmunMkkZ YpQF9dCbUw+w== X-IronPort-AV: E=Sophos;i="5.70,566,1574150400"; d="scan'208";a="417884496" Received: from gkern-mobl.ger.corp.intel.com (HELO localhost) ([10.252.54.69]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 02:38:55 -0700 From: Jani Nikula To: Anshuman Gupta , intel-gfx@lists.freedesktop.org In-Reply-To: <20200318081837.23983-1-anshuman.gupta@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200313185227.21900-1-anshuman.gupta@intel.com> <20200318081837.23983-1-anshuman.gupta@intel.com> Date: Wed, 18 Mar 2020 11:38:54 +0200 Message-ID: <87tv2mdmtt.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/edp: Ignore short pulse when panel powered off X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 18 Mar 2020, Anshuman Gupta wrote: > Few edp panels like Sharp is triggering short and long > hpd pulse after panel is getting powered off. > Currently driver is already ignoring long pulse for eDP > panel but in order to process the short pulse, it turns on > the VDD which requires panel power_cycle_delay + panel_power_on_delay > these delay on Sharp panel introduced the responsiveness overhead > of 800ms in the modeset sequence and as well is in suspend > sequence. > Ignoring any short pulse if panel is powered off. > > FIXME: It requires to wait for panel_power_off delay in order > to check the panel power status due to pps_lock because panel triggers > short pulse immediately after writing PP_OFF to PP_CTRL register and > wait_panel_off waits for panel_power_off delay with pps_lock held. > This still creates responsiveness overhead of panel_power_off delay. > > v2: > - checking vdd along with panel power to ignore the hpd. [Jani,Ville] > v3: > - safer side check to ignore the long hpd when eDP have power, > adding type of hpd to debug log. [Jani] > > Signed-off-by: Anshuman Gupta Thanks, Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_dp.c | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 0a417cd2af2b..38e74195101a 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -6763,19 +6763,34 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { > .destroy = intel_dp_encoder_destroy, > }; > > +static bool intel_edp_have_power(struct intel_dp *intel_dp) > +{ > + intel_wakeref_t wakeref; > + bool have_power = false; > + > + with_pps_lock(intel_dp, wakeref) { > + have_power = edp_have_panel_power(intel_dp) && > + edp_have_panel_vdd(intel_dp); > + } > + > + return have_power; > +} > + > enum irqreturn > intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > { > struct intel_dp *intel_dp = &intel_dig_port->dp; > > - if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { > + if (intel_dig_port->base.type == INTEL_OUTPUT_EDP && > + (long_hpd || !intel_edp_have_power(intel_dp))) { > /* > - * vdd off can generate a long pulse on eDP which > + * vdd off can generate a long/short pulse on eDP which > * would require vdd on to handle it, and thus we > * would end up in an endless cycle of > - * "vdd off -> long hpd -> vdd on -> detect -> vdd off -> ..." > + * "vdd off -> long/short hpd -> vdd on -> detect -> vdd off -> ..." > */ > - DRM_DEBUG_KMS("ignoring long hpd on eDP [ENCODER:%d:%s]\n", > + DRM_DEBUG_KMS("ignoring %s hpd on eDP [ENCODER:%d:%s]\n", > + long_hpd ? "long" : "short", > intel_dig_port->base.base.base.id, > intel_dig_port->base.base.name); > return IRQ_HANDLED; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx