From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915/opregion: rvda is relative from opregion base, not absolute Date: Thu, 13 Dec 2018 16:06:05 +0200 Message-ID: <87tvjh4j3m.fsf@intel.com> References: <20181213134704.30945-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A09C96EE61 for ; Thu, 13 Dec 2018 14:05:54 +0000 (UTC) In-Reply-To: <20181213134704.30945-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxMyBEZWMgMjAxOCwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gV2UndmUgc3VwcG9ydGVkIHRoZSBvcHJlZ2lvbiBSVkRBL1JWRFMgZmllbGRzIGZv ciBWQlQgc2l6ZSA+PSA2IEtCIHNpbmNlCj4gY29tbWl0IDA0ZWJhYWRiOWYyZCAoImRybS9pOTE1 L29wcmVnaW9uOiBoYW5kbGUgVkJUIHNpemVzIGJpZ2dlciB0aGFuIDYKPiBLQiIpLiBUaGF0J3Mg dGhyZWUgeWVhcnMsIGFsbW9zdCB0byB0aGUgZGF0ZS4KPgo+IFRoZSBpbXBsZW1lbnRhdGlvbiB3 YXMgYmFzZWQgb24gc3BlYyBvbmx5LCBpbiBhbnRpY2lwYXRpb24gb2Ygc3lzdGVtcwo+IHdpdGgg YmlnIFZCVC4gTm93LCB0aGUgc3BlYyBoYXMgYmVlbiBjaGFuZ2VkLiBUaGUgUlZEQSBpcyBzdXBw b3NlZCB0byBiZQo+IHJlbGF0aXZlIGZyb20gdGhlIGJlZ2lubmluZyBvZiBvcHJlZ2lvbiwgbm90 IGFic29sdXRlIGFkZHJlc3MuCj4KPiBUaGlzIGlzIG9idmlvdXNseSBhIGJhY2t3YXJkL2Zvcndh cmQgaW5jb21wYXRpYmxlIGNoYW5nZS4gSSd2ZSBiZWVuIHRvbGQKPiB0aGVyZSBhcmUgbm8gc3lz dGVtcyBvdXQgdGhlcmUgdXNpbmcgdGhlIGZpZWxkLiBGaW5nZXJzIGNyb3NzZWQuIFRoaXMKPiB3 aWxsIHN0aWxsIGJlIHByb2JsZW1hdGljIGZvciBvbGRlciBrZXJuZWxzLCBhbmQgd2UgY2FuIG9u bHkgdHJ5IHRvCj4gYmFja3BvcnQgdGhlIGZpeC4KClNob3VsZCBhZGQgdGhpcyB0byB0aGUgY29t bWl0IG1lc3NhZ2U6CgpXaGlsZSBhdCBpdCwgYWRkIHRoZSBtaXNzaW5nIG1lbXVubWFwKCkgb24g dGhlIGZhaWx1cmUgcGF0aCBmb3IKY29tcGxldGVuZXNzLgoKPgo+IEZpeGVzOiAwNGViYWFkYjlm MmQgKCJkcm0vaTkxNS9vcHJlZ2lvbjogaGFuZGxlIFZCVCBzaXplcyBiaWdnZXIgdGhhbiA2IEtC IikKPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K PiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEph bmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX29wcmVnaW9uLmMgfCAxMiArKysrKysrKysrLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDEwIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ByZWdpb24uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX29wcmVnaW9uLmMKPiBpbmRleCBiOGYxMDZkOWVjZjguLjcwMGZkZGFhOGQ5ZSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9vcHJlZ2lvbi5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ByZWdpb24uYwo+IEBAIC0xMTksNyArMTE5LDcg QEAgc3RydWN0IG9wcmVnaW9uX2FzbGUgewo+ICAJdTY0IGZkc3M7Cj4gIAl1MzIgZmRzcDsKPiAg CXUzMiBzdGF0Owo+IC0JdTY0IHJ2ZGE7CS8qIFBoeXNpY2FsIGFkZHJlc3Mgb2YgcmF3IHZidCBk YXRhICovCj4gKwl1NjQgcnZkYTsJLyogQWRkcmVzcyBvZiByYXcgdmJ0IGRhdGEsIHJlbGF0aXZl IGZyb20gb3ByZWdpb24gKi8KPiAgCXUzMiBydmRzOwkvKiBTaXplIG9mIHJhdyB2YnQgZGF0YSAq Lwo+ICAJdTggcnN2ZFs1OF07Cj4gIH0gX19wYWNrZWQ7Cj4gQEAgLTk1NSw3ICs5NTUsMTMgQEAg aW50IGludGVsX29wcmVnaW9uX3NldHVwKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPiAgCj4gIAlpZiAob3ByZWdpb24tPmhlYWRlci0+b3ByZWdpb25fdmVyID49IDIgJiYgb3By ZWdpb24tPmFzbGUgJiYKPiAgCSAgICBvcHJlZ2lvbi0+YXNsZS0+cnZkYSAmJiBvcHJlZ2lvbi0+ YXNsZS0+cnZkcykgewo+IC0JCW9wcmVnaW9uLT5ydmRhID0gbWVtcmVtYXAob3ByZWdpb24tPmFz bGUtPnJ2ZGEsCj4gKwkJLyoKPiArCQkgKiBydmRhIGlzIHVuc2lnbmVkLCByZWxhdGl2ZSBmcm9t IG9wcmVnaW9uIGJhc2UsIGFuZCBzaG91bGQKPiArCQkgKiBuZXZlciBwb2ludCB3aXRoaW4gb3By ZWdpb24uCj4gKwkJICovCj4gKwkJV0FSTl9PTihvcHJlZ2lvbi0+YXNsZS0+cnZkYSA8IE9QUkVH SU9OX1NJWkUpOwo+ICsKPiArCQlvcHJlZ2lvbi0+cnZkYSA9IG1lbXJlbWFwKGFzbHMgKyBvcHJl Z2lvbi0+YXNsZS0+cnZkYSwKPiAgCQkJCQkgIG9wcmVnaW9uLT5hc2xlLT5ydmRzLAo+ICAJCQkJ CSAgTUVNUkVNQVBfV0IpOwo+ICAJCXZidCA9IG9wcmVnaW9uLT5ydmRhOwo+IEBAIC05NjcsNiAr OTczLDggQEAgaW50IGludGVsX29wcmVnaW9uX3NldHVwKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiAgCQkJZ290byBvdXQ7Cj4gIAkJfSBlbHNlIHsKPiAgCQkJRFJNX0RFQlVH X0tNUygiSW52YWxpZCBWQlQgaW4gQUNQSSBPcFJlZ2lvbiAoUlZEQSlcbiIpOwo+ICsJCQltZW11 bm1hcChvcHJlZ2lvbi0+cnZkYSk7Cj4gKwkJCW9wcmVnaW9uLT5ydmRhID0gTlVMTDsKPiAgCQl9 Cj4gIAl9CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK