From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 02/10] drm/i915: Make intel_dp_detect() more
 clear to read
Date: Wed, 03 Oct 2018 10:25:30 +0300
Message-ID: <87tvm3qyol.fsf@intel.com>
References: <20181002175054.15010-1-jose.souza@intel.com>
 <20181002175054.15010-2-jose.souza@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id DBC886E3DA
 for <intel-gfx@lists.freedesktop.org>; Wed,  3 Oct 2018 07:25:37 +0000 (UTC)
In-Reply-To: <20181002175054.15010-2-jose.souza@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: =?utf-8?Q?Jos=C3=A9?= Roberto de Souza <jose.souza@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCAwMiBPY3QgMjAxOCwgSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBp
bnRlbC5jb20+IHdyb3RlOgo+IE1vdmluZyBhbGwgdGhlIGVycm9yIGhhbmRsaW5nIHRvIHRoZSBl
bmQgb2YgdGhlIGZ1bmN0aW9uIGFuZCBlYWxpZXIKPiByZXR1cm5pbmcgZm9yIGNvbm5lY3RlZCBN
U1QgcG9ydHMgbWFrZSB0aGlzIGZ1bmN0aW9uIHdheSBtb3JlIGVhc3kgdG8KPiByZWFkLgo+IE5v
IGZ1bmN0aW9uYWwgY2hhbmdlZCBpcyBpbnRlbmRlZCBoZXJlLgoKSG9uZXN0bHksIEkgZGlzYWdy
ZWUgdGhhdCB0aGUgZW5kIHJlc3VsdCB3b3VsZCBiZSBtb3JlIGNsZWFyIHRvCnJlYWQuIEknbSBh
bGwgZm9yIGltcHJvdmluZyBjbGFyaXR5LCBidXQgdGhlcmUgZG9lcyBoYXZlIHRvIGJlIGEgY2xl
YXIKaW1wcm92ZW1lbnQgdG8ganVzdGlmeSBjaGFuZ2luZyB0aGlzLgoKSSdtIGVzcGVjaWFsbHkg
c3VzcGljaW91cyBvZiBkdXBsaWNhdGluZyB0aGUgaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQoKQpj
YWxscyBhbmQgdGhlIHJldHVybnMuIEl0IHNldHMgYSBwcmVjZWRlbnQgdG8gZHVwbGljYXRlIHRo
ZW0gYWdhaW4sIGFuZApzb21lb25lJ3MgYm91bmQgdG8gZm9yZ2V0IHRvIHB1dC4KCkJSLApKYW5p
LAoKCgo+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4g
Q2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6
IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+IFNp
Z25lZC1vZmYtYnk6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29t
Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgNTUgKysrKysrKysr
KysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRpb25z
KCspLCAyNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDE1
YTk4MWVmNTk2Ni4uNWE4NGE5MjliYzdkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4g
QEAgLTUwNzcsMjggKzUwNzcsMjAgQEAgaW50ZWxfZHBfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVj
dG9yICpjb25uZWN0b3IsCj4gIAo+ICAJaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYs
IGludGVsX2RwLT5hdXhfcG93ZXJfZG9tYWluKTsKPiAgCj4gLQkvKiBDYW4ndCBkaXNjb25uZWN0
IGVEUCAqLwo+ICsJLyogSXMgcG9ydCBjb25uZWN0ZWQ/IGVEUCBjYW4ndCBiZSBkaXNjb25uZWN0
ZWQgKi8KPiArCWlmICghaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSAmJgo+ICsJICAgICFpbnRl
bF9kaWdpdGFsX3BvcnRfY29ubmVjdGVkKGVuY29kZXIpKSB7Cj4gKwkJc3RhdHVzID0gY29ubmVj
dG9yX3N0YXR1c19kaXNjb25uZWN0ZWQ7Cj4gKwkJZ290byBwb3J0X2Rpc2Nvbm5lY3RlZDsKPiAr
CX0KPiArCj4gIAlpZiAoaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSkKPiAgCQlzdGF0dXMgPSBl
ZHBfZGV0ZWN0KGludGVsX2RwKTsKPiAtCWVsc2UgaWYgKGludGVsX2RpZ2l0YWxfcG9ydF9jb25u
ZWN0ZWQoZW5jb2RlcikpCj4gLQkJc3RhdHVzID0gaW50ZWxfZHBfZGV0ZWN0X2RwY2QoaW50ZWxf
ZHApOwo+ICAJZWxzZQo+IC0JCXN0YXR1cyA9IGNvbm5lY3Rvcl9zdGF0dXNfZGlzY29ubmVjdGVk
Owo+IC0KPiAtCWlmIChzdGF0dXMgPT0gY29ubmVjdG9yX3N0YXR1c19kaXNjb25uZWN0ZWQpIHsK
PiAtCQltZW1zZXQoJmludGVsX2RwLT5jb21wbGlhbmNlLCAwLCBzaXplb2YoaW50ZWxfZHAtPmNv
bXBsaWFuY2UpKTsKPiAtCj4gLQkJaWYgKGludGVsX2RwLT5pc19tc3QpIHsKPiAtCQkJRFJNX0RF
QlVHX0tNUygiTVNUIGRldmljZSBtYXkgaGF2ZSBkaXNhcHBlYXJlZCAlZCB2cyAlZFxuIiwKPiAt
CQkJCSAgICAgIGludGVsX2RwLT5pc19tc3QsCj4gLQkJCQkgICAgICBpbnRlbF9kcC0+bXN0X21n
ci5tc3Rfc3RhdGUpOwo+IC0JCQlpbnRlbF9kcC0+aXNfbXN0ID0gZmFsc2U7Cj4gLQkJCWRybV9k
cF9tc3RfdG9wb2xvZ3lfbWdyX3NldF9tc3QoJmludGVsX2RwLT5tc3RfbWdyLAo+IC0JCQkJCQkJ
aW50ZWxfZHAtPmlzX21zdCk7Cj4gLQkJfQo+ICsJCXN0YXR1cyA9IGludGVsX2RwX2RldGVjdF9k
cGNkKGludGVsX2RwKTsKPiAgCj4gLQkJZ290byBvdXQ7Cj4gLQl9Cj4gKwlpZiAoc3RhdHVzID09
IGNvbm5lY3Rvcl9zdGF0dXNfZGlzY29ubmVjdGVkKQo+ICsJCWdvdG8gcG9ydF9ub3RfZGV0ZWN0
ZWQ7Cj4gIAo+ICAJaWYgKGludGVsX2RwLT5yZXNldF9saW5rX3BhcmFtcykgewo+ICAJCS8qIElu
aXRpYWwgbWF4IGxpbmsgbGFuZSBjb3VudCAqLwo+IEBAIC01MTIzLDggKzUxMTUsOCBAQCBpbnRl
bF9kcF9kZXRlY3Qoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQkgKiB3b24n
dCBhcHBlYXIgY29ubmVjdGVkIG9yIGhhdmUgYW55dGhpbmcKPiAgCQkgKiB3aXRoIEVESUQgb24g
aXQKPiAgCQkgKi8KPiAtCQlzdGF0dXMgPSBjb25uZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZDsK
PiAtCQlnb3RvIG91dDsKPiArCQlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgaW50
ZWxfZHAtPmF1eF9wb3dlcl9kb21haW4pOwo+ICsJCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX2Rp
c2Nvbm5lY3RlZDsKPiAgCX0KPiAgCj4gIAkvKgo+IEBAIC01MTUxLDE0ICs1MTQzLDI5IEBAIGlu
dGVsX2RwX2RldGVjdChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJaW50ZWxf
ZHAtPmF1eC5pMmNfZGVmZXJfY291bnQgPSAwOwo+ICAKPiAgCWludGVsX2RwX3NldF9lZGlkKGlu
dGVsX2RwKTsKPiAtCWlmIChpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApIHx8Cj4gLQkgICAgdG9f
aW50ZWxfY29ubmVjdG9yKGNvbm5lY3RvciktPmRldGVjdF9lZGlkKQo+ICsJLyoKPiArCSAqIGlu
dGVsX2RwX2RldGVjdF9kcGNkKCkgd2lsbCByZXR1cm4gY29ubmVjdG9yX3N0YXR1c191bmtub3du
IGZvciBzb21lCj4gKwkgKiB0eXBlIG9mIERQIGRldmljZXMsIGlmIGVkaWQgY2FuIGJlIHJlYWQg
c2V0IHN0YXR1cyBhcyBjb25uZWN0ZWQKPiArCSAqLwo+ICsJaWYgKHRvX2ludGVsX2Nvbm5lY3Rv
cihjb25uZWN0b3IpLT5kZXRlY3RfZWRpZCkKPiAgCQlzdGF0dXMgPSBjb25uZWN0b3Jfc3RhdHVz
X2Nvbm5lY3RlZDsKPiAgCj4gIAlpbnRlbF9kcF9jaGVja19zZXJ2aWNlX2lycShpbnRlbF9kcCk7
Cj4gIAo+IC1vdXQ6Cj4gLQlpZiAoc3RhdHVzICE9IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVk
ICYmICFpbnRlbF9kcC0+aXNfbXN0KQo+ICsJaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQoZGV2X3By
aXYsIGludGVsX2RwLT5hdXhfcG93ZXJfZG9tYWluKTsKPiArCXJldHVybiBzdGF0dXM7Cj4gKwo+
ICtwb3J0X25vdF9kZXRlY3RlZDoKPiArcG9ydF9kaXNjb25uZWN0ZWQ6Cj4gKwltZW1zZXQoJmlu
dGVsX2RwLT5jb21wbGlhbmNlLCAwLCBzaXplb2YoaW50ZWxfZHAtPmNvbXBsaWFuY2UpKTsKPiAr
Cj4gKwlpZiAoaW50ZWxfZHAtPmlzX21zdCkgewo+ICsJCURSTV9ERUJVR19LTVMoIk1TVCBkZXZp
Y2UgbWF5IGhhdmUgZGlzYXBwZWFyZWQgJWQgdnMgJWRcbiIsCj4gKwkJCSAgICAgIGludGVsX2Rw
LT5pc19tc3QsIGludGVsX2RwLT5tc3RfbWdyLm1zdF9zdGF0ZSk7Cj4gKwkJaW50ZWxfZHAtPmlz
X21zdCA9IGZhbHNlOwo+ICsJCWRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyX3NldF9tc3QoJmludGVs
X2RwLT5tc3RfbWdyLAo+ICsJCQkJCQlpbnRlbF9kcC0+aXNfbXN0KTsKPiArCX0gZWxzZQo+ICAJ
CWludGVsX2RwX3Vuc2V0X2VkaWQoaW50ZWxfZHApOwo+ICAKPiAgCWludGVsX2Rpc3BsYXlfcG93
ZXJfcHV0KGRldl9wcml2LCBpbnRlbF9kcC0+YXV4X3Bvd2VyX2RvbWFpbik7CgotLSAKSmFuaSBO
aWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu
dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v
cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK