From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors
Date: Thu, 02 Nov 2017 12:38:30 +0200 [thread overview]
Message-ID: <87tvyddkyh.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <150946451203.15081.4171110727087971223@mail.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2017-10-31 15:27:33)
>> +static inline struct execlist_port *
>> +execlists_port_next(struct intel_engine_execlists * const execlists,
>> + const struct execlist_port * const port)
>> +{
>> + const unsigned int n = __port_add(port_index(port, execlists),
>> + 1,
>> + execlists->port_mask);
>
> How does this compare to
>
> if (port++ == execlists->port + execlists->port_mask)
> port = execlists->port;
>
> return port;
> ?
add/remove: 0/0 grow/shrink: 1/1 up/down: 29/-29 (0)
function old new delta
i915_guc_irq_handler 2584 2613 +29
intel_lrc_irq_handler 2963 2934 -29
Total: Before=1123627, After=1123627, chg +0.00%
:)
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-02 10:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 15:27 [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors Mika Kuoppala
2017-10-31 15:27 ` [PATCH 2/2] drm/i915: Move execlists port head instead of memmoving array Mika Kuoppala
2017-10-31 15:42 ` Chris Wilson
2017-11-02 15:07 ` Chris Wilson
2017-11-22 13:52 ` Mika Kuoppala
2017-11-22 13:57 ` Chris Wilson
2017-10-31 15:41 ` [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors Chris Wilson
2017-10-31 15:56 ` Chris Wilson
2017-11-02 10:38 ` Mika Kuoppala [this message]
2017-11-02 10:57 ` Chris Wilson
2017-11-02 14:14 ` Mika Kuoppala
2017-11-02 14:15 ` Mika Kuoppala
2017-10-31 15:51 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2017-11-02 14:32 ` [PATCH 1/2] " Mika Kuoppala
2017-11-02 15:03 ` Chris Wilson
-- strict thread matches above, loose matches on Subject: below --
2017-11-30 9:10 [PATCH 0/2] execlist port handling improvements Mika Kuoppala
2017-11-30 9:10 ` [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors Mika Kuoppala
2017-11-30 10:21 ` Chris Wilson
2017-10-19 14:39 Mika Kuoppala
2017-10-19 14:48 ` Chris Wilson
2017-10-20 12:00 ` Mika Kuoppala
2017-10-19 14:50 ` Chris Wilson
2017-10-20 10:34 ` Joonas Lahtinen
2017-10-20 11:12 ` Mika Kuoppala
2017-10-20 11:26 ` Chris Wilson
2017-10-20 12:53 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvyddkyh.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox