From: Jani Nikula <jani.nikula@intel.com>
To: Madhav Chauhan <madhav.chauhan@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: shashidhar.hiremath@intel.com
Subject: Re: [PATCH 2/2] drm/i915: Use existing DSI backlight ports info
Date: Fri, 13 Oct 2017 17:33:07 +0300 [thread overview]
Message-ID: <87tvz3jexo.fsf@intel.com> (raw)
In-Reply-To: <1507898700-20016-2-git-send-email-madhav.chauhan@intel.com>
On Fri, 13 Oct 2017, Madhav Chauhan <madhav.chauhan@intel.com> wrote:
> This patch re-use already parsed DSI backlight/cabc ports
> info for saving it inside struct intel_dsi rather than
> parsing it at the time of DSI initialization.
>
> V2: Remove backlight and cabc variable initialization (Jani N).
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Madhav Chauhan <madhav.chauhan@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_bios.c | 2 --
> drivers/gpu/drm/i915/intel_dsi.c | 37 ++++---------------------------------
> 2 files changed, 4 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index fb30f9a..0ee0cb1 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -738,8 +738,6 @@ static void parse_dsi_backlight_ports(struct drm_i915_private *dev_priv,
> if (dev_priv->vbt.dsi.config->cabc_supported)
> dev_priv->vbt.dsi.cabc_ports = BIT(port);
>
> - dev_priv->vbt.dsi.config->dl_dcs_cabc_ports = 0;
> - dev_priv->vbt.dsi.config->dl_dcs_backlight_ports = 0;
> return;
> }
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 20a7b00..6d21ae8 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -1746,42 +1746,13 @@ void intel_dsi_init(struct drm_i915_private *dev_priv)
> else
> intel_encoder->crtc_mask = BIT(PIPE_B);
>
> - if (dev_priv->vbt.dsi.config->dual_link) {
> + if (dev_priv->vbt.dsi.config->dual_link)
> intel_dsi->ports = BIT(PORT_A) | BIT(PORT_C);
> -
> - switch (dev_priv->vbt.dsi.config->dl_dcs_backlight_ports) {
> - case DL_DCS_PORT_A:
> - intel_dsi->dcs_backlight_ports = BIT(PORT_A);
> - break;
> - case DL_DCS_PORT_C:
> - intel_dsi->dcs_backlight_ports = BIT(PORT_C);
> - break;
> - default:
> - case DL_DCS_PORT_A_AND_C:
> - intel_dsi->dcs_backlight_ports = BIT(PORT_A) | BIT(PORT_C);
> - break;
> - }
> -
> - switch (dev_priv->vbt.dsi.config->dl_dcs_cabc_ports) {
> - case DL_DCS_PORT_A:
> - intel_dsi->dcs_cabc_ports = BIT(PORT_A);
> - break;
> - case DL_DCS_PORT_C:
> - intel_dsi->dcs_cabc_ports = BIT(PORT_C);
> - break;
> - default:
> - case DL_DCS_PORT_A_AND_C:
> - intel_dsi->dcs_cabc_ports = BIT(PORT_A) | BIT(PORT_C);
> - break;
> - }
> - } else {
> + else
> intel_dsi->ports = BIT(port);
> - intel_dsi->dcs_backlight_ports = BIT(port);
> - intel_dsi->dcs_cabc_ports = BIT(port);
> - }
>
> - if (!dev_priv->vbt.dsi.config->cabc_supported)
> - intel_dsi->dcs_cabc_ports = 0;
> + intel_dsi->dcs_backlight_ports = dev_priv->vbt.dsi.bl_ports;
> + intel_dsi->dcs_cabc_ports = dev_priv->vbt.dsi.cabc_ports;
>
> /* Create a DSI host (and a device) for each port. */
> for_each_dsi_port(port, intel_dsi->ports) {
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-13 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 12:44 [PATCH 1/2] drm/i915: Parse DSI backlight/cabc ports Madhav Chauhan
2017-10-13 12:45 ` [PATCH 2/2] drm/i915: Use existing DSI backlight ports info Madhav Chauhan
2017-10-13 14:33 ` Jani Nikula [this message]
2017-10-13 13:56 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Parse DSI backlight/cabc ports Patchwork
2017-10-13 14:32 ` [PATCH 1/2] " Jani Nikula
2017-10-13 17:14 ` ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2017-10-11 10:37 [PATCH 1/2] " Madhav Chauhan
2017-10-11 10:37 ` [PATCH 2/2] drm/i915: Use existing DSI backlight ports info Madhav Chauhan
2017-10-03 7:17 [PATCH 1/2] drm/i915: Parse DSI backlight/cabc ports Madhav Chauhan
2017-10-03 7:17 ` [PATCH 2/2] drm/i915: Use existing DSI backlight ports info Madhav Chauhan
2017-10-10 7:19 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvz3jexo.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=madhav.chauhan@intel.com \
--cc=shashidhar.hiremath@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).