From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 3/3] drm: handle override edid and firmware EDID at drm_do_get_edid() level Date: Thu, 16 Feb 2017 19:54:00 +0200 Message-ID: <87tw7udnt3.fsf@intel.com> References: <20170216154132.GF31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170216154132.GF31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Abdiel Janulgue , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxNiBGZWIgMjAxNywgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gVGh1LCBGZWIgMTYsIDIwMTcgYXQgMTI6MzY6NDVQTSAr MDIwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IEhhbmRsZSBkZWJ1Z2ZzIG92ZXJyaWRlIGVkaWQg YW5kIGZpcm13YXJlIGVkaWQgYXQgdGhlIGxvdyBsZXZlbCB0bwo+PiB0cmFuc3BhcmVudGx5IGFu ZCBjb21wbGV0ZWx5IHJlcGxhY2UgdGhlIHJlYWwgZWRpZC4gUHJldmlvdXNseSwgd2UKPj4gcHJh Y3RpY2FsbHkgb25seSB1c2VkIHRoZSBtb2RlcyBmcm9tIHRoZSBvdmVycmlkZSBFRElELCBhbmQg bm9uZSBvZiB0aGUKPj4gb3RoZXIgZGF0YS4gVGhpcyBhbHNvIHByZXZlbnRzIGFjdHVhbCBFRElE IHJlYWRzIHdoZW4gdGhlIEVESUQgaXMgdG8gYmUKPj4gb3ZlcnJpZGRlbiwgYnV0IHJldGFpbnMg dGhlIEREQyBwcm9iZS4KPgo+IEhtbS4gSXNuJ3QgdGhhdCBhIGJhZCB0aGluZz8gSWYgc29tZW9u ZSBoYXMgYnJva2VuIEREQyBvbiB0aGVpciBjYWJsZSBvcgo+IHNvbWV0aGlnbiB0aGVuIHRoZSBv dmVycmlkZSBFRElEIHdvdWxkbid0IGJlIHJldHVybmVkIGJ5IGRybV9nZXRfZWRpZCgpLgoKSXNu J3QgdGhpcyBpbiBsaW5lIHdpdGggaG93IHRoaXMgY3VycmVudGx5IHdvcmtzPwoKQlIsCkphbmku CgoKPgo+PiAKPj4gRklYTUU6IHZhbGlkYXRlIG92ZXJyaWRlIGVkaWQsIGRlZHVwbGljYXRlIGZp cm13YXJlIGVkaWQgdmFsaWRhdGlvbi4KPj4gCj4+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxh IDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9l ZGlkLmMgICAgICAgICB8IDE1ICsrKysrKysrKysrKysrKwo+PiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9wcm9iZV9oZWxwZXIuYyB8IDE5ICstLS0tLS0tLS0tLS0tLS0tLS0KPj4gIDIgZmlsZXMgY2hh bmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQu Ywo+PiBpbmRleCAzNjIwMzYzNjA3MjQuLjA1NGUyZDc0ZWFmYyAxMDA2NDQKPj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9lZGlkLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlk LmMKPj4gQEAgLTEzMDksNiArMTMwOSwxMCBAQCBzdGF0aWMgdm9pZCBjb25uZWN0b3JfYmFkX2Vk aWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4gICAqIGxldmVsLCBkcml2ZXJz IG11c3QgbWFrZSBhbGwgcmVhc29uYWJsZSBlZmZvcnRzIHRvIGV4cG9zZSBpdCBhcyBhbiBJMkMK Pj4gICAqIGFkYXB0ZXIgYW5kIHVzZSBkcm1fZ2V0X2VkaWQoKSBpbnN0ZWFkIG9mIGFidXNpbmcg dGhpcyBmdW5jdGlvbi4KPj4gICAqCj4+ICsgKiBUaGUgRURJRCBtYXkgYmUgb3ZlcnJpZGRlbiB1 c2luZyBkZWJ1Z2ZzIG92ZXJyaWRlX2VkaWQgb3IgZmlybWFyZSBFRElECj4+ICsgKiAoZHJtX2xv YWRfZWRpZF9maXJtd2FyZSgpKSwgaW4gdGhpcyBwcmlvcml0eSBvcmRlci4gSGF2aW5nIGVpdGhl ciBvZiB0aGVtCj4+ICsgKiBieXBhc3NlcyBhY3R1YWwgRURJRCByZWFkcy4KPj4gKyAqCj4+ICAg KiBSZXR1cm46IFBvaW50ZXIgdG8gdmFsaWQgRURJRCBvciBOVUxMIGlmIHdlIGNvdWxkbid0IGZp bmQgYW55Lgo+PiAgICovCj4+ICBzdHJ1Y3QgZWRpZCAqZHJtX2RvX2dldF9lZGlkKHN0cnVjdCBk cm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+IEBAIC0xMzE4LDYgKzEzMjIsMTcgQEAgc3RydWN0 IGVkaWQgKmRybV9kb19nZXRfZWRpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ PiAgewo+PiAgCWludCBpLCBqID0gMCwgdmFsaWRfZXh0ZW5zaW9ucyA9IDA7Cj4+ICAJdTggKmVk aWQsICpuZXc7Cj4+ICsJc3RydWN0IGVkaWQgKm92ZXJyaWRlID0gTlVMTDsKPj4gKwo+PiArCWlm IChjb25uZWN0b3ItPm92ZXJyaWRlX2VkaWQpCj4+ICsJCW92ZXJyaWRlID0gZHJtX2VkaWRfZHVw bGljYXRlKChjb25zdCBzdHJ1Y3QgZWRpZCAqKQo+PiArCQkJCQkgICAgICBjb25uZWN0b3ItPmVk aWRfYmxvYl9wdHItPmRhdGEpOwo+PiArCj4+ICsJaWYgKCFvdmVycmlkZSkKPj4gKwkJb3ZlcnJp ZGUgPSBkcm1fbG9hZF9lZGlkX2Zpcm13YXJlKGNvbm5lY3Rvcik7Cj4+ICsKPj4gKwlpZiAoIUlT X0VSUl9PUl9OVUxMKG92ZXJyaWRlKSkKPj4gKwkJcmV0dXJuIG92ZXJyaWRlOwo+PiAgCj4+ICAJ aWYgKChlZGlkID0ga21hbGxvYyhFRElEX0xFTkdUSCwgR0ZQX0tFUk5FTCkpID09IE5VTEwpCj4+ ICAJCXJldHVybiBOVUxMOwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9i ZV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMKPj4gaW5kZXgg MzU4OTU3MTE4Y2E5Li44NzEzMjZjYmM0NjUgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fcHJvYmVfaGVscGVyLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9o ZWxwZXIuYwo+PiBAQCAtMTk5LDggKzE5OSw2IEBAIGRybV9jb25uZWN0b3JfZGV0ZWN0KHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsIGJvb2wgZm9yY2UpCj4+ICAgKiAgICBkcm1fbW9k ZV9wcm9iZWRfYWRkKCkuIE5ldyBtb2RlcyBzdGFydCB0aGVpciBsaWZlIHdpdGggc3RhdHVzIGFz IE9LLgo+PiAgICogICAgTW9kZXMgYXJlIGFkZGVkIGZyb20gYSBzaW5nbGUgc291cmNlIHVzaW5n IHRoZSBmb2xsb3dpbmcgcHJpb3JpdHkgb3JkZXIuCj4+ICAgKgo+PiAtICogICAgLSBkZWJ1Z2Zz ICdvdmVycmlkZV9lZGlkJyAodXNlZCBmb3IgdGVzdGluZyBvbmx5KQo+PiAtICogICAgLSBmaXJt d2FyZSBFRElEIChkcm1fbG9hZF9lZGlkX2Zpcm13YXJlKCkpCj4+ICAgKiAgICAtICZkcm1fY29u bmVjdG9yX2hlbHBlcl9mdW5jcy5nZXRfbW9kZXMgdmZ1bmMKPj4gICAqICAgIC0gaWYgdGhlIGNv bm5lY3RvciBzdGF0dXMgaXMgY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQsIHN0YW5kYXJkCj4+ ICAgKiAgICAgIFZFU0EgRE1UIG1vZGVzIHVwIHRvIDEwMjR4NzY4IGFyZSBhdXRvbWF0aWNhbGx5 IGFkZGVkCj4+IEBAIC0zMDUsMjIgKzMwMyw3IEBAIGludCBkcm1faGVscGVyX3Byb2JlX3Npbmds ZV9jb25uZWN0b3JfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4gIAkJ Z290byBwcnVuZTsKPj4gIAl9Cj4+ICAKPj4gLQlpZiAoY29ubmVjdG9yLT5vdmVycmlkZV9lZGlk KSB7Cj4+IC0JCXN0cnVjdCBlZGlkICplZGlkID0gKHN0cnVjdCBlZGlkICopIGNvbm5lY3Rvci0+ ZWRpZF9ibG9iX3B0ci0+ZGF0YTsKPj4gLQo+PiAtCQljb3VudCA9IGRybV9hZGRfZWRpZF9tb2Rl cyhjb25uZWN0b3IsIGVkaWQpOwo+PiAtCQlkcm1fZWRpZF90b19lbGQoY29ubmVjdG9yLCBlZGlk KTsKPj4gLQl9IGVsc2Ugewo+PiAtCQlzdHJ1Y3QgZWRpZCAqZWRpZCA9IGRybV9sb2FkX2VkaWRf ZmlybXdhcmUoY29ubmVjdG9yKTsKPj4gLQkJaWYgKCFJU19FUlJfT1JfTlVMTChlZGlkKSkgewo+ PiAtCQkJZHJtX21vZGVfY29ubmVjdG9yX3VwZGF0ZV9lZGlkX3Byb3BlcnR5KGNvbm5lY3Rvciwg ZWRpZCk7Cj4+IC0JCQljb3VudCA9IGRybV9hZGRfZWRpZF9tb2Rlcyhjb25uZWN0b3IsIGVkaWQp Owo+PiAtCQkJZHJtX2VkaWRfdG9fZWxkKGNvbm5lY3RvciwgZWRpZCk7Cj4+IC0JCQlrZnJlZShl ZGlkKTsKPj4gLQkJfQo+PiAtCQlpZiAoY291bnQgPT0gMCkKPj4gLQkJCWNvdW50ID0gKCpjb25u ZWN0b3JfZnVuY3MtPmdldF9tb2RlcykoY29ubmVjdG9yKTsKPj4gLQl9Cj4+ICsJY291bnQgPSAo KmNvbm5lY3Rvcl9mdW5jcy0+Z2V0X21vZGVzKShjb25uZWN0b3IpOwo+PiAgCj4+ICAJaWYgKGNv dW50ID09IDAgJiYgY29ubmVjdG9yLT5zdGF0dXMgPT0gY29ubmVjdG9yX3N0YXR1c19jb25uZWN0 ZWQpCj4+ICAJCWNvdW50ID0gZHJtX2FkZF9tb2Rlc19ub2VkaWQoY29ubmVjdG9yLCAxMDI0LCA3 NjgpOwo+PiAtLSAKPj4gMi4xLjQKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2Ug VGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==