[PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Jani Nikula]

This is the next iteration of [1] and [2]. Please review and/or test,
according to your abilities.

Thanks,
Jani.

Cc: Peter Wu <peter@lekensteyn.nl>
Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
Cc: Jan-Marek Glogowski <glogow@fbihome.de>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: Paolo Stivanin <paolostivanin@fastmail.fm>

[1] http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com
[2] http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com

Jani Nikula (2):
  drm/i915: make i915 the source of acpi device ids for _DOD
  drm/i915/opregion: update cadl based on actually active outputs

 drivers/gpu/drm/i915/i915_drv.h       |   4 +
 drivers/gpu/drm/i915/intel_display.c  |   6 ++
 drivers/gpu/drm/i915/intel_drv.h      |   3 +
 drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++---------------------
 4 files changed, 74 insertions(+), 96 deletions(-)

-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 1/2] drm/i915: make i915 the source of acpi device ids for _DOD

[Jani Nikula]

The graphics driver is supposed to define the DIDL, which are used for
_DOD, not the BIOS. Restore that behaviour.

This is basically a revert of

commit 3143751ff51a163b77f7efd389043e038f3e008e
Author: Zhang Rui <rui.zhang@intel.com>
Date:   Mon Mar 29 15:12:16 2010 +0800

    drm/i915: set DIDL using the ACPI video output device _ADR method return.

which went out of its way to cater to a specific BIOS, setting up DIDL
based on _ADR method. Perhaps that approach worked on that specific
machine, but on the machines I checked the _ADR method invents the
device identifiers out of thin air if DIDL has not been set. The source
for _ADR is also supposed to be the DIDL set by the driver, not the
other way around.

With this, we'll also limit the number of outputs to what the driver
actually has.

v2: do not set ACPI_DEVICE_ID_SCHEME in the device id (Peter Wu)

v3: Rebase

Cc: Peter Wu <peter@lekensteyn.nl>
Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
Cc: Jan-Marek Glogowski <glogow@fbihome.de>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: Paolo Stivanin <paolostivanin@fastmail.fm>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-and-tested-by: Peter Wu <peter@lekensteyn.nl>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_drv.h      |  3 ++
 drivers/gpu/drm/i915/intel_opregion.c | 88 ++++++++++-------------------------
 2 files changed, 27 insertions(+), 64 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 570a7ca7983f..0f357bb0b3cb 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -286,6 +286,9 @@ struct intel_connector {
 	 */
 	struct intel_encoder *encoder;
 
+	/* ACPI device id for ACPI and driver cooperation */
+	u32 acpi_device_id;
+
 	/* Reads out the current hw, returning true if the connector is enabled
 	 * and active (i.e. dpms ON state). */
 	bool (*get_hw_state)(struct intel_connector *);
diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index adca262d591a..b2caf151c3fa 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -674,11 +674,11 @@ static void set_did(struct intel_opregion *opregion, int i, u32 val)
 	}
 }
 
-static u32 acpi_display_type(struct drm_connector *connector)
+static u32 acpi_display_type(struct intel_connector *connector)
 {
 	u32 display_type;
 
-	switch (connector->connector_type) {
+	switch (connector->base.connector_type) {
 	case DRM_MODE_CONNECTOR_VGA:
 	case DRM_MODE_CONNECTOR_DVIA:
 		display_type = ACPI_DISPLAY_TYPE_VGA;
@@ -707,7 +707,7 @@ static u32 acpi_display_type(struct drm_connector *connector)
 		display_type = ACPI_DISPLAY_TYPE_OTHER;
 		break;
 	default:
-		MISSING_CASE(connector->connector_type);
+		MISSING_CASE(connector->base.connector_type);
 		display_type = ACPI_DISPLAY_TYPE_OTHER;
 		break;
 	}
@@ -718,34 +718,9 @@ static u32 acpi_display_type(struct drm_connector *connector)
 static void intel_didl_outputs(struct drm_i915_private *dev_priv)
 {
 	struct intel_opregion *opregion = &dev_priv->opregion;
-	struct pci_dev *pdev = dev_priv->drm.pdev;
-	struct drm_connector *connector;
-	acpi_handle handle;
-	struct acpi_device *acpi_dev, *acpi_cdev, *acpi_video_bus = NULL;
-	unsigned long long device_id;
-	acpi_status status;
-	u32 temp, max_outputs;
-	int i = 0;
-
-	handle = ACPI_HANDLE(&pdev->dev);
-	if (!handle || acpi_bus_get_device(handle, &acpi_dev))
-		return;
-
-	if (acpi_is_video_device(handle))
-		acpi_video_bus = acpi_dev;
-	else {
-		list_for_each_entry(acpi_cdev, &acpi_dev->children, node) {
-			if (acpi_is_video_device(acpi_cdev->handle)) {
-				acpi_video_bus = acpi_cdev;
-				break;
-			}
-		}
-	}
-
-	if (!acpi_video_bus) {
-		DRM_DEBUG_KMS("No ACPI video bus found\n");
-		return;
-	}
+	struct intel_connector *connector;
+	int i = 0, max_outputs;
+	int display_index[16] = {};
 
 	/*
 	 * In theory, did2, the extended didl, gets added at opregion version
@@ -757,46 +732,31 @@ static void intel_didl_outputs(struct drm_i915_private *dev_priv)
 	max_outputs = ARRAY_SIZE(opregion->acpi->didl) +
 		ARRAY_SIZE(opregion->acpi->did2);
 
-	list_for_each_entry(acpi_cdev, &acpi_video_bus->children, node) {
-		if (i >= max_outputs) {
-			DRM_DEBUG_KMS("More than %u outputs detected via ACPI\n",
-				      max_outputs);
-			return;
-		}
-		status = acpi_evaluate_integer(acpi_cdev->handle, "_ADR",
-					       NULL, &device_id);
-		if (ACPI_SUCCESS(status)) {
-			if (!device_id)
-				goto blind_set;
-			set_did(opregion, i++, (u32)(device_id & 0x0f0f));
-		}
+	for_each_intel_connector(&dev_priv->drm, connector) {
+		u32 device_id, type;
+
+		device_id = acpi_display_type(connector);
+
+		/* Use display type specific display index. */
+		type = (device_id & ACPI_DISPLAY_TYPE_MASK)
+			>> ACPI_DISPLAY_TYPE_SHIFT;
+		device_id |= display_index[type]++ << ACPI_DISPLAY_INDEX_SHIFT;
+
+		connector->acpi_device_id = device_id;
+		if (i < max_outputs)
+			set_did(opregion, i, device_id);
+		i++;
 	}
 
-end:
 	DRM_DEBUG_KMS("%d outputs detected\n", i);
 
+	if (i > max_outputs)
+		DRM_ERROR("More than %d outputs in connector list\n",
+			  max_outputs);
+
 	/* If fewer than max outputs, the list must be null terminated */
 	if (i < max_outputs)
 		set_did(opregion, i, 0);
-	return;
-
-blind_set:
-	i = 0;
-	list_for_each_entry(connector,
-			    &dev_priv->drm.mode_config.connector_list, head) {
-		int display_type = acpi_display_type(connector);
-
-		if (i >= max_outputs) {
-			DRM_DEBUG_KMS("More than %u outputs in connector list\n",
-				      max_outputs);
-			return;
-		}
-
-		temp = get_did(opregion, i);
-		set_did(opregion, i, temp | (1 << 31) | display_type | i);
-		i++;
-	}
-	goto end;
 }
 
 static void intel_setup_cadls(struct drm_i915_private *dev_priv)
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/2] drm/i915/opregion: update cadl based on actually active outputs

[Jani Nikula]

Previously we've just shoved the first eight devices in DIDL to CADL
(list of active outputs). Some of the active outputs may have been left
outside of CADL. The problem is, some BIOS implementations prevent
laptop brightness hotkey propagation if the flat panel is not active.

Now that we have connector to acpi device id mapping covered, we can
update CADL based on which outputs are actually active.

v3: actually git add the dev->dev_priv change.

v4: update cadl in intel_shared_dpll_commit() if intel_state->modeset
    (Maarten)

v5: use crtc mask, not ->active to determine active outputs (Maarten)
    Move first cadl update to after hardware readout (Maarten)

Cc: Peter Wu <peter@lekensteyn.nl>
Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
Cc: Jan-Marek Glogowski <glogow@fbihome.de>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: Paolo Stivanin <paolostivanin@fastmail.fm>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-and-tested-by: Peter Wu <peter@lekensteyn.nl>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h       |  4 ++
 drivers/gpu/drm/i915/intel_display.c  |  6 +++
 drivers/gpu/drm/i915/intel_opregion.c | 71 +++++++++++++++++++----------------
 3 files changed, 48 insertions(+), 33 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 04b4fd6c32e4..bc7825e16526 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -3610,6 +3610,8 @@ extern int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder,
 extern int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv,
 					 pci_power_t state);
 extern int intel_opregion_get_panel_type(struct drm_i915_private *dev_priv);
+extern void intel_opregion_update_cadl(struct drm_i915_private *dev_priv,
+				       unsigned int active_crtcs);
 #else
 static inline int intel_opregion_setup(struct drm_i915_private *dev) { return 0; }
 static inline void intel_opregion_register(struct drm_i915_private *dev_priv) { }
@@ -3631,6 +3633,8 @@ static inline int intel_opregion_get_panel_type(struct drm_i915_private *dev)
 {
 	return -ENODEV;
 }
+static inline void intel_opregion_update_cadl(struct drm_i915_private *dev_priv,
+					      unsigned int active_crtcs) { }
 #endif
 
 /* intel_acpi.c */
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index e4e6141b38c0..c3e8eae8cbd5 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14537,6 +14537,10 @@ static int intel_atomic_commit(struct drm_device *dev,
 	dev_priv->wm.distrust_bios_wm = false;
 	dev_priv->wm.skl_results = intel_state->wm_results;
 	intel_shared_dpll_commit(state);
+
+	if (intel_state->modeset)
+		intel_opregion_update_cadl(dev_priv, intel_state->active_crtcs);
+
 	intel_atomic_track_fbs(state);
 
 	if (nonblock)
@@ -16927,6 +16931,8 @@ intel_modeset_setup_hw_state(struct drm_device *dev)
 	intel_display_set_init_power(dev_priv, false);
 
 	intel_fbc_init_pipe_state(dev_priv);
+
+	intel_opregion_update_cadl(dev_priv, dev_priv->active_crtcs);
 }
 
 void intel_display_resume(struct drm_device *dev)
diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index b2caf151c3fa..4239ac230a41 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -642,24 +642,6 @@ static struct notifier_block intel_opregion_notifier = {
  * (version 3)
  */
 
-static u32 get_did(struct intel_opregion *opregion, int i)
-{
-	u32 did;
-
-	if (i < ARRAY_SIZE(opregion->acpi->didl)) {
-		did = opregion->acpi->didl[i];
-	} else {
-		i -= ARRAY_SIZE(opregion->acpi->didl);
-
-		if (WARN_ON(i >= ARRAY_SIZE(opregion->acpi->did2)))
-			return 0;
-
-		did = opregion->acpi->did2[i];
-	}
-
-	return did;
-}
-
 static void set_did(struct intel_opregion *opregion, int i, u32 val)
 {
 	if (i < ARRAY_SIZE(opregion->acpi->didl)) {
@@ -674,6 +656,14 @@ static void set_did(struct intel_opregion *opregion, int i, u32 val)
 	}
 }
 
+static void set_cad(struct intel_opregion *opregion, int i, u32 val)
+{
+	if (WARN_ON(i >= ARRAY_SIZE(opregion->acpi->cadl)))
+		return;
+
+	opregion->acpi->cadl[i] = val;
+}
+
 static u32 acpi_display_type(struct intel_connector *connector)
 {
 	u32 display_type;
@@ -759,22 +749,38 @@ static void intel_didl_outputs(struct drm_i915_private *dev_priv)
 		set_did(opregion, i, 0);
 }
 
-static void intel_setup_cadls(struct drm_i915_private *dev_priv)
+/* Update CADL to reflect active outputs. */
+void intel_opregion_update_cadl(struct drm_i915_private *dev_priv,
+				unsigned int active_crtcs)
 {
+	struct drm_device *dev = &dev_priv->drm;
 	struct intel_opregion *opregion = &dev_priv->opregion;
-	int i = 0;
-	u32 disp_id;
-
-	/* Initialize the CADL field by duplicating the DIDL values.
-	 * Technically, this is not always correct as display outputs may exist,
-	 * but not active. This initialization is necessary for some Clevo
-	 * laptops that check this field before processing the brightness and
-	 * display switching hotkeys. Just like DIDL, CADL is NULL-terminated if
-	 * there are less than eight devices. */
-	do {
-		disp_id = get_did(opregion, i);
-		opregion->acpi->cadl[i] = disp_id;
-	} while (++i < 8 && disp_id != 0);
+	struct intel_crtc *crtc;
+	int i = 0, max_active = ARRAY_SIZE(opregion->acpi->cadl);
+
+	if (!opregion->acpi)
+		return;
+
+	for_each_intel_crtc_mask(dev, crtc, active_crtcs) {
+		struct intel_encoder *encoder;
+
+		for_each_encoder_on_crtc(dev, &crtc->base, encoder) {
+			struct intel_connector *connector;
+
+			for_each_connector_on_encoder(dev, &encoder->base, connector) {
+				if (i >= max_active) {
+					DRM_DEBUG_KMS("too many outputs active\n");
+					return;
+				}
+
+				set_cad(opregion, i++, connector->acpi_device_id);
+			}
+		}
+	}
+
+	/* If fewer than max active outputs, the list must be null terminated */
+	if (i < max_active)
+		set_cad(opregion, i, 0);
 }
 
 void intel_opregion_register(struct drm_i915_private *dev_priv)
@@ -786,7 +792,6 @@ void intel_opregion_register(struct drm_i915_private *dev_priv)
 
 	if (opregion->acpi) {
 		intel_didl_outputs(dev_priv);
-		intel_setup_cadls(dev_priv);
 
 		/* Notify BIOS we are ready to handle ACPI video ext notifs.
 		 * Right now, all the events are handled by the ACPI video module.
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915/opregion: update cadl based on actually active outputs

[Maarten Lankhorst]

Op 25-08-16 om 14:53 schreef Jani Nikula:
> Previously we've just shoved the first eight devices in DIDL to CADL
> (list of active outputs). Some of the active outputs may have been left
> outside of CADL. The problem is, some BIOS implementations prevent
> laptop brightness hotkey propagation if the flat panel is not active.
>
> Now that we have connector to acpi device id mapping covered, we can
> update CADL based on which outputs are actually active.
>
> v3: actually git add the dev->dev_priv change.
>
> v4: update cadl in intel_shared_dpll_commit() if intel_state->modeset
>     (Maarten)
>
> v5: use crtc mask, not ->active to determine active outputs (Maarten)
>     Move first cadl update to after hardware readout (Maarten)
Much better! I don't dare to do a thorough review of the non-atomicy parts, but idea looks good.

Acked-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: warning for drm/i915/opregion: proper handling of DIDL and CADL

[Patchwork]

== Series Details ==

Series: drm/i915/opregion: proper handling of DIDL and CADL
URL   : https://patchwork.freedesktop.org/series/11565/
State : warning

== Summary ==

Series 11565v1 drm/i915/opregion: proper handling of DIDL and CADL
http://patchwork.freedesktop.org/api/1.0/series/11565/revisions/1/mbox/

Test gem_ringfill:
        Subgroup basic-default-forked:
                pass       -> DMESG-WARN (fi-snb-2520m)
                dmesg-warn -> PASS       (fi-snb-2600)
        Subgroup basic-default-hang:
                dmesg-warn -> PASS       (fi-snb-2520m)
                pass       -> DMESG-WARN (fi-snb-2600)

fi-bdw-5557u     total:252  pass:235  dwarn:0   dfail:0   fail:2   skip:15 
fi-bsw-n3050     total:252  pass:205  dwarn:0   dfail:0   fail:1   skip:46 
fi-byt-n2820     total:252  pass:207  dwarn:0   dfail:0   fail:3   skip:42 
fi-hsw-4770k     total:252  pass:228  dwarn:0   dfail:0   fail:2   skip:22 
fi-hsw-4770r     total:252  pass:224  dwarn:0   dfail:0   fail:2   skip:26 
fi-ivb-3520m     total:252  pass:220  dwarn:0   dfail:0   fail:1   skip:31 
fi-skl-6260u     total:252  pass:236  dwarn:0   dfail:0   fail:2   skip:14 
fi-skl-6700k     total:252  pass:222  dwarn:0   dfail:0   fail:2   skip:28 
fi-snb-2520m     total:252  pass:199  dwarn:8   dfail:0   fail:2   skip:43 
fi-snb-2600      total:252  pass:199  dwarn:8   dfail:0   fail:2   skip:43 

Results at /archive/results/CI_IGT_test/Patchwork_2431/

30de872fd5cf71a51994375fb4f76856c05b1c4c drm-intel-nightly: 2016y-08m-25d-11h-15m-39s UTC integration manifest
48dafce drm/i915/opregion: update cadl based on actually active outputs
b6f2e44 drm/i915: make i915 the source of acpi device ids for _DOD

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Paolo Stivanin]

Hello,
I applied these patches[1][2] to the latest kernel revision (
4.8.0-rc3-g61c0457) but the brightness keys are not working on my
laptop.
With the older patches from the 29th of June the brightness keys were
working correctly.

Cheers,

[1] https://patchwork.freedesktop.org/patch/107280/
[2] https://patchwork.freedesktop.org/patch/107281/

-- 
  Paolo Stivanin
  paolostivanin@fastmail.fm
  Public Key ID: E71B7545

On Thu, Aug 25, 2016, at 02:53 PM, Jani Nikula wrote:
> This is the next iteration of [1] and [2]. Please review and/or test,
> according to your abilities.
> 
> Thanks,
> Jani.
> 
> Cc: Peter Wu <peter@lekensteyn.nl>
> Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
> Cc: Jan-Marek Glogowski <glogow@fbihome.de>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> Cc: Paolo Stivanin <paolostivanin@fastmail.fm>
> 
> [1]
> http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com
> [2]
> http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com
> 
> Jani Nikula (2):
>   drm/i915: make i915 the source of acpi device ids for _DOD
>   drm/i915/opregion: update cadl based on actually active outputs
> 
>  drivers/gpu/drm/i915/i915_drv.h       |   4 +
>  drivers/gpu/drm/i915/intel_display.c  |   6 ++
>  drivers/gpu/drm/i915/intel_drv.h      |   3 +
>  drivers/gpu/drm/i915/intel_opregion.c | 157
>  +++++++++++++---------------------
>  4 files changed, 74 insertions(+), 96 deletions(-)
> 
> -- 
> 2.1.4
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Jani Nikula]

On Thu, 25 Aug 2016, Paolo Stivanin <paolostivanin@fastmail.fm> wrote:
> Hello,
> I applied these patches[1][2] to the latest kernel revision (
> 4.8.0-rc3-g61c0457) but the brightness keys are not working on my
> laptop.
> With the older patches from the 29th of June the brightness keys were
> working correctly.

Maarten, any ideas? The only changes are the change from crtc->active to
active_crtcs, and the initialization change.

BR,
Jani.

>
> Cheers,
>
> [1] https://patchwork.freedesktop.org/patch/107280/
> [2] https://patchwork.freedesktop.org/patch/107281/

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Peter Wu]

Hi Jani,

The method is somehow not reliable. At boot I was still able to capture
brightness hotkeys (via acpi_listen). After starting SSDM and logging
in, it still worked. Then I played a bit with PRIME output slaves, Xorg
crashed at some points and hotkeys stopped working.

Inspection of CADL (via acpidbg) showed that it contained zeroes instead
of 0x400. By poking more, suddenly the expected 0x400 value returned
into CADL and hotkeys functioned again. At later moments it reverted to
0 again and hotkeys broke again.

Tracking down setters of active_crcts, I noticed that
intel_modeset_readout_hw_state somehow does not detect eDP1 as active.
Full dmesg log (9MiB) with drm.debug=0x1e (via sysfs) is available at

https://lekensteyn.nl/files/logs/journal-v4.8-rc3-183-g5e608a0-plus-2-cadl-patches.txt

Kind regards,
Peter

On Thu, Aug 25, 2016 at 03:53:02PM +0300, Jani Nikula wrote:
> This is the next iteration of [1] and [2]. Please review and/or test,
> according to your abilities.
> 
> Thanks,
> Jani.
> 
> Cc: Peter Wu <peter@lekensteyn.nl>
> Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
> Cc: Jan-Marek Glogowski <glogow@fbihome.de>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> Cc: Paolo Stivanin <paolostivanin@fastmail.fm>
> 
> [1] http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com
> [2] http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com
> 
> Jani Nikula (2):
>   drm/i915: make i915 the source of acpi device ids for _DOD
>   drm/i915/opregion: update cadl based on actually active outputs
> 
>  drivers/gpu/drm/i915/i915_drv.h       |   4 +
>  drivers/gpu/drm/i915/intel_display.c  |   6 ++
>  drivers/gpu/drm/i915/intel_drv.h      |   3 +
>  drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++---------------------
>  4 files changed, 74 insertions(+), 96 deletions(-)
> 
> -- 
> 2.1.4
> 

-- 
Kind regards,
Peter Wu
https://lekensteyn.nl
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Maarten Lankhorst]

Op 25-08-16 om 20:56 schreef Paolo Stivanin:
> Hello,
> I applied these patches[1][2] to the latest kernel revision (
> 4.8.0-rc3-g61c0457) but the brightness keys are not working on my
> laptop.
> With the older patches from the 29th of June the brightness keys were
> working correctly.
>
> Cheers,
>
> [1] https://patchwork.freedesktop.org/patch/107280/
> [2] https://patchwork.freedesktop.org/patch/107281/
>
Does it work after suspend?

~Maarten

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Marcos Paulo de Souza]

Hi Jani,

These patches made my brightness and screen off hot keys back to work.

Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

On Sat, Aug 27, 2016 at 10:51:51PM +0200, Peter Wu wrote:
> Hi Jani,
> 
> The method is somehow not reliable. At boot I was still able to capture
> brightness hotkeys (via acpi_listen). After starting SSDM and logging
> in, it still worked. Then I played a bit with PRIME output slaves, Xorg
> crashed at some points and hotkeys stopped working.
> 
> Inspection of CADL (via acpidbg) showed that it contained zeroes instead
> of 0x400. By poking more, suddenly the expected 0x400 value returned
> into CADL and hotkeys functioned again. At later moments it reverted to
> 0 again and hotkeys broke again.
> 
> Tracking down setters of active_crcts, I noticed that
> intel_modeset_readout_hw_state somehow does not detect eDP1 as active.
> Full dmesg log (9MiB) with drm.debug=0x1e (via sysfs) is available at
> 
> https://lekensteyn.nl/files/logs/journal-v4.8-rc3-183-g5e608a0-plus-2-cadl-patches.txt
> 
> Kind regards,
> Peter
> 
> On Thu, Aug 25, 2016 at 03:53:02PM +0300, Jani Nikula wrote:
> > This is the next iteration of [1] and [2]. Please review and/or test,
> > according to your abilities.
> > 
> > Thanks,
> > Jani.
> > 
> > Cc: Peter Wu <peter@lekensteyn.nl>
> > Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
> > Cc: Jan-Marek Glogowski <glogow@fbihome.de>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> > Cc: Paolo Stivanin <paolostivanin@fastmail.fm>
> > 
> > [1] http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com
> > [2] http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com
> > 
> > Jani Nikula (2):
> >   drm/i915: make i915 the source of acpi device ids for _DOD
> >   drm/i915/opregion: update cadl based on actually active outputs
> > 
> >  drivers/gpu/drm/i915/i915_drv.h       |   4 +
> >  drivers/gpu/drm/i915/intel_display.c  |   6 ++
> >  drivers/gpu/drm/i915/intel_drv.h      |   3 +
> >  drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++---------------------
> >  4 files changed, 74 insertions(+), 96 deletions(-)
> > 
> > -- 
> > 2.1.4
> > 
> 
> -- 
> Kind regards,
> Peter Wu
> https://lekensteyn.nl
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Paolo Stivanin]

Hello,
nope, also after suspend nothing changed.
I also tried using evtest before and after the patch and I got the same
result: nothing shows up when I press FN+F8/F9 (brightness)

-- 
  Paolo Stivanin
  paolostivanin@fastmail.fm
  Public Key ID: E71B7545

On Mon, Aug 29, 2016, at 08:42 AM, Maarten Lankhorst wrote:
> Op 25-08-16 om 20:56 schreef Paolo Stivanin:
> > Hello,
> > I applied these patches[1][2] to the latest kernel revision (
> > 4.8.0-rc3-g61c0457) but the brightness keys are not working on my
> > laptop.
> > With the older patches from the 29th of June the brightness keys were
> > working correctly.
> >
> > Cheers,
> >
> > [1] https://patchwork.freedesktop.org/patch/107280/
> > [2] https://patchwork.freedesktop.org/patch/107281/
> >
> Does it work after suspend?
> 
> ~Maarten
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[tasev.stefanoska]

Le 30/08/16 à 21:28, Paolo Stivanin a écrit :
> Hello,
> nope, also after suspend nothing changed.
> I also tried using evtest before and after the patch and I got the same
> result: nothing shows up when I press FN+F8/F9 (brightness)
>
Hello,

Tested on an asus ux305FA, work only after fresh boot, not working after 
suspend/resume.


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Rainer Koenig]

Hi Jani,

one quick questions: What happened to those CADL patches. I was
expecting them to showup in the mainstream kernel.org kernel some day,
but even in 4.9rc3 I cant't find them.

Best regards
Rainer

Am 25.08.2016 um 14:53 schrieb Jani Nikula:
> This is the next iteration of [1] and [2]. Please review and/or test,
> according to your abilities.
> 
> Thanks,
> Jani.
> 
> Cc: Peter Wu <peter@lekensteyn.nl>
> Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
> Cc: Jan-Marek Glogowski <glogow@fbihome.de>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> Cc: Paolo Stivanin <paolostivanin@fastmail.fm>
> 
> [1] http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com
> [2] http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com
> 
> Jani Nikula (2):
>   drm/i915: make i915 the source of acpi device ids for _DOD
>   drm/i915/opregion: update cadl based on actually active outputs
> 
>  drivers/gpu/drm/i915/i915_drv.h       |   4 +
>  drivers/gpu/drm/i915/intel_display.c  |   6 ++
>  drivers/gpu/drm/i915/intel_drv.h      |   3 +
>  drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++---------------------
>  4 files changed, 74 insertions(+), 96 deletions(-)
> 


-- 
Dipl.-Inf. (FH) Rainer Koenig
Project Manager Linux Clients
FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C

Fujitsu Technology Solutions
Bürgermeister-Ullrich-Str. 100
86199 Augsburg
Germany

Telephone: +49-821-804-3321
Telefax:   +49-821-804-2131
Mail:      mailto:Rainer.Koenig@ts.fujitsu.com

Internet         ts.fujtsu.com
Company Details  ts.fujitsu.com/imprint.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Jani Nikula]

On Mon, 31 Oct 2016, Rainer Koenig <Rainer.Koenig@ts.fujitsu.com> wrote:
> Hi Jani,
>
> one quick questions: What happened to those CADL patches. I was
> expecting them to showup in the mainstream kernel.org kernel some day,
> but even in 4.9rc3 I cant't find them.

Basically [1] and [2] happened, no idea what went wrong, and no time to
debug.

BR,
Jani.

[1] http://mid.mail-archive.com/1472151415.3037046.706208097.7301895A@webmail.messagingengine.com
[2] http://mid.mail-archive.com/34dfe08b-7646-8ea5-018e-549dc67564f2@skynet.be


>
> Best regards
> Rainer
>
> Am 25.08.2016 um 14:53 schrieb Jani Nikula:
>> This is the next iteration of [1] and [2]. Please review and/or test,
>> according to your abilities.
>> 
>> Thanks,
>> Jani.
>> 
>> Cc: Peter Wu <peter@lekensteyn.nl>
>> Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
>> Cc: Jan-Marek Glogowski <glogow@fbihome.de>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
>> Cc: Paolo Stivanin <paolostivanin@fastmail.fm>
>> 
>> [1] http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com
>> [2] http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com
>> 
>> Jani Nikula (2):
>>   drm/i915: make i915 the source of acpi device ids for _DOD
>>   drm/i915/opregion: update cadl based on actually active outputs
>> 
>>  drivers/gpu/drm/i915/i915_drv.h       |   4 +
>>  drivers/gpu/drm/i915/intel_display.c  |   6 ++
>>  drivers/gpu/drm/i915/intel_drv.h      |   3 +
>>  drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++---------------------
>>  4 files changed, 74 insertions(+), 96 deletions(-)
>> 

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Jani Nikula]

On Mon, 31 Oct 2016, Jani Nikula <jani.nikula@intel.com> wrote:
> On Mon, 31 Oct 2016, Rainer Koenig <Rainer.Koenig@ts.fujitsu.com> wrote:
>> Hi Jani,
>>
>> one quick questions: What happened to those CADL patches. I was
>> expecting them to showup in the mainstream kernel.org kernel some day,
>> but even in 4.9rc3 I cant't find them.
>
> Basically [1] and [2] happened, no idea what went wrong, and no time to
> debug.

Those, and virtually no positive feedback.

>
> BR,
> Jani.
>
> [1] http://mid.mail-archive.com/1472151415.3037046.706208097.7301895A@webmail.messagingengine.com
> [2] http://mid.mail-archive.com/34dfe08b-7646-8ea5-018e-549dc67564f2@skynet.be
>
>
>>
>> Best regards
>> Rainer
>>
>> Am 25.08.2016 um 14:53 schrieb Jani Nikula:
>>> This is the next iteration of [1] and [2]. Please review and/or test,
>>> according to your abilities.
>>> 
>>> Thanks,
>>> Jani.
>>> 
>>> Cc: Peter Wu <peter@lekensteyn.nl>
>>> Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
>>> Cc: Jan-Marek Glogowski <glogow@fbihome.de>
>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
>>> Cc: Paolo Stivanin <paolostivanin@fastmail.fm>
>>> 
>>> [1] http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com
>>> [2] http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com
>>> 
>>> Jani Nikula (2):
>>>   drm/i915: make i915 the source of acpi device ids for _DOD
>>>   drm/i915/opregion: update cadl based on actually active outputs
>>> 
>>>  drivers/gpu/drm/i915/i915_drv.h       |   4 +
>>>  drivers/gpu/drm/i915/intel_display.c  |   6 ++
>>>  drivers/gpu/drm/i915/intel_drv.h      |   3 +
>>>  drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++---------------------
>>>  4 files changed, 74 insertions(+), 96 deletions(-)
>>> 

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Marcos Souza]

[-- Attachment #1.1: Type: text/plain, Size: 2213 bytes --]

Your patches fixed the problem in my Asus X450LCP. I'm also looking further
to see these patches to land in master.

Thanks,

On Mon, Oct 31, 2016 at 10:32 AM Jani Nikula <jani.nikula@intel.com> wrote:

> On Mon, 31 Oct 2016, Jani Nikula <jani.nikula@intel.com> wrote:
> > On Mon, 31 Oct 2016, Rainer Koenig <Rainer.Koenig@ts.fujitsu.com> wrote:
> >> Hi Jani,
> >>
> >> one quick questions: What happened to those CADL patches. I was
> >> expecting them to showup in the mainstream kernel.org kernel some day,
> >> but even in 4.9rc3 I cant't find them.
> >
> > Basically [1] and [2] happened, no idea what went wrong, and no time to
> > debug.
>
> Those, and virtually no positive feedback.
>
> >
> > BR,
> > Jani.
> >
> > [1]
> http://mid.mail-archive.com/1472151415.3037046.706208097.7301895A@webmail.messagingengine.com
> > [2]
> http://mid.mail-archive.com/34dfe08b-7646-8ea5-018e-549dc67564f2@skynet.be
> >
> >
> >>
> >> Best regards
> >> Rainer
> >>
> >> Am 25.08.2016 um 14:53 schrieb Jani Nikula:
> >>> This is the next iteration of [1] and [2]. Please review and/or test,
> >>> according to your abilities.
> >>>
> >>> Thanks,
> >>> Jani.
> >>>
> >>> Cc: Peter Wu <peter@lekensteyn.nl>
> >>> Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
> >>> Cc: Jan-Marek Glogowski <glogow@fbihome.de>
> >>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> >>> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> >>> Cc: Paolo Stivanin <paolostivanin@fastmail.fm>
> >>>
> >>> [1]
> http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com
> >>> [2]
> http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com
> >>>
> >>> Jani Nikula (2):
> >>>   drm/i915: make i915 the source of acpi device ids for _DOD
> >>>   drm/i915/opregion: update cadl based on actually active outputs
> >>>
> >>>  drivers/gpu/drm/i915/i915_drv.h       |   4 +
> >>>  drivers/gpu/drm/i915/intel_display.c  |   6 ++
> >>>  drivers/gpu/drm/i915/intel_drv.h      |   3 +
> >>>  drivers/gpu/drm/i915/intel_opregion.c | 157
> +++++++++++++---------------------
> >>>  4 files changed, 74 insertions(+), 96 deletions(-)
> >>>
>
> --
> Jani Nikula, Intel Open Source Technology Center
>

[-- Attachment #1.2: Type: text/html, Size: 5350 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Rainer Koenig]

Hi Jani,

this is sad and also bad news. Means that actually we don't have any
driver which makes the brightness keys on the Fujitsu LIFEBOOK E7x6
series work.

On the other hand I saw that recent patches to intel_opregion.c
introduced quirks based on the DMI strings for some machines. I consider
this as a very bad idea, but if we do those crazy things, then is there
a possibility to create similar quirks for the models we know that are
working with your patch? ;-)

Best regards
Rainer

Am 25.08.2016 um 14:53 schrieb Jani Nikula:
> This is the next iteration of [1] and [2]. Please review and/or test,
> according to your abilities.
> 
> Thanks,
> Jani.
> 
> Cc: Peter Wu <peter@lekensteyn.nl>
> Cc: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
> Cc: Jan-Marek Glogowski <glogow@fbihome.de>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> Cc: Paolo Stivanin <paolostivanin@fastmail.fm>
> 
> [1] http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com
> [2] http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com
> 
> Jani Nikula (2):
>   drm/i915: make i915 the source of acpi device ids for _DOD
>   drm/i915/opregion: update cadl based on actually active outputs
> 
>  drivers/gpu/drm/i915/i915_drv.h       |   4 +
>  drivers/gpu/drm/i915/intel_display.c  |   6 ++
>  drivers/gpu/drm/i915/intel_drv.h      |   3 +
>  drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++---------------------
>  4 files changed, 74 insertions(+), 96 deletions(-)
> 


-- 
Dipl.-Inf. (FH) Rainer Koenig
Project Manager Linux Clients
FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C

Fujitsu Technology Solutions
Bürgermeister-Ullrich-Str. 100
86199 Augsburg
Germany

Telephone: +49-821-804-3321
Telefax:   +49-821-804-2131
Mail:      mailto:Rainer.Koenig@ts.fujitsu.com

Internet         ts.fujtsu.com
Company Details  ts.fujitsu.com/imprint.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Jani Nikula]

On Mon, 07 Nov 2016, Rainer Koenig <Rainer.Koenig@ts.fujitsu.com> wrote:
> this is sad and also bad news. Means that actually we don't have any
> driver which makes the brightness keys on the Fujitsu LIFEBOOK E7x6
> series work.

I hope we can make this work [1].

BR,
Jani.

[1] https://patchwork.freedesktop.org/series/15403/

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Paolo Stivanin]

Hello all,
@Jani Nikula: I just tried the patches you linked and they work
*perfectly* on my notebook (Clevo P640RE). I also tried to suspend and
resume the laptop and it works like a charm!
I applied the patches against the Linux kernel v4.8.8 taken from
upstream.

Thanks again :)

Cheers,

Paolo
-- 
  Paolo Stivanin
  paolostivanin@fastmail.fm
  Public Key ID: E71B7545

On Wed, Nov 16, 2016, at 03:32 PM, Jani Nikula wrote:
> On Mon, 07 Nov 2016, Rainer Koenig <Rainer.Koenig@ts.fujitsu.com> wrote:
> > this is sad and also bad news. Means that actually we don't have any
> > driver which makes the brightness keys on the Fujitsu LIFEBOOK E7x6
> > series work.
> 
> I hope we can make this work [1].
> 
> BR,
> Jani.
> 
> [1] https://patchwork.freedesktop.org/series/15403/
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

[Marcos Paulo de Souza]

Hi,

On Wed, Nov 16, 2016 at 09:14:28PM +0100, Paolo Stivanin wrote:
> Hello all,
> @Jani Nikula: I just tried the patches you linked and they work
> *perfectly* on my notebook (Clevo P640RE). I also tried to suspend and
> resume the laptop and it works like a charm!
> I applied the patches against the Linux kernel v4.8.8 taken from
> upstream.

I also tested here, and it fix the problem for me (the last patchset
already fixed it, but it's importante to notice it still works). I hope
to see this version merged.

Thanks a lot Jani.

Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

> 
> Thanks again :)
> 
> Cheers,
> 
> Paolo
> -- 
>   Paolo Stivanin
>   paolostivanin@fastmail.fm
>   Public Key ID: E71B7545
> 
> On Wed, Nov 16, 2016, at 03:32 PM, Jani Nikula wrote:
> > On Mon, 07 Nov 2016, Rainer Koenig <Rainer.Koenig@ts.fujitsu.com> wrote:
> > > this is sad and also bad news. Means that actually we don't have any
> > > driver which makes the brightness keys on the Fujitsu LIFEBOOK E7x6
> > > series work.
> > 
> > I hope we can make this work [1].
> > 
> > BR,
> > Jani.
> > 
> > [1] https://patchwork.freedesktop.org/series/15403/
> > 
> > -- 
> > Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx