Re: [PATCH 00/23] drm/i915: Organize most GPU features by platform

From: Jani Nikula <jani.nikula@linux.intel.com>
To: Carlos Santa <carlos.santa@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 00/23] drm/i915: Organize most GPU features by	platform
Date: Mon, 01 Aug 2016 16:08:10 +0300	[thread overview]
Message-ID: <87twf4tz5x.fsf@intel.com> (raw)
In-Reply-To: <1469036435-18918-1-git-send-email-carlos.santa@intel.com>

On Wed, 20 Jul 2016, Carlos Santa <carlos.santa@intel.com> wrote:
> This patchset includes the following changes:
>
>  - organize most GPU features so that they are easy to group by platforms.
>    It seems some of the ground work was already done for Gen7 features.
>    Reuse some of that work for the rest of the Gen platforms (GEN6, GEN5, GEN4, GEN3
>    and GEN2).
>
>  - make most of these GPU features now a device_info flag also based on
>    previous work done by others. The idea is here is to have a central place where
>    to add new features and also now it should be possible to see what the supported 
>    features are for a given platform by dumping of the struct definitions.
>    The list of the features that were converted to a device_info flag include: PSR,
>    RUNTIME_PM, CORE_RING_FREQ, CSR, GUC, GUC_UCODE, GUC_SCHED, RESOURCE_STREAMER, RC6,
>    RC6p, DP_MST, GMBUS_IRQ, FW_BLC, HW_CONTEXTS, LOGICAL_RING_CONTEXTS, L3_DPF, and
>    GMCH_DISPLAY.

Ack on the general approach. I didn't do actual review. Please check the
spelling in commit messages.

BR,
Jani.

>
> Carlos Santa (23):
>   drm/i915: Move HAS_PSR definition to platform struct definition
>   drm/i915: Introduce GEN6_FEATURES for device info
>   drm/i915: Move HAS_RUNTIME_PM definition to platform
>   drm/i915: Move HAS_CORE_RING_FREQ definition to platform definition
>   drm/i915: Move HAS_CSR definition to platform definition
>   drm/i915: Move HAS_GUC definition to platform definition
>   drm/i915: Move HAS_GUC_UCODE definition to platform definition
>   drm/i915: Move HAS_GUC_SCHED definition to platform definition
>   drm/i915: Move HAS_RESOURCE_STREAMER definition to platform definition
>   drm/i915: Move HAS_RC6 definition to platform definition
>   drm/i915: Move HAS_RC6p definition to platform definition
>   drm/i915: Move HAS_DP_MST definition to platform definition
>   drm/i915: Introduce GEN5_FEATURES for device info
>   drm/i915: Move HAS_AUX_IRQ definition to platform definition
>   drm/i915: Move HAS_GMBUS_IRQ definition to platform definition
>   drm/i915: Introduce GEN4_FEATURES for device info
>   drm/i915: Introduce GEN3_FEATURES for device info
>   drm/i915: Introduce GEN2 FEATURES for device info
>   drm/915: Move HAS_FW_BLC definition to platform
>   drm/i915: Move HAS_HW_CONTEXTS definition to platform
>   drm/i915: Move HAS_LOGICAL_RING_CONTEXTS definition to platform
>     definition
>   drm/i915: Move HAS_L3_DPF definition to platform definition
>   drm/i915: Move HAS_GMCH_DISPLAY definition to platform
>
>  drivers/gpu/drm/i915/i915_drv.h |  67 +++++-----
>  drivers/gpu/drm/i915/i915_pci.c | 272 +++++++++++++++++++++++++---------------
>  2 files changed, 206 insertions(+), 133 deletions(-)

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx