From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2] drm/i915/gen9: Fix DMC firmware initialization Date: Mon, 07 Mar 2016 13:58:55 +0200 Message-ID: <87twkisdmo.fsf@gaia.fi.intel.com> References: <1457111962-11687-1-git-send-email-imre.deak@intel.com> <1457121461-16729-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 80D656E349 for ; Mon, 7 Mar 2016 12:01:14 +0000 (UTC) In-Reply-To: <1457121461-16729-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cml0ZXM6Cgo+IFsgdGV4dC9wbGFpbiBd Cj4gSW4gY29tbWl0IDFlNjU3YWQ3IHdlIG1vdmVkIHRoZSBsYXN0IHN0ZXAgb2YgZmlybXdhcmUg aW5pdGlhbGl6YXRpb24gdG8KPiBza2xfZGlzcGxheV9jb3JlX2luaXQoKSwgd2hlcmUgaXQgd2ls bCBiZSBydW4gb25seSBkdXJpbmcgc3lzdGVtIHJlc3VtZSwKPiBidXQgbm90IGR1cmluZyBkcml2 ZXIgbG9hZGluZy4gU2luY2UgdGhpcyBpbml0IHN0ZXAgbmVlZHMgdG8gYmUgZG9uZQo+IHdoZW5l dmVyIHdlIHByb2dyYW0gdGhlIGZpcm13YXJlIGZpeCB0aGlzIGJ5IG1vdmluZyB0aGUgaW5pdGlh bGl6YXRpb24KPiB0byB0aGUgZW5kIG9mIGludGVsX2Nzcl9sb2FkX3Byb2dyYW0oKS4KPgo+IFdo aWxlIGF0IGl0IHNpbXBsaWZ5IGEgYml0IGNzcl9sb2FkX3dvcmtfZm4oKS4KPgo+IFRoaXMgaXNz dWUgcHJldmVudGVkIERDNS82IHRyYW5zaXRpb25zLCB0aGlzIGNoYW5nZSB3aWxsIHJlLWVuYWJs ZSB0aG9zZS4KPgo+IHYyOgo+IC0gcmVtb3ZlIGRlYnVnZ2luZyBsZWZ0LW92ZXIgYW5kIHJlZHVu ZGFudCBjb21tZW50IGluIGNzcl9sb2FkX3dvcmtfZm4oKQo+Cj4gRml4ZXM6IDFlNjU3YWQ3YTQ4 ZiAoImRybS9pOTE1L2dlbjk6IFdyaXRlIGRjIHN0YXRlIGRlYnVnbWFzayBiaXRzIG9ubHkgb25j ZSIpCj4gQ0M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAaW50ZWwuY29tPgo+IENDOiBQ YXRyaWsgSmFrb2Jzc29uIDxwYXRyaWsuamFrb2Jzc29uQGxpbnV4LmludGVsLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nzci5jICAgICAgICB8IDQwICsrKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAg ICAgfCAgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgfCAy MiArKy0tLS0tLS0tLS0tLS0tLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCsp LCAzNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9jc3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nzci5jCj4gaW5kZXggOTAy MDU0ZS4uZDQxN2Q5YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9j c3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nzci5jCj4gQEAgLTIxMiw2 ICsyMTIsMjQgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBzdGVwcGluZ19pbmZvICppbnRlbF9nZXRf c3RlcHBpbmdfaW5mbyhzdHJ1Y3QgZHJtX2RldmljZSAqZGUKPiAgCXJldHVybiBOVUxMOwo+ICB9 Cj4gIAo+ICtzdGF0aWMgdm9pZCBnZW45X3NldF9kY19zdGF0ZV9kZWJ1Z21hc2soc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwl1aW50MzJfdCB2YWwsIG1hc2s7Cj4g Kwo+ICsJbWFzayA9IERDX1NUQVRFX0RFQlVHX01BU0tfTUVNT1JZX1VQOwo+ICsKPiArCWlmIChJ U19CUk9YVE9OKGRldl9wcml2KSkKPiArCQltYXNrIHw9IERDX1NUQVRFX0RFQlVHX01BU0tfQ09S RVM7Cj4gKwo+ICsJLyogVGhlIGJlbG93IGJpdCBkb2Vzbid0IG5lZWQgdG8gYmUgY2xlYXJlZCBl dmVyIGFmdGVyd2FyZHMgKi8KPiArCXZhbCA9IEk5MTVfUkVBRChEQ19TVEFURV9ERUJVRyk7Cj4g KwlpZiAoKHZhbCAmIG1hc2spICE9IG1hc2spIHsKPiArCQl2YWwgfD0gbWFzazsKPiArCQlJOTE1 X1dSSVRFKERDX1NUQVRFX0RFQlVHLCB2YWwpOwo+ICsJCVBPU1RJTkdfUkVBRChEQ19TVEFURV9E RUJVRyk7Cj4gKwl9Cj4gK30KPiArCj4gIC8qKgo+ICAgKiBpbnRlbF9jc3JfbG9hZF9wcm9ncmFt KCkgLSB3cml0ZSB0aGUgZmlybXdhcmUgZnJvbSBtZW1vcnkgdG8gcmVnaXN0ZXIuCj4gICAqIEBk ZXZfcHJpdjogaTkxNSBkcm0gZGV2aWNlLgo+IEBAIC0yMjAsMTkgKzIzOCwxOSBAQCBzdGF0aWMg Y29uc3Qgc3RydWN0IHN0ZXBwaW5nX2luZm8gKmludGVsX2dldF9zdGVwcGluZ19pbmZvKHN0cnVj dCBkcm1fZGV2aWNlICpkZQo+ICAgKiBFdmVyeXRpbWUgZGlzcGxheSBjb21lcyBiYWNrIGZyb20g bG93IHBvd2VyIHN0YXRlIHRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIHRvCj4gICAqIGNvcHkgdGhl IGZpcm13YXJlIGZyb20gaW50ZXJuYWwgbWVtb3J5IHRvIHJlZ2lzdGVycy4KPiAgICovCj4gLWJv b2wgaW50ZWxfY3NyX2xvYWRfcHJvZ3JhbShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gK3ZvaWQgaW50ZWxfY3NyX2xvYWRfcHJvZ3JhbShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4gIHsKPiAgCXUzMiAqcGF5bG9hZCA9IGRldl9wcml2LT5jc3IuZG1jX3Bh eWxvYWQ7Cj4gIAl1aW50MzJfdCBpLCBmd19zaXplOwo+ICAKPiAgCWlmICghSVNfR0VOOShkZXZf cHJpdikpIHsKPiAgCQlEUk1fRVJST1IoIk5vIENTUiBzdXBwb3J0IGF2YWlsYWJsZSBmb3IgdGhp cyBwbGF0Zm9ybVxuIik7Cj4gLQkJcmV0dXJuIGZhbHNlOwo+ICsJCXJldHVybjsKPiAgCX0KPiAg Cj4gIAlpZiAoIWRldl9wcml2LT5jc3IuZG1jX3BheWxvYWQpIHsKPiAgCQlEUk1fRVJST1IoIlRy aWVkIHRvIHByb2dyYW0gQ1NSIHdpdGggZW1wdHkgcGF5bG9hZFxuIik7Cj4gLQkJcmV0dXJuIGZh bHNlOwo+ICsJCXJldHVybjsKPiAgCX0KPiAgCj4gIAlmd19zaXplID0gZGV2X3ByaXYtPmNzci5k bWNfZndfc2l6ZTsKPiBAQCAtMjQ2LDcgKzI2NCw3IEBAIGJvb2wgaW50ZWxfY3NyX2xvYWRfcHJv Z3JhbShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAo+ICAJZGV2X3ByaXYt PmNzci5kY19zdGF0ZSA9IDA7Cj4gIAo+IC0JcmV0dXJuIHRydWU7Cj4gKwlnZW45X3NldF9kY19z dGF0ZV9kZWJ1Z21hc2soZGV2X3ByaXYpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdWludDMyX3QgKnBh cnNlX2Nzcl9mdyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gQEAgLTM4OCwx OCArNDA2LDEyIEBAIHN0YXRpYyB2b2lkIGNzcl9sb2FkX3dvcmtfZm4oc3RydWN0IHdvcmtfc3Ry dWN0ICp3b3JrKQo+ICAKPiAgCXJldCA9IHJlcXVlc3RfZmlybXdhcmUoJmZ3LCBkZXZfcHJpdi0+ Y3NyLmZ3X3BhdGgsCj4gIAkJCSAgICAgICAmZGV2X3ByaXYtPmRldi0+cGRldi0+ZGV2KTsKPiAt CWlmICghZncpCj4gLQkJZ290byBvdXQ7Cj4gKwlpZiAoZncpCj4gKwkJZGV2X3ByaXYtPmNzci5k bWNfcGF5bG9hZCA9IHBhcnNlX2Nzcl9mdyhkZXZfcHJpdiwgZncpOwo+ICAKCldoeSB3ZSBjaGVj ayB0aGUgZncgcG9pbnRlciBoZXJlIGFuZCBub3QgdGhlIHJldHVybiB2YWx1ZT8KCi1NaWthCgoK PiAtCWRldl9wcml2LT5jc3IuZG1jX3BheWxvYWQgPSBwYXJzZV9jc3JfZncoZGV2X3ByaXYsIGZ3 KTsKPiAtCWlmICghZGV2X3ByaXYtPmNzci5kbWNfcGF5bG9hZCkKPiAtCQlnb3RvIG91dDsKPiAt Cj4gLQkvKiBsb2FkIGNzciBwcm9ncmFtIGR1cmluZyBzeXN0ZW0gYm9vdCwgYXMgbmVlZGVkIGZv ciBEQyBzdGF0ZXMgKi8KPiAtCWludGVsX2Nzcl9sb2FkX3Byb2dyYW0oZGV2X3ByaXYpOwo+IC0K PiAtb3V0Ogo+ICAJaWYgKGRldl9wcml2LT5jc3IuZG1jX3BheWxvYWQpIHsKPiArCQlpbnRlbF9j c3JfbG9hZF9wcm9ncmFtKGRldl9wcml2KTsKPiArCj4gIAkJaW50ZWxfZGlzcGxheV9wb3dlcl9w dXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJTl9JTklUKTsKPiAgCj4gIAkJRFJNX0lORk8oIkZpbmlz aGVkIGxvYWRpbmcgJXMgKHYldS4ldSlcbiIsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBp bmRleCBjZDBiNGVhLi4zZGFmMWUzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBA QCAtMTI3OSw3ICsxMjc5LDcgQEAgdTMyIHNrbF9wbGFuZV9jdGxfcm90YXRpb24odW5zaWduZWQg aW50IHJvdGF0aW9uKTsKPiAgCj4gIC8qIGludGVsX2Nzci5jICovCj4gIHZvaWQgaW50ZWxfY3Ny X3Vjb2RlX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKik7Cj4gLWJvb2wgaW50ZWxfY3Ny X2xvYWRfcHJvZ3JhbShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqKTsKPiArdm9pZCBpbnRlbF9j c3JfbG9hZF9wcm9ncmFtKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICopOwo+ICB2b2lkIGludGVs X2Nzcl91Y29kZV9maW5pKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICopOwo+ICAKPiAgLyogaW50 ZWxfZHAuYyAqLwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50 aW1lX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBpbmRl eCAwOWM1MmIxLi41YWRmNGIzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3J1bnRpbWVfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRp bWVfcG0uYwo+IEBAIC00NzAsMjQgKzQ3MCw2IEBAIHN0YXRpYyB2b2lkIGFzc2VydF9jYW5fZGlz YWJsZV9kYzkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJICAqLwo+ICB9 Cj4gIAo+IC1zdGF0aWMgdm9pZCBnZW45X3NldF9kY19zdGF0ZV9kZWJ1Z21hc2soc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+IC17Cj4gLQl1aW50MzJfdCB2YWwsIG1hc2s7Cj4g LQo+IC0JbWFzayA9IERDX1NUQVRFX0RFQlVHX01BU0tfTUVNT1JZX1VQOwo+IC0KPiAtCWlmIChJ U19CUk9YVE9OKGRldl9wcml2KSkKPiAtCQltYXNrIHw9IERDX1NUQVRFX0RFQlVHX01BU0tfQ09S RVM7Cj4gLQo+IC0JLyogVGhlIGJlbG93IGJpdCBkb2Vzbid0IG5lZWQgdG8gYmUgY2xlYXJlZCBl dmVyIGFmdGVyd2FyZHMgKi8KPiAtCXZhbCA9IEk5MTVfUkVBRChEQ19TVEFURV9ERUJVRyk7Cj4g LQlpZiAoKHZhbCAmIG1hc2spICE9IG1hc2spIHsKPiAtCQl2YWwgfD0gbWFzazsKPiAtCQlJOTE1 X1dSSVRFKERDX1NUQVRFX0RFQlVHLCB2YWwpOwo+IC0JCVBPU1RJTkdfUkVBRChEQ19TVEFURV9E RUJVRyk7Cj4gLQl9Cj4gLX0KPiAtCj4gIHN0YXRpYyB2b2lkIGdlbjlfd3JpdGVfZGNfc3RhdGUo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkJdTMyIHN0YXRlKQo+ICB7 Cj4gQEAgLTIxNDEsOCArMjEyMyw4IEBAIHN0YXRpYyB2b2lkIHNrbF9kaXNwbGF5X2NvcmVfaW5p dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICAJc2tsX2luaXRfY2Rj bGsoZGV2X3ByaXYpOwo+ICAKPiAtCWlmIChkZXZfcHJpdi0+Y3NyLmRtY19wYXlsb2FkICYmIGlu dGVsX2Nzcl9sb2FkX3Byb2dyYW0oZGV2X3ByaXYpKQo+IC0JCWdlbjlfc2V0X2RjX3N0YXRlX2Rl YnVnbWFzayhkZXZfcHJpdik7Cj4gKwlpZiAoZGV2X3ByaXYtPmNzci5kbWNfcGF5bG9hZCkKPiAr CQlpbnRlbF9jc3JfbG9hZF9wcm9ncmFtKGRldl9wcml2KTsKPiAgfQo+ICAKPiAgc3RhdGljIHZv aWQgc2tsX2Rpc3BsYXlfY29yZV91bmluaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+IC0tIAo+IDIuNS4wCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==