From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2 v2 addendum v2] drm/i915: Allow parsing of variable size child device entries from VBT Date: Fri, 14 Aug 2015 12:40:27 +0300 Message-ID: <87tws2qkc4.fsf@intel.com> References: <1436526655-2965-1-git-send-email-antti.koskipaa@linux.intel.com> <1436526655-2965-2-git-send-email-antti.koskipaa@linux.intel.com> <20150804135552.GC6150@boom> <20150805085900.GM17734@phenom.ffwll.local> <55C3682E.6080103@intel.com> <20150806140855.GE6150@boom> <20150806153102.GW17734@phenom.ffwll.local> <20150812102917.GL6150@boom> <8737zotwqw.fsf@intel.com> <20150813131415.GO6150@boom> <87wpwyqn1d.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C2676EF11 for ; Fri, 14 Aug 2015 02:37:30 -0700 (PDT) In-Reply-To: <87wpwyqn1d.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: David Weinehall Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAxNCBBdWcgMjAxNSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVs LmNvbT4gd3JvdGU6Cj4gT24gVGh1LCAxMyBBdWcgMjAxNSwgRGF2aWQgV2VpbmVoYWxsIDxkYXZp ZC53ZWluZWhhbGxAbGludXguaW50ZWwuY29tPiB3cm90ZToKPj4gT24gV2VkLCBBdWcgMTIsIDIw MTUgYXQgMDU6MTk6MzVQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+PiBPbiBXZWQsIDEy IEF1ZyAyMDE1LCBEYXZpZCBXZWluZWhhbGwgPGRhdmlkLndlaW5laGFsbEBsaW51eC5pbnRlbC5j b20+IHdyb3RlOgo+Pj4gPiBTb21lIG1vcmUgZml4dXAgaXMgbmVlZGVkOyB0aGUgYml0cyBmcm9t IEFudHRpJ3MgcGF0Y2gKPj4+ID4gdGhhdCBhY3R1YWxseSBleHBhbmRlZCB0aGUgc3RydWN0IHRv IGZ1bGx5IGZpdCB0aGUgbmV3ZXIKPj4+ID4gdmVyc2lvbnMgb2YgdGhlIGNoaWxkX2RldmljZV9j b25maWcgd2FzIHBhcnQgb2YgdGhlIHNlY29uZAo+Pj4gPiBwYXRjaDsgc2luY2UgdGhhdCBwYXRj aCBoYXNuJ3QgYmVlbiBtZXJnZWQgeWV0IHdlIG5lZWQgdGhpcyBiaXQ6Cj4+PiA+Cj4+PiA+IFRo aXMgYXBwbGllcyBvbiB0b3Agb2YgdGhlIHBhdGNoIHlvdSBhbHJlYWR5IG1lcmdlZAo+Pj4gPiAo dGhlIElib29zdCBwYXRjaCB3aWxsIG5lZWQgY29ycmVzcG9uZGluZyBhZGp1c3RtZW50IHRvCj4+ PiA+ICByZW1vdmUgdGhlIGNoYW5nZXMgSSBzcGxpdCBvdXQpOgo+Pj4gPgo+Pj4gPiBFeHBhbmQg Y29tbW9uX2NoaWxkX2Rldl9jb25maWcgdG8gYmUgYWJsZSB0byBmaXQgYWxsIGluZm9ybWF0aW9u Cj4+PiA+IGRlZmluZWQgYnkgdGhlIGxhdGVzdCBWQlQgc3BlY2lmaWNhdGlvbi4KPj4+ID4KPj4+ ID4gU2lnbmVkLW9mZi1ieTogRGF2aWQgV2VpbmVoYWxsIDxkYXZpZC53ZWluZWhhbGxAbGludXgu aW50ZWwuY29tPgo+Pj4gPiBDQzogQW50dGkgS29za2lwYWEgPGFudHRpLmtvc2tpcGFhQGxpbnV4 LmludGVsLmNvbT4KPj4+ID4gLS0tCj4+PiA+ICBpbnRlbF9iaW9zLmMgfCAgICA3ICsrKysrKy0K Pj4+ID4gIGludGVsX2Jpb3MuaCB8ICAgIDQgKysrKwo+Pj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAx MCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+PiA+Cj4+PiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9iaW9zLmMKPj4+ID4gaW5kZXggOTkwYWNjMjA3NzFhLi40MGUyY2M0ZTc0MTkgMTAwNjQ0 Cj4+PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+Pj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPj4+ID4gQEAgLTEwMzgsNiArMTAz OCwxMCBAQCBwYXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4+PiA+ICAJCURSTV9ERUJVR19LTVMoIk5vIGdlbmVyYWwgZGVmaW5pdGlvbiBibG9j ayBpcyBmb3VuZCwgbm8gZGV2aWNlcyBkZWZpbmVkLlxuIik7Cj4+PiA+ICAJCXJldHVybjsKPj4+ ID4gIAl9Cj4+PiA+ICsJLyogUmVtZW1iZXIgdG8ga2VlcCB0aGlzIGluIHN5bmMgd2l0aCBjaGls ZF9kZXZpY2VfY29uZmlnOwo+Pj4gPiArCSAqIHdoZW5ldmVyIGEgbmV3IGZlYXR1cmUgaXMgYWRk ZWQgdG8gQkRCIHRoYXQgY2F1c2VzIHRoYXQKPj4+ID4gKwkgKiBzdHJ1Y3QgdG8gZ3JvdyB0aGlz IG5lZWRzIHRvIGJlIHVwZGF0ZWQgdG9vCj4+PiA+ICsJICovCj4+PiA+ICAJaWYgKGJkYi0+dmVy c2lvbiA8IDE5NSkgewo+Pj4gPiAgCQlleHBlY3RlZF9zaXplID0gMzM7Cj4+PiA+ICAJfSBlbHNl IGlmIChiZGItPnZlcnNpb24gPT0gMTk1KSB7Cj4+PiA+IEBAIC0xMDUxLDcgKzEwNTUsOCBAQCBw YXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ PiA+ICAJfQo+Pj4gPiAgCj4+PiA+ICAJaWYgKGV4cGVjdGVkX3NpemUgPiBzaXplb2YoKnBfY2hp bGQpKSB7Cj4+PiA+IC0JCURSTV9FUlJPUigiY2hpbGRfZGV2aWNlX2NvbmZpZyBjYW5ub3QgZml0 IGluIHBfY2hpbGRcbiIpOwo+Pj4gPiArCQlEUk1fRVJST1IoImNoaWxkX2RldmljZV9jb25maWcg KHNpemUgJXUpIGNhbm5vdCBmaXQgaW4gcF9jaGlsZCAoc2l6ZSAldSk7IGJkYi0+dmVyc2lvbjog JXVcbiIsCj4+PiA+ICsJCQkgIGV4cGVjdGVkX3NpemUsIHNpemVvZigqcF9jaGlsZCksIGJkYi0+ dmVyc2lvbik7Cj4+PiAKPj4+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYzogSW4g ZnVuY3Rpb24g4oCYcGFyc2VfZGV2aWNlX21hcHBpbmfigJk6Cj4+PiBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9iaW9zLmM6MTA1ODozOiB3YXJuaW5nOiBmb3JtYXQg4oCYJXXigJkgZXhwZWN0 cyBhcmd1bWVudCBvZiB0eXBlIOKAmHVuc2lnbmVkIGludOKAmSwgYnV0IGFyZ3VtZW50IDMgaGFz IHR5cGUg4oCYbG9uZyB1bnNpZ25lZCBpbnTigJkgWy1XZm9ybWF0PV0KPj4+ICAgIERSTV9FUlJP UigiY2hpbGRfZGV2aWNlX2NvbmZpZyAoc2l6ZSAldSkgY2Fubm90IGZpdCBpbiBwX2NoaWxkIChz aXplICV1KTsgYmRiLT52ZXJzaW9uOiAldVxuIiwKPj4+ICAgIF4KPj4+ICAgQ0MgW01dICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9maWZvX3VuZGVycnVuLm8KPj4KPj4gV2VsbCBzcG90dGVk LiAgT3IgcmF0aGVyLCBzdHVwaWQgb2YgbWUgdG8gZm9yZ2V0IHRoYXQgc2l6ZW9mIHlpZWxkcwo+ PiBzaXplX3QgYXMgdHlwZSwgdGh1cyBuZWNlc3NpdGF0aW5nICV6dSBhcyBjb252ZXJzaW9uIHNw ZWNpZmllci4KPj4KPj4gRml4ZWQgdmVyc2lvbjoKPj4KPj4gRXhwYW5kIGNvbW1vbl9jaGlsZF9k ZXZfY29uZmlnIHRvIGJlIGFibGUgdG8gZml0IGFsbCBpbmZvcm1hdGlvbgo+PiBkZWZpbmVkIGJ5 IHRoZSBsYXRlc3QgVkJUIHNwZWNpZmljYXRpb24uCj4+Cj4+IHYyOiBVc2UgcHJvcGVyIGNvbnZl cnNpb24gc3BlY2lmaWVyIGZvciBzaXplX3QgKCV6dSkKPj4KPj4gU2lnbmVkLW9mZi1ieTogRGF2 aWQgV2VpbmVoYWxsIDxkYXZpZC53ZWluZWhhbGxAbGludXguaW50ZWwuY29tPgo+PiBDQzogQW50 dGkgS29za2lwYWEgPGFudHRpLmtvc2tpcGFhQGxpbnV4LmludGVsLmNvbT4KPj4KPj4gIGludGVs X2Jpb3MuYyB8ICAgIDcgKysrKysrLQo+PiAgaW50ZWxfYmlvcy5oIHwgICAgNCArKysrCj4+ICAy IGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4KPj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+PiBpbmRleCA5OTBhY2MyMDc3MWEuLjU2NzNlZDUzNzk3 YiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jCj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+PiBAQCAtMTAzOCw2ICsxMDM4 LDEwIEBAIHBhcnNlX2RldmljZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwKPj4gIAkJRFJNX0RFQlVHX0tNUygiTm8gZ2VuZXJhbCBkZWZpbml0aW9uIGJsb2NrIGlz IGZvdW5kLCBubyBkZXZpY2VzIGRlZmluZWQuXG4iKTsKPj4gIAkJcmV0dXJuOwo+PiAgCX0KPj4g KwkvKiBSZW1lbWJlciB0byBrZWVwIHRoaXMgaW4gc3luYyB3aXRoIGNoaWxkX2RldmljZV9jb25m aWc7Cj4+ICsJICogd2hlbmV2ZXIgYSBuZXcgZmVhdHVyZSBpcyBhZGRlZCB0byBCREIgdGhhdCBj YXVzZXMgdGhhdAo+PiArCSAqIHN0cnVjdCB0byBncm93IHRoaXMgbmVlZHMgdG8gYmUgdXBkYXRl ZCB0b28KPj4gKwkgKi8KPj4gIAlpZiAoYmRiLT52ZXJzaW9uIDwgMTk1KSB7Cj4+ICAJCWV4cGVj dGVkX3NpemUgPSAzMzsKPj4gIAl9IGVsc2UgaWYgKGJkYi0+dmVyc2lvbiA9PSAxOTUpIHsKPj4g QEAgLTEwNTEsNyArMTA1NSw4IEBAIHBhcnNlX2RldmljZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPj4gIAl9Cj4+ICAKPj4gIAlpZiAoZXhwZWN0ZWRfc2l6ZSA+ IHNpemVvZigqcF9jaGlsZCkpIHsKPj4gLQkJRFJNX0VSUk9SKCJjaGlsZF9kZXZpY2VfY29uZmln IGNhbm5vdCBmaXQgaW4gcF9jaGlsZFxuIik7Cj4+ICsJCURSTV9FUlJPUigiY2hpbGRfZGV2aWNl X2NvbmZpZyAoc2l6ZSAldSkgY2Fubm90IGZpdCBpbiBwX2NoaWxkIChzaXplICV6dSk7IGJkYi0+ dmVyc2lvbjogJXVcbiIsCj4+ICsJCQkgIGV4cGVjdGVkX3NpemUsIHNpemVvZigqcF9jaGlsZCks IGJkYi0+dmVyc2lvbik7Cj4+ICAJCXJldHVybjsKPj4gIAl9Cj4+ICAKPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Jpb3MuaAo+PiBpbmRleCBmN2FkNmE1ODUxMjkuLjcxY2I5NmY3Nzg3MCAxMDA2NDQK Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5oCj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuaAo+PiBAQCAtMjM5LDYgKzIzOSwxMCBAQCBzdHJ1 Y3QgY29tbW9uX2NoaWxkX2Rldl9jb25maWcgewo+PiAgCXU4IG5vdF9jb21tb24yWzJdOwo+PiAg CXU4IGRkY19waW47Cj4+ICAJdTE2IGVkaWRfcHRyOwo+PiArCXU4IG9ic29sZXRlOwo+PiArCXU4 IGZsYWdzXzE7Cj4+ICsJdTggbm90X2NvbW1vbjNbMTNdOwo+PiArCXU4IGlib29zdF9sZXZlbDsK Pgo+IEhvdyBkb2VzIHRoaXMgaW1wYWN0IHRoZSBpZiAocF9kZWZzLT5jaGlsZF9kZXZfc2l6ZSAh PSBzaXplb2YoKnBfY2hpbGQpKQo+IGNoZWNrIGluIHBhcnNlX3Nkdm9fZGV2aWNlX21hcHBpbmco KT8KClVnaC4gV2hhdCBhIG1lc3MgdGhlIHdob2xlIGNoaWxkIGRldmljZSBwYXJzaW5nIGlzLgoK V2hhdCdzIHJlYWxseSBicm9rZW4gaW4gdGhlIGN1cnJlbnQgY29kZSBpcyAqYXNzdW1pbmcqIHNv bWUgZXhwZWN0ZWQKc2l6ZSBmb3IgZnV0dXJlIHZlcnNpb25zLCAqYW5kKiB0aGVuIHJlZnVzaW5n IHRvIHBhcnNlIGlmIHRoZSBjaGlsZCBkZXYKc2l6ZSBoYXMgZ3Jvd24uIFdlIHNob3VsZCBqdXN0 IHBhcnNlICp1cCB0byogbWluKFZCVCByZXBvcnRlZCBjaGlsZCBkZXYKc2l6ZSwgdGhlIGJpZ2dl c3QgY2hpbGQgZGV2IHdlIGtub3cgYWJvdXQpLiBUaGUgY3VycmVudCBjb2RlIGtlZXBzIHVzCmRv aW5nIGJ1c3l3b3JrIHdoZW5ldmVyIHNvbWVvbmUgZGVjaWRlcyB0byBhZGQgYSBmaWVsZCBhdCB0 aGUgZW5kLgoKU2lkZSBub3RlLCB3ZSBoYXZlICp0d28qIGZ1bmN0aW9ucyBhbmQgbG9vcHMgaXRl cmF0aW5nIGNoaWxkCmRldmljZXMuIE9uZSBmb3IgbmV3IHN0dWZmIGFuZCBhbm90aGVyIGZvciBv bGQgc3R1ZmYuIFlheS4KCkJSLApKYW5pLgoKCj4KPiBCUiwKPiBKYW5pLgo+Cj4+ICB9IF9fcGFj a2VkOwo+PiAgCj4+ICAvKiBUaGlzIGZpZWxkIGNoYW5nZXMgZGVwZW5kaW5nIG9uIHRoZSBCREIg dmVyc2lvbiwgc28gdGhlIG1vc3QgcmVsaWFibGUgd2F5IHRvCj4KPiAtLSAKPiBKYW5pIE5pa3Vs YSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKCi0tIApKYW5pIE5pa3VsYSwg SW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK