From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove misleading debug message
Date: Tue, 08 Apr 2014 15:06:24 +0300 [thread overview]
Message-ID: <87txa481q7.fsf@intel.com> (raw)
In-Reply-To: <1396955249-19944-1-git-send-email-damien.lespiau@intel.com>
On Tue, 08 Apr 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> haswell_write_eld() is also used on broadwell, so let's not explicitely
> mention Haswell. The rest of the function has plenty of debug output
> which will print the function name, so we know where we are anyway.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a646ed4..b01d245 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7372,9 +7372,6 @@ static void haswell_write_eld(struct drm_connector *connector,
> int aud_config = HSW_AUD_CFG(pipe);
> int aud_cntrl_st2 = HSW_AUD_PIN_ELD_CP_VLD;
>
> -
> - DRM_DEBUG_DRIVER("HDMI: Haswell Audio initialize....\n");
> -
> /* Audio output enable */
> DRM_DEBUG_DRIVER("HDMI audio: enable codec\n");
> tmp = I915_READ(aud_cntrl_st2);
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-04-08 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 11:07 [PATCH] drm/i915: Remove misleading debug message Damien Lespiau
2014-04-08 12:06 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txa481q7.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox