[PATCH] drm/i915: Remove misleading debug message

[PATCH] drm/i915: Remove misleading debug message

[Damien Lespiau]

haswell_write_eld() is also used on broadwell, so let's not explicitely
mention Haswell. The rest of the function has plenty of debug output
which will print the function name, so we know where we are anyway.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index a646ed4..b01d245 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7372,9 +7372,6 @@ static void haswell_write_eld(struct drm_connector *connector,
 	int aud_config = HSW_AUD_CFG(pipe);
 	int aud_cntrl_st2 = HSW_AUD_PIN_ELD_CP_VLD;
 
-
-	DRM_DEBUG_DRIVER("HDMI: Haswell Audio initialize....\n");
-
 	/* Audio output enable */
 	DRM_DEBUG_DRIVER("HDMI audio: enable codec\n");
 	tmp = I915_READ(aud_cntrl_st2);
-- 
1.8.3.1

Re: [PATCH] drm/i915: Remove misleading debug message

[Jani Nikula]

On Tue, 08 Apr 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> haswell_write_eld() is also used on broadwell, so let's not explicitely
> mention Haswell. The rest of the function has plenty of debug output
> which will print the function name, so we know where we are anyway.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/intel_display.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a646ed4..b01d245 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7372,9 +7372,6 @@ static void haswell_write_eld(struct drm_connector *connector,
>  	int aud_config = HSW_AUD_CFG(pipe);
>  	int aud_cntrl_st2 = HSW_AUD_PIN_ELD_CP_VLD;
>  
> -
> -	DRM_DEBUG_DRIVER("HDMI: Haswell Audio initialize....\n");
> -
>  	/* Audio output enable */
>  	DRM_DEBUG_DRIVER("HDMI audio: enable codec\n");
>  	tmp = I915_READ(aud_cntrl_st2);
> -- 
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center