Re: [PATCH 3/6] drm/i915: reset eDP timestamps on resume

Jesse Barnes
2013-12-19T17:35:37Z

On Thu, 19 Dec 2013 14:29:41 -0200
Paulo Zanoni <przanoni@gmail.com> wrote:

> + * Reset everything, otherwise when suspend/resume gets very fast, we
> + * delay the resume based on the values that were set when we were still
> + * suspending.
> + */
> + intel_dp->last_power_on = tmp_jiffies - intel_dp->backlight_on_delay;
> + intel_dp->last_power_cycle = tmp_jiffies -
> + intel_dp->panel_power_cycle_delay;
> + intel_dp->last_backlight_off = tmp_jiffies -
> + intel_dp->backlight_off_delay;

I'm not clear on this; aren't the _delay fields in ms? Here you're
subtracting ms units from jiffies units. Don't you have to convert?
Or did I miss a unit change in an earlier patch?

Thanks,
Jesse