From: Jani Nikula <jani.nikula@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Use symbolic names for booleans in i915_semaphore_is_enabled
Date: Tue, 17 Dec 2013 12:44:14 +0200 [thread overview]
Message-ID: <87txe74v0h.fsf@intel.com> (raw)
In-Reply-To: <1387270657-21104-1-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 17 Dec 2013, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Noticed while reviewing a patch and couldn't resist the OCD.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index aea909b2f22e..31ffe39d2b79 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -480,12 +480,12 @@ check_next:
> bool i915_semaphore_is_enabled(struct drm_device *dev)
> {
> if (INTEL_INFO(dev)->gen < 6)
> - return 0;
> + return false;
>
> /* Until we get further testing... */
> if (IS_GEN8(dev)) {
> WARN_ON(!i915_preliminary_hw_support);
> - return 0;
> + return false;
> }
>
> if (i915_semaphores >= 0)
> @@ -497,7 +497,7 @@ bool i915_semaphore_is_enabled(struct drm_device *dev)
> return false;
> #endif
>
> - return 1;
> + return true;
> }
>
> static int i915_drm_freeze(struct drm_device *dev)
> --
> 1.8.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2013-12-17 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 8:57 [PATCH] drm/i915: Use symbolic names for booleans in i915_semaphore_is_enabled Daniel Vetter
2013-12-17 10:44 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txe74v0h.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox