* [PATCH] drm/i915: Use symbolic names for booleans in i915_semaphore_is_enabled
@ 2013-12-17 8:57 Daniel Vetter
2013-12-17 10:44 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Vetter @ 2013-12-17 8:57 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
Noticed while reviewing a patch and couldn't resist the OCD.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/i915_drv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index aea909b2f22e..31ffe39d2b79 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -480,12 +480,12 @@ check_next:
bool i915_semaphore_is_enabled(struct drm_device *dev)
{
if (INTEL_INFO(dev)->gen < 6)
- return 0;
+ return false;
/* Until we get further testing... */
if (IS_GEN8(dev)) {
WARN_ON(!i915_preliminary_hw_support);
- return 0;
+ return false;
}
if (i915_semaphores >= 0)
@@ -497,7 +497,7 @@ bool i915_semaphore_is_enabled(struct drm_device *dev)
return false;
#endif
- return 1;
+ return true;
}
static int i915_drm_freeze(struct drm_device *dev)
--
1.8.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: Use symbolic names for booleans in i915_semaphore_is_enabled
2013-12-17 8:57 [PATCH] drm/i915: Use symbolic names for booleans in i915_semaphore_is_enabled Daniel Vetter
@ 2013-12-17 10:44 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2013-12-17 10:44 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
On Tue, 17 Dec 2013, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Noticed while reviewing a patch and couldn't resist the OCD.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index aea909b2f22e..31ffe39d2b79 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -480,12 +480,12 @@ check_next:
> bool i915_semaphore_is_enabled(struct drm_device *dev)
> {
> if (INTEL_INFO(dev)->gen < 6)
> - return 0;
> + return false;
>
> /* Until we get further testing... */
> if (IS_GEN8(dev)) {
> WARN_ON(!i915_preliminary_hw_support);
> - return 0;
> + return false;
> }
>
> if (i915_semaphores >= 0)
> @@ -497,7 +497,7 @@ bool i915_semaphore_is_enabled(struct drm_device *dev)
> return false;
> #endif
>
> - return 1;
> + return true;
> }
>
> static int i915_drm_freeze(struct drm_device *dev)
> --
> 1.8.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-17 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-17 8:57 [PATCH] drm/i915: Use symbolic names for booleans in i915_semaphore_is_enabled Daniel Vetter
2013-12-17 10:44 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox