From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Use symbolic names for booleans
	in i915_semaphore_is_enabled
Date: Tue, 17 Dec 2013 12:44:14 +0200
Message-ID: <87txe74v0h.fsf@intel.com>
References: <1387270657-21104-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id BDE66FBFB2
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Dec 2013 02:41:41 -0800 (PST)
In-Reply-To: <1387270657-21104-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 17 Dec 2013, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Noticed while reviewing a patch and couldn't resist the OCD.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index aea909b2f22e..31ffe39d2b79 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -480,12 +480,12 @@ check_next:
>  bool i915_semaphore_is_enabled(struct drm_device *dev)
>  {
>  	if (INTEL_INFO(dev)->gen < 6)
> -		return 0;
> +		return false;
>  
>  	/* Until we get further testing... */
>  	if (IS_GEN8(dev)) {
>  		WARN_ON(!i915_preliminary_hw_support);
> -		return 0;
> +		return false;
>  	}
>  
>  	if (i915_semaphores >= 0)
> @@ -497,7 +497,7 @@ bool i915_semaphore_is_enabled(struct drm_device *dev)
>  		return false;
>  #endif
>  
> -	return 1;
> +	return true;
>  }
>  
>  static int i915_drm_freeze(struct drm_device *dev)
> -- 
> 1.8.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center