From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC33EC5478C for ; Tue, 27 Feb 2024 14:12:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E9EF610E5CF; Tue, 27 Feb 2024 14:12:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="eCLpQgoR"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id AAC3B10E5F1 for ; Tue, 27 Feb 2024 14:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709043151; x=1740579151; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=XM8xFLCXnSPazakz6D2l6XA6UNExmJoHdJHAnsnwiuY=; b=eCLpQgoR7cxrT7d8dHVnKN5Xi86FsuC45bOeItuCeUBk9uF1G3cgxPBs oVJOmzHaQHHAia/AKm3mlgT81bw4mcJYikIxd8khvUZB7QTY5I57TIEY0 McdkSghWq2VPg73yZh8HKyieVu9FkvT0M/wTLCC3YbmN+BS5XfQKLhvX5 BCLQnkaSJc4Bi1bmziMG09iVY2iHxh+cCNQw1lD939XxZyCqaUegKV420 Rtei+T9f1qumQUE2p1Gba3X/896H5QEPQBNjHK3gziSGZbG+FRIaaJXJy xlGIN87tJw3rve8bOKaoF9CXwUzQXCXoSP73L2pUnkQF/U+B6D6Kih47p A==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="3545930" X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="3545930" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 06:12:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="11634434" Received: from stinti-mobl.ger.corp.intel.com (HELO localhost) ([10.252.50.15]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 06:12:28 -0800 From: Jani Nikula To: Bhanuprakash Modem , intel-gfx@lists.freedesktop.org Cc: Bhanuprakash Modem , Ankit Nautiyal , Mitul Golani Subject: Re: [PATCH 1/2] drm/i915/display/drrs: Refactor CPU transcoder DRRS check In-Reply-To: <20240227123833.2799647-1-bhanuprakash.modem@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240227123833.2799647-1-bhanuprakash.modem@intel.com> Date: Tue, 27 Feb 2024 16:12:24 +0200 Message-ID: <87v86admif.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" We don't need to keep adding /display/ in the subject prefix. Just drm/i915/drrs: is fine. On Tue, 27 Feb 2024, Bhanuprakash Modem wrote: > Rename cpu_transcoder_has_drrs() to intel_cpu_transcoder_has_drrs() > and make it as non-static, therefore it can be re-used. > > Cc: Jani Nikula > Cc: Ankit Nautiyal > Cc: Mitul Golani > Signed-off-by: Bhanuprakash Modem > --- > drivers/gpu/drm/i915/display/intel_display.c | 9 +++++++++ > drivers/gpu/drm/i915/display/intel_display.h | 2 ++ > drivers/gpu/drm/i915/display/intel_dp.c | 11 +---------- > 3 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 00ac65a14029..2210d3bb2e0a 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -2582,6 +2582,15 @@ void intel_cpu_transcoder_set_m2_n2(struct intel_crtc *crtc, > PIPE_LINK_M2(transcoder), PIPE_LINK_N2(transcoder)); > } > > +bool intel_cpu_transcoder_has_drrs(struct drm_i915_private *i915, > + enum transcoder cpu_transcoder) > +{ > + if (HAS_DOUBLE_BUFFERED_M_N(i915)) > + return true; > + > + return intel_cpu_transcoder_has_m2_n2(i915, cpu_transcoder); > +} It really needs to be moved to intel_drrs.[ch], not here. intel_display.c must cease to be a dumping ground for random stuff. Otherwise seems like the right thing to do. BR, Jani. > + > static void intel_set_transcoder_timings(const struct intel_crtc_state *crtc_state) > { > struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc); > diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h > index f4a0773f0fca..0dc39a8a517e 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.h > +++ b/drivers/gpu/drm/i915/display/intel_display.h > @@ -484,6 +484,8 @@ void intel_cpu_transcoder_get_m1_n1(struct intel_crtc *crtc, > void intel_cpu_transcoder_get_m2_n2(struct intel_crtc *crtc, > enum transcoder cpu_transcoder, > struct intel_link_m_n *m_n); > +bool intel_cpu_transcoder_has_drrs(struct drm_i915_private *i915, > + enum transcoder cpu_transcoder); > int intel_dotclock_calculate(int link_freq, const struct intel_link_m_n *m_n); > int intel_crtc_dotclock(const struct intel_crtc_state *pipe_config); > enum intel_display_power_domain intel_port_to_power_domain(struct intel_digital_port *dig_port); > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index e13121dc3a03..5c3c0449e866 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2689,15 +2689,6 @@ intel_dp_compute_hdr_metadata_infoframe_sdp(struct intel_dp *intel_dp, > intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GAMUT_METADATA); > } > > -static bool cpu_transcoder_has_drrs(struct drm_i915_private *i915, > - enum transcoder cpu_transcoder) > -{ > - if (HAS_DOUBLE_BUFFERED_M_N(i915)) > - return true; > - > - return intel_cpu_transcoder_has_m2_n2(i915, cpu_transcoder); > -} > - > static bool can_enable_drrs(struct intel_connector *connector, > const struct intel_crtc_state *pipe_config, > const struct drm_display_mode *downclock_mode) > @@ -2720,7 +2711,7 @@ static bool can_enable_drrs(struct intel_connector *connector, > if (pipe_config->has_pch_encoder) > return false; > > - if (!cpu_transcoder_has_drrs(i915, pipe_config->cpu_transcoder)) > + if (!intel_cpu_transcoder_has_drrs(i915, pipe_config->cpu_transcoder)) > return false; > > return downclock_mode && -- Jani Nikula, Intel