From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 271CBC83F01 for ; Wed, 30 Aug 2023 12:02:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C744810E517; Wed, 30 Aug 2023 12:02:37 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A359F10E506; Wed, 30 Aug 2023 12:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693396954; x=1724932954; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=KAIn8zcUVsY7lR+dgOcre9ON6BCkdhnH1COZwODlavs=; b=OpCyLuJpn2YNS8P/nQC9iZ+UFor1SGQRsuECO9f4cVj+4INMQPvdgv5q 7lXmDVff+RAoEstRT9V6NdBFalDMV08rKawG8GHZ3xkmuO1Y425WuiOh1 1paPn5Nta0Xktdq3lphCCsKVpSGiZyAWI9ktnxXPl1ZAEE5TOCtbBzPoz YqdW2kUILLv9rT20LqZom1vFsAIXDSCkVKQ78zrA9OKt78+pzTyd8HZvs 6r44BGlumwJ6M8dnFlCgs0a+Q+sftksGF/oCVryv/lpF+NwxlDABLpaze rcKRTLLpExrLBhiKxdCMNb/tUzKXGZ3Qco1YGnF4drCNKtNMG5bXEqeEH w==; X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="375577495" X-IronPort-AV: E=Sophos;i="6.02,213,1688454000"; d="scan'208";a="375577495" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 05:02:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="774093740" X-IronPort-AV: E=Sophos;i="6.02,213,1688454000"; d="scan'208";a="774093740" Received: from ziemtocx-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.57.251]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 05:02:20 -0700 From: Jani Nikula To: Ankit Nautiyal , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org In-Reply-To: <20230824125121.840298-3-ankit.k.nautiyal@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230824125121.840298-1-ankit.k.nautiyal@intel.com> <20230824125121.840298-3-ankit.k.nautiyal@intel.com> Date: Wed, 30 Aug 2023 15:02:18 +0300 Message-ID: <87v8cwzqk5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 24 Aug 2023, Ankit Nautiyal wrote: > Edid specific BPC constraints are stored in limits->max_bpp. Honor these > limits while computing the input bpp for DSC. > > v2: Use int instead of u8 for computations. (Jani) > Add closes tag. (Ankit) > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9161 > Signed-off-by: Ankit Nautiyal > Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_dp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 7067ee3a4bd3..8f3dc79089ea 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2061,9 +2061,10 @@ static int intel_edp_dsc_compute_pipe_bpp(struct intel_dp *intel_dp, > if (forced_bpp) { > pipe_bpp = forced_bpp; > } else { > + int max_bpc = min(limits->max_bpp / 3, (int)conn_state->max_requested_bpc); Hmh, only noticed after pushing, there's min_t() for when the types differ. BR, Jani. > + > /* For eDP use max bpp that can be supported with DSC. */ > - pipe_bpp = intel_dp_dsc_compute_max_bpp(intel_dp, > - conn_state->max_requested_bpc); > + pipe_bpp = intel_dp_dsc_compute_max_bpp(intel_dp, max_bpc); > if (!is_dsc_pipe_bpp_sufficient(i915, conn_state, limits, pipe_bpp)) { > drm_dbg_kms(&i915->drm, > "Computed BPC is not in DSC BPC limits\n"); -- Jani Nikula, Intel Open Source Graphics Center