From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8E97C7619A for ; Thu, 6 Apr 2023 01:02:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AEF0610E337; Thu, 6 Apr 2023 01:02:07 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6733B10E337 for ; Thu, 6 Apr 2023 01:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680742925; x=1712278925; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=WyXLlZo9cHljnodfZyzr20Z5RcSB274SKPtcEyF4Ny4=; b=L6R9+9l2+JzIOp3Fi73e8apLk4YLx8r1OQSAnaA4KVI9P37c8tdY7LYn eBG+n+oXFXv8K8pSHCKbBDS+iMApyemGr94mEby2U5qfk3UKLH/Vjp/bU zZPe8p8CeyGaEn+NRZO5M9Slus5gzb0NM4RrdRKGIondFlH4XxT9eLVU6 wmGOUZzW6DhWQnJLcSjuSUovN7XAl7ZXMBO5VJGkFalvg/D6V4jIfJAdx R6cy4SsyourDiofVbu63A6O6EkBUtfkDmghlYz6vkZ7/su0e8MNY+exb2 uT1fYwE8Y/m92Uk2OaDPWkZnz5YsWPtytcbmU5VASVUqszg5WlXIpKlN1 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="322983891" X-IronPort-AV: E=Sophos;i="5.98,322,1673942400"; d="scan'208";a="322983891" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 18:02:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="776261680" X-IronPort-AV: E=Sophos;i="5.98,322,1673942400"; d="scan'208";a="776261680" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.39.173]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 18:02:04 -0700 Date: Wed, 05 Apr 2023 18:02:04 -0700 Message-ID: <87v8i9omb7.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Riana Tauro In-Reply-To: <20230405065930.3576936-5-riana.tauro@intel.com> References: <20230405065930.3576936-1-riana.tauro@intel.com> <20230405065930.3576936-5-riana.tauro@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v9 4/4] drm/i915/selftests: skip comparison of power for discrete graphics X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 04 Apr 2023 23:59:30 -0700, Riana Tauro wrote: > Hi Riana, > Hwmon reads the energy/power consumed by discrete soc, > i.e. energy/power includes the power drawn from non-gfx discrete > components > > This test uses the power consumed by GT to validate RC6 > power consumption. > Skip comparison of power for discrete graphics > > TODO : measure power of GT in discrete graphics and modify the > condition > > v2: update commit message (Anshuman) > > Signed-off-by: Riana Tauro > Reviewed-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/gt/selftest_rc6.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/drivers/gpu/drm/i915/gt/selftest_rc6.c > index 682f2fe67b3a..47165f490449 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_rc6.c > +++ b/drivers/gpu/drm/i915/gt/selftest_rc6.c > @@ -107,7 +107,15 @@ int live_rc6_manual(void *arg) > ktime_to_ns(dt)); > pr_info("GPU consumed %llduW in RC0 and %llduW in RC6\n", > rc0_power, rc6_power); > - if (2 * rc6_power > rc0_power) { So this condition is not being met for dGfx? > + > + /* > + * Condition valid for integrated graphics > + * On discrete graphics, hwwmon reads the energy/power from > + * discrete SOC that includes non-gfx components. On dGfx, is this true even when we have per-gt level energy available? Or only when we have device level energy but not per-gt level energy (when total number of gt's is 1 and we only expose device level energy but not gt level energy)? > + * TODO : Measure power of GT for discrete graphics and > + * modify the condition If we are adding this TODO, how are we planning to do this? > + */ > + if (!IS_DGFX(gt->i915) && (2 * rc6_power > rc0_power)) { > pr_err("GPU leaked energy while in RC6!\n"); > err = -EINVAL; > goto out_unlock; Thanks. -- Ashutosh