Re: [Intel-gfx] [PATCH 1/2] drm/i915: add struct i915_dsm to wrap dsm members together

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 17 Jan 2023, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Mon, Jan 16, 2023 at 07:34:21PM +0200, Jani Nikula wrote:
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index 72ca62c22797..13fab81a39b8 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -86,6 +86,35 @@ struct intel_pxp;
>>  
>>  #define GEM_QUIRK_PIN_SWIZZLED_PAGES	BIT(0)
>>  
>> +struct i915_dsm {
>> +	/*
>> +	 * Data Stolen Memory - aka "i915 stolen memory" gives us the start and
>> +	 * end of stolen 
>
> The 'Data Stolen Memory - aka "i915 stolen memory"' should probably be moved
> above along with the struct definition, and leave just the resource part,
> something like Stolen gives us the start and end of stolen...."
>
> or something like that...

Agreed.

>
> But up to you, the patch already looks like a good move
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Thanks, pushed to din, and took the rare liberty to update the comments
while applying.

BR,
Jani.



-- 
Jani Nikula, Intel Open Source Graphics Center