From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06CD4C433FE for ; Wed, 19 Oct 2022 23:41:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D881F10E196; Wed, 19 Oct 2022 23:41:49 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id A260410E196; Wed, 19 Oct 2022 23:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666222900; x=1697758900; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=a5K2RrkC6aI3RkW2vGkDkxh4EyJEWqzVKCaLXCAvXcc=; b=DTgXxjfrKasZ6dZiX3bfI/Ll+30m0+m+yKxgr8j4Kk+++KWGBTq6bZfh kftMrX15/aLjTH1l77VSI74N9ZHhGKMAPdV2pqwIRxVzuGwbCphkn99j7 HuJ8/HoDbuJRk8uC1ypzkfsLPKM7K8CaKBeSrHUJCc9HmWhH1FZEZZ11c Uks8DnaDuSF8NMYUHz336CvLmEmqG7ZvsyS6X/ChItay0d4P/rT3gq+uv dmGsL4V6n+uID6lYXo/b6yBFTeD3vP5jIZCUJCI7TcNFmN3xyEjwq9GiP 1zXbs07WjuWdV1AZFI6lQfX+/MuCBXX2cRWKqvdhmR4SzBJICe7/4OlgA A==; X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="307658426" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="307658426" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 16:41:39 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="580580018" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="580580018" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.69.147]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 16:41:39 -0700 Date: Wed, 19 Oct 2022 16:41:25 -0700 Message-ID: <87v8ofidp6.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: intel-gfx@lists.freedesktop.org In-Reply-To: <87bkqajjke.wl-ashutosh.dixit@intel.com> References: <20221015032618.2458429-1-ashutosh.dixit@intel.com> <20221015032618.2458429-4-ashutosh.dixit@intel.com> <87bkqajjke.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/mtl: C6 residency and C state type for MTL SAMedia X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 17 Oct 2022 13:12:33 -0700, Dixit, Ashutosh wrote: > > On Fri, 14 Oct 2022 20:26:18 -0700, Ashutosh Dixit wrote: > > > > From: Badal Nilawar > > Hi Badal, > > One question below. > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > index 1fb053cbf52db..3a9bb4387248e 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > @@ -256,6 +256,61 @@ static int ilk_drpc(struct seq_file *m) > > return 0; > > } > > > > +static int mtl_drpc(struct seq_file *m) > > +{ > > Here we have: > > > + global_forcewake = intel_uncore_read(uncore, FORCEWAKE_GT_GEN9); > and > > + seq_printf(m, "Global Forcewake Requests: 0x%x\n", global_forcewake); > > In gen6_drpc we have: > > mt_fwake_req = intel_uncore_read_fw(uncore, FORCEWAKE_MT); > and > seq_printf(m, "Multi-threaded Forcewake Request: 0x%x\n", mt_fwake_req); > > Also: > #define FORCEWAKE_MT _MMIO(0xa188) > #define FORCEWAKE_GT_GEN9 _MMIO(0xa188) > > So they are both the same register. So what is the reason for this > difference, which one should we use? > > Also let's have the prints in the same order as gen6_drpc (move fw request > before rc6 residency). This has been made identical to gen6_drpc in series v8. Thanks. -- Ashutosh