From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C86CC433DB for ; Mon, 22 Feb 2021 10:17:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9640C64E25 for ; Mon, 22 Feb 2021 10:17:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9640C64E25 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B21F6E4BA; Mon, 22 Feb 2021 10:17:50 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95A4A6E4BA for ; Mon, 22 Feb 2021 10:17:48 +0000 (UTC) IronPort-SDR: cjn/HcFoxPfbi+us6fOq42U1MGjZjgdbk39f6uIW2uxLNzUs2dqjMwAeiql2gj5RYtsPvQ+z5C N4D5ZrPqFp4A== X-IronPort-AV: E=McAfee;i="6000,8403,9902"; a="248453016" X-IronPort-AV: E=Sophos;i="5.81,196,1610438400"; d="scan'208";a="248453016" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 02:17:47 -0800 IronPort-SDR: Oq6ICk0zbZEtWqid/UJlM9O1X8FEWyJrrSZidZGHtZjDD5lLfFDr+bsZYprLZkNnJW1wokS9td Yhu1gc5dUkYw== X-IronPort-AV: E=Sophos;i="5.81,196,1610438400"; d="scan'208";a="402521300" Received: from reifs-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.39.145]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 02:17:44 -0800 From: Jani Nikula To: "Winkler\, Tomas" , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Joonas Lahtinen , "Vivi\, Rodrigo" In-Reply-To: <9768d50298114d7daf9736f17c6ed009@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210216181925.650082-1-tomas.winkler@intel.com> <20210216181925.650082-3-tomas.winkler@intel.com> <87eehfas5d.fsf@intel.com> <9768d50298114d7daf9736f17c6ed009@intel.com> Date: Mon, 22 Feb 2021 12:17:40 +0200 Message-ID: <87v9akfltn.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [RFC PATCH 2/9] drm/i915/spi: intel_spi_region map X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "De Marchi, Lucas" , "linux-mtd@lists.infradead.org" , "intel-gfx@lists.freedesktop.org" , "Usyskin, Alexander" , "Lubart, Vitaly" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 17 Feb 2021, "Winkler, Tomas" wrote: >> On Tue, 16 Feb 2021, Tomas Winkler wrote: >> > Add the dGFX spi region map and convey it via mfd cell platform data >> > to the spi child device. >> > >> > Cc: Rodrigo Vivi >> > Cc: Lucas De Marchi >> > Signed-off-by: Tomas Winkler >> > --- >> > drivers/gpu/drm/i915/spi/intel_spi.c | 9 +++++++++ >> > drivers/gpu/drm/i915/spi/intel_spi.h | 5 +++++ >> > 2 files changed, 14 insertions(+) >> > >> > diff --git a/drivers/gpu/drm/i915/spi/intel_spi.c >> > b/drivers/gpu/drm/i915/spi/intel_spi.c >> > index 07da7197bd5d..6f83f24f7208 100644 >> > --- a/drivers/gpu/drm/i915/spi/intel_spi.c >> > +++ b/drivers/gpu/drm/i915/spi/intel_spi.c >> > @@ -14,11 +14,20 @@ static const struct resource spi_resources[] = { >> > DEFINE_RES_MEM_NAMED(GEN12_GUNIT_SPI_BASE, 0x80, "i915- >> spi-mmio"), >> > }; >> > >> > +static const struct i915_spi_region regions[I915_SPI_REGIONS] = { >> > + [0] = { .name = "DESCRIPTOR", }, >> > + [2] = { .name = "GSC", }, >> > + [11] = { .name = "OptionROM", }, >> > + [12] = { .name = "DAM", }, >> > +}; >> > + >> > static const struct mfd_cell intel_spi_cell = { >> > .id = 2, >> > .name = "i915-spi", >> > .num_resources = ARRAY_SIZE(spi_resources), >> > .resources = spi_resources, >> > + .platform_data = (void *)regions, >> > + .pdata_size = sizeof(regions), >> > }; >> > >> > void intel_spi_init(struct intel_spi *spi, struct drm_i915_private >> > *dev_priv) diff --git a/drivers/gpu/drm/i915/spi/intel_spi.h >> > b/drivers/gpu/drm/i915/spi/intel_spi.h >> > index 276551fed993..6b5bf053f7d3 100644 >> > --- a/drivers/gpu/drm/i915/spi/intel_spi.h >> > +++ b/drivers/gpu/drm/i915/spi/intel_spi.h >> > @@ -8,6 +8,11 @@ >> > >> > struct drm_i915_private; >> > >> > +#define I915_SPI_REGIONS 13 >> > +struct i915_spi_region { >> > + const char *name; >> > +}; >> >> Does this need to be exposed to the rest of i915? > This part is between the device which is part of i915 and the driver. >>If we're trying to isolate >> spi/, I'd prefer it if this header was the only header included from the rest of >> i915, and contained the minimum required information. > >> As the driver has grown bigger, we've tried to minimize the interconnections >> between the modules, and it's slow going. Let's try to keep the new parts >> isolated. >> > So do you prefer we create another header or duplicate the structure definition? I didn't see the struct being used in i915, or am I missing something? Have a header that contains the interface exposed to the rest of i915, and another header with stuff internal to spi/? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx