public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org,
	Rodrigo Vivi <rodrigo.vivi@gmail.com>
Subject: Re: [PATCH] Revert "drm/i915: mark all device info struct with __initconst"
Date: Tue, 30 Jan 2018 10:44:46 +0200	[thread overview]
Message-ID: <87vafjd9c1.fsf@intel.com> (raw)
In-Reply-To: <87fu6pkmr2.fsf@intel.com>

On Mon, 29 Jan 2018, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 29 Jan 2018, Lionel Landwerlin <lionel.g.landwerlin@intel.com> wrote:
>> On 29/01/18 09:02, Chris Wilson wrote:
>>> Quoting Lionel Landwerlin (2018-01-29 08:33:46)
>>>> This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e.
>>>>
>>>>   Conflicts:
>>>>          drivers/gpu/drm/i915/i915_pci.c
>>>>
>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104805
>>> Fixes: 5b54eddd3920 ("drm/i915: mark all device info struct with __initconst")
>>>
>>> So it ends up in the right place.
>>> -Chris
>>>
>> Thanks, pushed.
>
> Please *always* wait for the full IGT results before pushing.
>
> Please *always* include a self-contained reason *why* in the commit
> message instead of relying on Bugzilla: link only.
>
> Please run 'dim fixes <commit>' to get the proper tags; now Cc: stable
> is missing. Fixes: alone doesn't cut it now that v4.15 has been
> released.

Rodrigo, please pick this up to drm-intel-next-fixes.

BR,
Jani.


>
> No patch needs to be merged within an hour. There's never such a
> rush. Please let's give more people a chance to look at the patches
> before they get merged.
>
>
> Thanks,
> Jani.
>
>
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-01-30  8:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29  8:33 [PATCH] Revert "drm/i915: mark all device info struct with __initconst" Lionel Landwerlin
2018-01-29  8:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-29  9:00 ` [PATCH] " Chris Wilson
2018-01-29 10:34   ` Tvrtko Ursulin
2018-01-29 10:44     ` Chris Wilson
2018-01-29  9:02 ` Chris Wilson
2018-01-29  9:27   ` Lionel Landwerlin
2018-01-29  9:57     ` Lukas Wunner
2018-01-29 10:00     ` Jani Nikula
2018-01-30  8:44       ` Jani Nikula [this message]
2018-01-31  2:15         ` Rodrigo Vivi
2018-01-31 17:02           ` Lionel Landwerlin
2018-01-29 10:32 ` ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vafjd9c1.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    --cc=rodrigo.vivi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox