* [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser
@ 2017-10-15 22:32 Christos Gkekas
2017-10-16 9:08 ` Jani Nikula
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Christos Gkekas @ 2017-10-15 22:32 UTC (permalink / raw)
To: fred gao, Zhenyu Wang, Zhi Wang, Jani Nikula, Joonas Lahtinen,
Rodrigo Vivi, David Airlie, intel-gvt-dev, intel-gfx, dri-devel,
linux-kernel
Cc: Christos Gkekas
Delete variables 'gma_bottom' that are set but never used.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
index 2c0ccbb..d75ce70 100644
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -2511,7 +2511,7 @@ static int command_scan(struct parser_exec_state *s,
static int scan_workload(struct intel_vgpu_workload *workload)
{
- unsigned long gma_head, gma_tail, gma_bottom;
+ unsigned long gma_head, gma_tail;
struct parser_exec_state s;
int ret = 0;
@@ -2521,7 +2521,6 @@ static int scan_workload(struct intel_vgpu_workload *workload)
gma_head = workload->rb_start + workload->rb_head;
gma_tail = workload->rb_start + workload->rb_tail;
- gma_bottom = workload->rb_start + _RING_CTL_BUF_SIZE(workload->rb_ctl);
s.buf_type = RING_BUFFER_INSTRUCTION;
s.buf_addr_type = GTT_BUFFER;
@@ -2557,7 +2556,7 @@ static int scan_workload(struct intel_vgpu_workload *workload)
static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
{
- unsigned long gma_head, gma_tail, gma_bottom, ring_size, ring_tail;
+ unsigned long gma_head, gma_tail, ring_size, ring_tail;
struct parser_exec_state s;
int ret = 0;
struct intel_vgpu_workload *workload = container_of(wa_ctx,
@@ -2573,7 +2572,6 @@ static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
PAGE_SIZE);
gma_head = wa_ctx->indirect_ctx.guest_gma;
gma_tail = wa_ctx->indirect_ctx.guest_gma + ring_tail;
- gma_bottom = wa_ctx->indirect_ctx.guest_gma + ring_size;
s.buf_type = RING_BUFFER_INSTRUCTION;
s.buf_addr_type = GTT_BUFFER;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser
2017-10-15 22:32 [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser Christos Gkekas
@ 2017-10-16 9:08 ` Jani Nikula
2017-10-16 19:02 ` Christos Gkekas
2017-10-16 10:31 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2017-10-16 9:08 UTC (permalink / raw)
To: fred gao, Zhenyu Wang, Zhi Wang, Joonas Lahtinen, Rodrigo Vivi,
intel-gvt-dev, intel-gfx
Cc: Christos Gkekas
On Sun, 15 Oct 2017, Christos Gkekas <chris.gekas@gmail.com> wrote:
> Delete variables 'gma_bottom' that are set but never used.
Please use common sense in choosing the mailing lists and maintainers
you send patches to. In this case, intel-gvt-dev would have been
sufficient, with intel-gfx more than enough. Including Dave or dri-devel
or LKML is excessive. Arguably including Joonas, Rodrigo and myself is
also too much.
Please at least put it in context. This is a non-functional change
removing some dead code, not an urgent fix to some hair rising jaw
dropping bug.
Thanks,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser
2017-10-16 9:08 ` Jani Nikula
@ 2017-10-16 19:02 ` Christos Gkekas
2017-10-17 7:25 ` Jani Nikula
0 siblings, 1 reply; 7+ messages in thread
From: Christos Gkekas @ 2017-10-16 19:02 UTC (permalink / raw)
To: Jani Nikula; +Cc: fred gao, intel-gfx, Rodrigo Vivi, intel-gvt-dev
On 16/10/17 12:08:19 +0300, Jani Nikula wrote:
> On Sun, 15 Oct 2017, Christos Gkekas <chris.gekas@gmail.com> wrote:
> > Delete variables 'gma_bottom' that are set but never used.
>
> Please use common sense in choosing the mailing lists and maintainers
> you send patches to. In this case, intel-gvt-dev would have been
> sufficient, with intel-gfx more than enough. Including Dave or dri-devel
> or LKML is excessive. Arguably including Joonas, Rodrigo and myself is
> also too much.
>
> Please at least put it in context. This is a non-functional change
> removing some dead code, not an urgent fix to some hair rising jaw
> dropping bug.
>
> Thanks,
> Jani.
>
> --
> Jani Nikula, Intel Open Source Technology Center
Hi Jani,
Thanks for your feedback and sorry for any inconvenience caused.
I was trying to follow the good patch practices outlined in the link
below and used the get_maintainer.pl script to identify who to send the
patches to. I am sorry but I have no idea of who-is-who within intel and
who would be the best person or list to contact. Also intel-gvt-dev is a
members-only list.
https://kernelnewbies.org/FirstKernelPatch#head-dc6a8aa0be0d0e8ed9dc03726d0b5a1fb0f65e1f
Regarding your second point, I believe the title of this patch is pretty
clear. Dead code is _dead_ and thus by definition not a functional
change or bug fix. There was nothing in my email to indicate this is an
'urgent fix to some hair rising jaw dropping bug'. I am not sure what is
the source of confusion?
Thanks
Christos.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser
2017-10-16 19:02 ` Christos Gkekas
@ 2017-10-17 7:25 ` Jani Nikula
0 siblings, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2017-10-17 7:25 UTC (permalink / raw)
To: Christos Gkekas; +Cc: fred gao, intel-gfx, Rodrigo Vivi, intel-gvt-dev
On Mon, 16 Oct 2017, Christos Gkekas <chris.gekas@gmail.com> wrote:
> On 16/10/17 12:08:19 +0300, Jani Nikula wrote:
>> On Sun, 15 Oct 2017, Christos Gkekas <chris.gekas@gmail.com> wrote:
>> > Delete variables 'gma_bottom' that are set but never used.
>>
>> Please use common sense in choosing the mailing lists and maintainers
>> you send patches to. In this case, intel-gvt-dev would have been
>> sufficient, with intel-gfx more than enough. Including Dave or dri-devel
>> or LKML is excessive. Arguably including Joonas, Rodrigo and myself is
>> also too much.
>>
>> Please at least put it in context. This is a non-functional change
>> removing some dead code, not an urgent fix to some hair rising jaw
>> dropping bug.
>>
>> Thanks,
>> Jani.
>>
>> --
>> Jani Nikula, Intel Open Source Technology Center
>
> Hi Jani,
>
> Thanks for your feedback and sorry for any inconvenience caused.
Don't worry about it, I'm just trying to help you out here. :)
> I was trying to follow the good patch practices outlined in the link
> below and used the get_maintainer.pl script to identify who to send the
> patches to. I am sorry but I have no idea of who-is-who within intel and
> who would be the best person or list to contact. Also intel-gvt-dev is a
> members-only list.
>
> https://kernelnewbies.org/FirstKernelPatch#head-dc6a8aa0be0d0e8ed9dc03726d0b5a1fb0f65e1f
Too bad the page fails to mention axing off excessive recipients
typically returned by get_maintainer.pl. I wish the script had saner
defaults.
> Regarding your second point, I believe the title of this patch is pretty
> clear. Dead code is _dead_ and thus by definition not a functional
> change or bug fix. There was nothing in my email to indicate this is an
> 'urgent fix to some hair rising jaw dropping bug'. I am not sure what is
> the source of confusion?
There was no confusion in the title or commit message. I tried to say,
trim the number of recipients also based on the urgency of the
patch. Cc: the world if it's super urgent and important. Smaller
distribution is sufficient for cleanups.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/gvt: Clean up dead code in cmd_parser
2017-10-15 22:32 [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser Christos Gkekas
2017-10-16 9:08 ` Jani Nikula
@ 2017-10-16 10:31 ` Patchwork
2017-10-16 16:14 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-10-23 16:35 ` [PATCH] " Zhi Wang
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-10-16 10:31 UTC (permalink / raw)
To: Christos Gkekas; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gvt: Clean up dead code in cmd_parser
URL : https://patchwork.freedesktop.org/series/32023/
State : success
== Summary ==
Series 32023v1 drm/i915/gvt: Clean up dead code in cmd_parser
https://patchwork.freedesktop.org/api/1.0/series/32023/revisions/1/mbox/
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:456s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:465s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:388s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:573s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:284s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:520s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:527s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:536s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:520s
fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:568s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:434s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:272s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:602s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:438s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:464s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:502s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:480s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:506s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:490s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:591s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:648s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:480s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:653s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:526s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:578s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:471s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:582s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:426s
32c6bd6dc86e74ea335f8842e62a90ae0a617587 drm-tip: 2017y-10m-16d-09h-30m-45s UTC integration manifest
ea0210827aaf drm/i915/gvt: Clean up dead code in cmd_parser
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6046/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915/gvt: Clean up dead code in cmd_parser
2017-10-15 22:32 [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser Christos Gkekas
2017-10-16 9:08 ` Jani Nikula
2017-10-16 10:31 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-16 16:14 ` Patchwork
2017-10-23 16:35 ` [PATCH] " Zhi Wang
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-10-16 16:14 UTC (permalink / raw)
To: Christos Gkekas; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gvt: Clean up dead code in cmd_parser
URL : https://patchwork.freedesktop.org/series/32023/
State : failure
== Summary ==
Test kms_color:
Subgroup ctm-0-5-pipe3:
skip -> INCOMPLETE (shard-hsw)
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-atomic:
pass -> FAIL (shard-hsw)
shard-hsw total:2553 pass:1410 dwarn:0 dfail:0 fail:9 skip:1083 time:9459s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6046/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser
2017-10-15 22:32 [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser Christos Gkekas
` (2 preceding siblings ...)
2017-10-16 16:14 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2017-10-23 16:35 ` Zhi Wang
3 siblings, 0 replies; 7+ messages in thread
From: Zhi Wang @ 2017-10-23 16:35 UTC (permalink / raw)
To: Christos Gkekas, fred gao, Zhenyu Wang, Jani Nikula,
Joonas Lahtinen, Rodrigo Vivi, David Airlie, intel-gvt-dev,
intel-gfx, dri-devel, linux-kernel
Thanks, applied! :)
On 10/16/17 06:32, Christos Gkekas wrote:
> Delete variables 'gma_bottom' that are set but never used.
>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index 2c0ccbb..d75ce70 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -2511,7 +2511,7 @@ static int command_scan(struct parser_exec_state *s,
>
> static int scan_workload(struct intel_vgpu_workload *workload)
> {
> - unsigned long gma_head, gma_tail, gma_bottom;
> + unsigned long gma_head, gma_tail;
> struct parser_exec_state s;
> int ret = 0;
>
> @@ -2521,7 +2521,6 @@ static int scan_workload(struct intel_vgpu_workload *workload)
>
> gma_head = workload->rb_start + workload->rb_head;
> gma_tail = workload->rb_start + workload->rb_tail;
> - gma_bottom = workload->rb_start + _RING_CTL_BUF_SIZE(workload->rb_ctl);
>
> s.buf_type = RING_BUFFER_INSTRUCTION;
> s.buf_addr_type = GTT_BUFFER;
> @@ -2557,7 +2556,7 @@ static int scan_workload(struct intel_vgpu_workload *workload)
> static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
> {
>
> - unsigned long gma_head, gma_tail, gma_bottom, ring_size, ring_tail;
> + unsigned long gma_head, gma_tail, ring_size, ring_tail;
> struct parser_exec_state s;
> int ret = 0;
> struct intel_vgpu_workload *workload = container_of(wa_ctx,
> @@ -2573,7 +2572,6 @@ static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
> PAGE_SIZE);
> gma_head = wa_ctx->indirect_ctx.guest_gma;
> gma_tail = wa_ctx->indirect_ctx.guest_gma + ring_tail;
> - gma_bottom = wa_ctx->indirect_ctx.guest_gma + ring_size;
>
> s.buf_type = RING_BUFFER_INSTRUCTION;
> s.buf_addr_type = GTT_BUFFER;
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-10-23 16:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-15 22:32 [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser Christos Gkekas
2017-10-16 9:08 ` Jani Nikula
2017-10-16 19:02 ` Christos Gkekas
2017-10-17 7:25 ` Jani Nikula
2017-10-16 10:31 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-16 16:14 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-10-23 16:35 ` [PATCH] " Zhi Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox