From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/3] drm/i915/execlists: Move request unwinding to a separate function Date: Mon, 25 Sep 2017 15:55:26 +0300 Message-ID: <87vak7ym2p.fsf@gaia.fi.intel.com> References: <20170925124929.16974-1-chris@chris-wilson.co.uk> <20170925124929.16974-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE7E98990D for ; Mon, 25 Sep 2017 12:57:24 +0000 (UTC) In-Reply-To: <20170925124929.16974-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSW4gdGhl IGZ1dHVyZSwgd2Ugd2lsbCB3YW50IHRvIHVud2luZCByZXF1ZXN0cyBmb2xsb3dpbmcgYSBwcmVl bXB0aW9uCj4gcG9pbnQuIFRoaXMgcmVxdWlyZXMgdGhlIHNhbWUgc3RlcHMgYXMgZm9yIHVud2lu ZGluZyB1cG9uIGEgcmVzZXQsIHNvCj4gZXh0cmFjdCB0aGUgZXhpc3RpbmcgY29kZSB0byBhIHNl cGFyYXRlIGZ1bmN0aW9uIGZvciBsYXRlciB1c2UuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfbHJjLmMgfCA1MyArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggMmMwN2YzYzA4YmQzLi5jODQ4 MzFjN2VhNGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC0zNDgsNiArMzQ4 LDM3IEBAIGxvb2t1cF9wcmlvbGlzdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4g IAlyZXR1cm4gcHRyX3BhY2tfYml0cyhwLCBmaXJzdCwgMSk7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2 b2lkIHVud2luZF93YV90YWlsKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEpCj4gK3sK PiArCXJxLT50YWlsID0gaW50ZWxfcmluZ193cmFwKHJxLT5yaW5nLAo+ICsJCQkJICAgcnEtPndh X3RhaWwgLSBXQV9UQUlMX0RXT1JEUypzaXplb2YodTMyKSk7Cj4gKwlhc3NlcnRfcmluZ190YWls X3ZhbGlkKHJxLT5yaW5nLCBycS0+dGFpbCk7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIHVud2lu ZF9pbmNvbXBsZXRlX3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAr ewo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSwgKnJuOwo+ICsKPiArCWxvY2tk ZXBfYXNzZXJ0X2hlbGQoJmVuZ2luZS0+dGltZWxpbmUtPmxvY2spOwo+ICsJbGlzdF9mb3JfZWFj aF9lbnRyeV9zYWZlX3JldmVyc2UocnEsIHJuLAo+ICsJCQkJCSAmZW5naW5lLT50aW1lbGluZS0+ cmVxdWVzdHMsCj4gKwkJCQkJIGxpbmspIHsKPiArCQlzdHJ1Y3QgaTkxNV9wcmlvbGlzdCAqcDsK PiArCj4gKwkJaWYgKGk5MTVfZ2VtX3JlcXVlc3RfY29tcGxldGVkKHJxKSkKPiArCQkJcmV0dXJu Owo+ICsKPiArCQlfX2k5MTVfZ2VtX3JlcXVlc3RfdW5zdWJtaXQocnEpOwo+ICsJCXVud2luZF93 YV90YWlsKHJxKTsKClRoaXMgaGVyZSByYWlzZWQgbXkgYXR0ZW50aW9uLiBXaHkgZG8geW91IHdh bnQKdG8gZG8gdGhpcyBmb3IgYWxsIHJlcXVlc3RzIG5vdz8KCi1NaWthCgo+ICsKPiArCQlwID0g bG9va3VwX3ByaW9saXN0KGVuZ2luZSwKPiArCQkJCSAgICAmcnEtPnByaW90cmVlLAo+ICsJCQkJ ICAgIHJxLT5wcmlvdHJlZS5wcmlvcml0eSk7Cj4gKwkJbGlzdF9hZGQoJnJxLT5wcmlvdHJlZS5s aW5rLAo+ICsJCQkgJnB0cl9tYXNrX2JpdHMocCwgMSktPnJlcXVlc3RzKTsKPiArCX0KPiArfQo+ ICsKPiAgc3RhdGljIGlubGluZSB2b2lkCj4gIGV4ZWNsaXN0c19jb250ZXh0X3N0YXR1c19jaGFu Z2Uoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSwKPiAgCQkJCXVuc2lnbmVkIGxvbmcg c3RhdHVzKQo+IEBAIC0xMzc4LDcgKzE0MDksNiBAQCBzdGF0aWMgdm9pZCByZXNldF9jb21tb25f cmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gIAkJCSAgICAgIHN0cnVjdCBk cm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiAgewo+ICAJc3RydWN0IGludGVsX2VuZ2lu ZV9leGVjbGlzdHMgKiBjb25zdCBleGVjbGlzdHMgPSAmZW5naW5lLT5leGVjbGlzdHM7Cj4gLQlz dHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxLCAqcm47Cj4gIAlzdHJ1Y3QgaW50ZWxfY29u dGV4dCAqY2U7Cj4gIAl1bnNpZ25lZCBsb25nIGZsYWdzOwo+ICAKPiBAQCAtMTM5NiwyMSArMTQy Niw3IEBAIHN0YXRpYyB2b2lkIHJlc2V0X2NvbW1vbl9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVf Y3MgKmVuZ2luZSwKPiAgCWV4ZWNsaXN0X2NhbmNlbF9wb3J0X3JlcXVlc3RzKGV4ZWNsaXN0cyk7 Cj4gIAo+ICAJLyogUHVzaCBiYWNrIGFueSBpbmNvbXBsZXRlIHJlcXVlc3RzIGZvciByZXBsYXkg YWZ0ZXIgdGhlIHJlc2V0LiAqLwo+IC0JbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlX3JldmVyc2Uo cnEsIHJuLAo+IC0JCQkJCSAmZW5naW5lLT50aW1lbGluZS0+cmVxdWVzdHMsIGxpbmspIHsKPiAt CQlzdHJ1Y3QgaTkxNV9wcmlvbGlzdCAqcDsKPiAtCj4gLQkJaWYgKGk5MTVfZ2VtX3JlcXVlc3Rf Y29tcGxldGVkKHJxKSkKPiAtCQkJYnJlYWs7Cj4gLQo+IC0JCV9faTkxNV9nZW1fcmVxdWVzdF91 bnN1Ym1pdChycSk7Cj4gLQo+IC0JCXAgPSBsb29rdXBfcHJpb2xpc3QoZW5naW5lLAo+IC0JCQkJ ICAgICZycS0+cHJpb3RyZWUsCj4gLQkJCQkgICAgcnEtPnByaW90cmVlLnByaW9yaXR5KTsKPiAt CQlsaXN0X2FkZCgmcnEtPnByaW90cmVlLmxpbmssCj4gLQkJCSAmcHRyX21hc2tfYml0cyhwLCAx KS0+cmVxdWVzdHMpOwo+IC0JfQo+ICsJdW53aW5kX2luY29tcGxldGVfcmVxdWVzdHMoZW5naW5l KTsKPiAgCj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZlbmdpbmUtPnRpbWVsaW5lLT5sb2Nr LCBmbGFncyk7Cj4gIAo+IEBAIC0xNDQ3LDEwICsxNDYzLDcgQEAgc3RhdGljIHZvaWQgcmVzZXRf Y29tbW9uX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAJaW50ZWxfcmlu Z191cGRhdGVfc3BhY2UocmVxdWVzdC0+cmluZyk7Cj4gIAo+ICAJLyogUmVzZXQgV2FJZGxlTGl0 ZVJlc3RvcmU6YmR3LHNrbCBhcyB3ZWxsICovCj4gLQlyZXF1ZXN0LT50YWlsID0KPiAtCQlpbnRl bF9yaW5nX3dyYXAocmVxdWVzdC0+cmluZywKPiAtCQkJCXJlcXVlc3QtPndhX3RhaWwgLSBXQV9U QUlMX0RXT1JEUypzaXplb2YodTMyKSk7Cj4gLQlhc3NlcnRfcmluZ190YWlsX3ZhbGlkKHJlcXVl c3QtPnJpbmcsIHJlcXVlc3QtPnRhaWwpOwo+ICsJdW53aW5kX3dhX3RhaWwocmVxdWVzdCk7Cj4g IH0KPiAgCj4gIHN0YXRpYyBpbnQgaW50ZWxfbG9naWNhbF9yaW5nX2VtaXRfcGRwcyhzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSkKPiAtLSAKPiAyLjE0LjEKPgo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK