* [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID
@ 2017-08-17 10:55 Andy Shevchenko
2017-08-17 11:06 ` Mika Kahola
2017-08-17 11:17 ` ✓ Fi.CI.BAT: success for drm/i915/bxt: use NULL for GPIO connection ID (rev2) Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Andy Shevchenko @ 2017-08-17 10:55 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, intel-gfx, dri-devel,
Ville Syrjälä
Cc: Jani Nikula, Andy Shevchenko
The commit 213e08ad60ba
("drm/i915/bxt: add bxt dsi gpio element support")
enables GPIO support for Broxton based platforms.
While using that API we might get into troubles in the future, because
we can't rely on label name in the driver since vendor firmware might
provide any GPIO pin there, e.g. "reset", and even mark it in _DSD (in
which case the request will fail).
To avoid inconsistency and potential issues we have two options:
a) generate GPIO ACPI mapping table and supply it via
acpi_dev_add_driver_gpios(), or
b) just pass NULL as connection ID.
The b) approach is much simpler and would work since the driver relies
on GPIO indices only. Moreover, the _CRS fallback mechanism, when
requesting GPIO, has been made stricter, and supplying non-NULL
connection ID when neither _DSD, nor GPIO ACPI mapping is present, is
making request fail.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101921
Fixes: f10e4bf6632b ("gpio: acpi: Even more tighten up ACPI GPIO lookups")
Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2:
- adjust commit message for proper time tenses
- add Fixes: and Bugzilla: tags
drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c b/drivers/gpu/drm/i915/intel_dsi_vbt.c
index 7158c7ce9c09..91c07b0c8db9 100644
--- a/drivers/gpu/drm/i915/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c
@@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct drm_i915_private *dev_priv,
if (!gpio_desc) {
gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
- "panel", gpio_index,
+ NULL, gpio_index,
value ? GPIOD_OUT_LOW :
GPIOD_OUT_HIGH);
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID
2017-08-17 10:55 [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID Andy Shevchenko
@ 2017-08-17 11:06 ` Mika Kahola
2017-08-18 8:04 ` Jani Nikula
2017-08-18 11:46 ` Mika Kahola
2017-08-17 11:17 ` ✓ Fi.CI.BAT: success for drm/i915/bxt: use NULL for GPIO connection ID (rev2) Patchwork
1 sibling, 2 replies; 6+ messages in thread
From: Mika Kahola @ 2017-08-17 11:06 UTC (permalink / raw)
To: Andy Shevchenko, David Airlie, Daniel Vetter, intel-gfx,
dri-devel, Ville Syrjälä
Cc: Jani Nikula
Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01)
Tested-by: Mika Kahola <mika.kahola@intel.com>
On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote:
> The commit 213e08ad60ba
> ("drm/i915/bxt: add bxt dsi gpio element support")
> enables GPIO support for Broxton based platforms.
>
> While using that API we might get into troubles in the future,
> because
> we can't rely on label name in the driver since vendor firmware might
> provide any GPIO pin there, e.g. "reset", and even mark it in _DSD
> (in
> which case the request will fail).
>
> To avoid inconsistency and potential issues we have two options:
> a) generate GPIO ACPI mapping table and supply it via
> acpi_dev_add_driver_gpios(), or
> b) just pass NULL as connection ID.
>
> The b) approach is much simpler and would work since the driver
> relies
> on GPIO indices only. Moreover, the _CRS fallback mechanism, when
> requesting GPIO, has been made stricter, and supplying non-NULL
> connection ID when neither _DSD, nor GPIO ACPI mapping is present, is
> making request fail.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101921
> Fixes: f10e4bf6632b ("gpio: acpi: Even more tighten up ACPI GPIO
> lookups")
> Cc: Mika Kahola <mika.kahola@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2:
> - adjust commit message for proper time tenses
> - add Fixes: and Bugzilla: tags
> drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c
> b/drivers/gpu/drm/i915/intel_dsi_vbt.c
> index 7158c7ce9c09..91c07b0c8db9 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_vbt.c
> +++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c
> @@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct drm_i915_private
> *dev_priv,
>
> if (!gpio_desc) {
> gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
> - "panel",
> gpio_index,
> + NULL, gpio_index,
> value ?
> GPIOD_OUT_LOW :
> GPIOD_OUT_HIGH);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID
2017-08-17 11:06 ` Mika Kahola
@ 2017-08-18 8:04 ` Jani Nikula
2017-08-18 11:46 ` Mika Kahola
1 sibling, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2017-08-18 8:04 UTC (permalink / raw)
To: mika.kahola, Andy Shevchenko, David Airlie, Daniel Vetter,
intel-gfx, dri-devel, Ville Syrjälä
On Thu, 17 Aug 2017, Mika Kahola <mika.kahola@intel.com> wrote:
> Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01)
>
> Tested-by: Mika Kahola <mika.kahola@intel.com>
Do we have a bxt system available for testing this? With that,
Acked-by: Jani Nikula <jani.nikula@intel.com>
BR,
Jani.
>
> On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote:
>> The commit 213e08ad60ba
>> ("drm/i915/bxt: add bxt dsi gpio element support")
>> enables GPIO support for Broxton based platforms.
>>
>> While using that API we might get into troubles in the future,
>> because
>> we can't rely on label name in the driver since vendor firmware might
>> provide any GPIO pin there, e.g. "reset", and even mark it in _DSD
>> (in
>> which case the request will fail).
>>
>> To avoid inconsistency and potential issues we have two options:
>> a) generate GPIO ACPI mapping table and supply it via
>> acpi_dev_add_driver_gpios(), or
>> b) just pass NULL as connection ID.
>>
>> The b) approach is much simpler and would work since the driver
>> relies
>> on GPIO indices only. Moreover, the _CRS fallback mechanism, when
>> requesting GPIO, has been made stricter, and supplying non-NULL
>> connection ID when neither _DSD, nor GPIO ACPI mapping is present, is
>> making request fail.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101921
>> Fixes: f10e4bf6632b ("gpio: acpi: Even more tighten up ACPI GPIO
>> lookups")
>> Cc: Mika Kahola <mika.kahola@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> v2:
>> - adjust commit message for proper time tenses
>> - add Fixes: and Bugzilla: tags
>> drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c
>> b/drivers/gpu/drm/i915/intel_dsi_vbt.c
>> index 7158c7ce9c09..91c07b0c8db9 100644
>> --- a/drivers/gpu/drm/i915/intel_dsi_vbt.c
>> +++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c
>> @@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct drm_i915_private
>> *dev_priv,
>>
>> if (!gpio_desc) {
>> gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
>> - "panel",
>> gpio_index,
>> + NULL, gpio_index,
>> value ?
>> GPIOD_OUT_LOW :
>> GPIOD_OUT_HIGH);
>>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID
2017-08-17 11:06 ` Mika Kahola
2017-08-18 8:04 ` Jani Nikula
@ 2017-08-18 11:46 ` Mika Kahola
2017-08-18 13:21 ` Jani Nikula
1 sibling, 1 reply; 6+ messages in thread
From: Mika Kahola @ 2017-08-18 11:46 UTC (permalink / raw)
To: Andy Shevchenko, David Airlie, Daniel Vetter, intel-gfx,
dri-devel, Ville Syrjälä
Cc: Jani Nikula
On Thu, 2017-08-17 at 14:06 +0300, Mika Kahola wrote:
> Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01)
Tested also with APL + MIPI/DSI setup.
>
> Tested-by: Mika Kahola <mika.kahola@intel.com>
>
> On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote:
> >
> > The commit 213e08ad60ba
> > ("drm/i915/bxt: add bxt dsi gpio element support")
> > enables GPIO support for Broxton based platforms.
> >
> > While using that API we might get into troubles in the future,
> > because
> > we can't rely on label name in the driver since vendor firmware
> > might
> > provide any GPIO pin there, e.g. "reset", and even mark it in _DSD
> > (in
> > which case the request will fail).
> >
> > To avoid inconsistency and potential issues we have two options:
> > a) generate GPIO ACPI mapping table and supply it via
> > acpi_dev_add_driver_gpios(), or
> > b) just pass NULL as connection ID.
> >
> > The b) approach is much simpler and would work since the driver
> > relies
> > on GPIO indices only. Moreover, the _CRS fallback mechanism, when
> > requesting GPIO, has been made stricter, and supplying non-NULL
> > connection ID when neither _DSD, nor GPIO ACPI mapping is present,
> > is
> > making request fail.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101921
> > Fixes: f10e4bf6632b ("gpio: acpi: Even more tighten up ACPI GPIO
> > lookups")
> > Cc: Mika Kahola <mika.kahola@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > v2:
> > - adjust commit message for proper time tenses
> > - add Fixes: and Bugzilla: tags
> > drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c
> > b/drivers/gpu/drm/i915/intel_dsi_vbt.c
> > index 7158c7ce9c09..91c07b0c8db9 100644
> > --- a/drivers/gpu/drm/i915/intel_dsi_vbt.c
> > +++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c
> > @@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct
> > drm_i915_private
> > *dev_priv,
> >
> > if (!gpio_desc) {
> > gpio_desc = devm_gpiod_get_index(dev_priv-
> > >drm.dev,
> > - "panel",
> > gpio_index,
> > + NULL, gpio_index,
> > value ?
> > GPIOD_OUT_LOW :
> > GPIOD_OUT_HIGH);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Mika Kahola - Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID
2017-08-18 11:46 ` Mika Kahola
@ 2017-08-18 13:21 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2017-08-18 13:21 UTC (permalink / raw)
To: mika.kahola, Andy Shevchenko, David Airlie, Daniel Vetter,
intel-gfx, dri-devel, Ville Syrjälä
On Fri, 18 Aug 2017, Mika Kahola <mika.kahola@intel.com> wrote:
> On Thu, 2017-08-17 at 14:06 +0300, Mika Kahola wrote:
>> Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01)
> Tested also with APL + MIPI/DSI setup.
Pushed to drm-intel-next-queued, thanks for the patch and testing.
BR,
Jani.
>
>>
>> Tested-by: Mika Kahola <mika.kahola@intel.com>
>>
>> On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote:
>> >
>> > The commit 213e08ad60ba
>> > ("drm/i915/bxt: add bxt dsi gpio element support")
>> > enables GPIO support for Broxton based platforms.
>> >
>> > While using that API we might get into troubles in the future,
>> > because
>> > we can't rely on label name in the driver since vendor firmware
>> > might
>> > provide any GPIO pin there, e.g. "reset", and even mark it in _DSD
>> > (in
>> > which case the request will fail).
>> >
>> > To avoid inconsistency and potential issues we have two options:
>> > a) generate GPIO ACPI mapping table and supply it via
>> > acpi_dev_add_driver_gpios(), or
>> > b) just pass NULL as connection ID.
>> >
>> > The b) approach is much simpler and would work since the driver
>> > relies
>> > on GPIO indices only. Moreover, the _CRS fallback mechanism, when
>> > requesting GPIO, has been made stricter, and supplying non-NULL
>> > connection ID when neither _DSD, nor GPIO ACPI mapping is present,
>> > is
>> > making request fail.
>> >
>> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101921
>> > Fixes: f10e4bf6632b ("gpio: acpi: Even more tighten up ACPI GPIO
>> > lookups")
>> > Cc: Mika Kahola <mika.kahola@intel.com>
>> > Cc: Jani Nikula <jani.nikula@intel.com>
>> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> > ---
>> > v2:
>> > - adjust commit message for proper time tenses
>> > - add Fixes: and Bugzilla: tags
>> > drivers/gpu/drm/i915/intel_dsi_vbt.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c
>> > b/drivers/gpu/drm/i915/intel_dsi_vbt.c
>> > index 7158c7ce9c09..91c07b0c8db9 100644
>> > --- a/drivers/gpu/drm/i915/intel_dsi_vbt.c
>> > +++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c
>> > @@ -306,7 +306,7 @@ static void bxt_exec_gpio(struct
>> > drm_i915_private
>> > *dev_priv,
>> >
>> > if (!gpio_desc) {
>> > gpio_desc = devm_gpiod_get_index(dev_priv-
>> > >drm.dev,
>> > - "panel",
>> > gpio_index,
>> > + NULL, gpio_index,
>> > value ?
>> > GPIOD_OUT_LOW :
>> > GPIOD_OUT_HIGH);
>> >
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/bxt: use NULL for GPIO connection ID (rev2)
2017-08-17 10:55 [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID Andy Shevchenko
2017-08-17 11:06 ` Mika Kahola
@ 2017-08-17 11:17 ` Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-08-17 11:17 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bxt: use NULL for GPIO connection ID (rev2)
URL : https://patchwork.freedesktop.org/series/20011/
State : success
== Summary ==
Series 20011v2 drm/i915/bxt: use NULL for GPIO connection ID
https://patchwork.freedesktop.org/api/1.0/series/20011/revisions/2/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:454s
fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:452s
fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:364s
fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:552s
fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:524s
fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:531s
fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:518s
fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:617s
fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:447s
fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:426s
fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:425s
fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:511s
fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:476s
fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:479s
fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:596s
fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:595s
fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:524s
fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:478s
fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:482s
fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:493s
fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:437s
fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:489s
fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:548s
fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:409s
ada53b43f81fe618f3f0f1dfbd3dd776bb277323 drm-tip: 2017y-08m-16d-15h-18m-56s UTC integration manifest
9920a7e829ce drm/i915/bxt: use NULL for GPIO connection ID
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5425/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-18 13:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-17 10:55 [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID Andy Shevchenko
2017-08-17 11:06 ` Mika Kahola
2017-08-18 8:04 ` Jani Nikula
2017-08-18 11:46 ` Mika Kahola
2017-08-18 13:21 ` Jani Nikula
2017-08-17 11:17 ` ✓ Fi.CI.BAT: success for drm/i915/bxt: use NULL for GPIO connection ID (rev2) Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).