From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 5/8] drm/i915: Check error return when converting pipe to connector Date: Wed, 26 Apr 2017 17:12:32 +0300 Message-ID: <87vaprs1f3.fsf@intel.com> References: <1493214013-15580-1-git-send-email-imre.deak@intel.com> <1493214013-15580-6-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 66A106E41F for ; Wed, 26 Apr 2017 14:10:03 +0000 (UTC) In-Reply-To: <1493214013-15580-6-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyNiBBcHIgMjAxNywgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90 ZToKPiBBbiBlcnJvciBmcm9tIGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKCkgd291bGQg bWVhbiBhIGJ1ZyBzb21ld2hlcmUKPiBlbHNlLCBidXQgd2Ugc3RpbGwgc2hvdWxkIGNoZWNrIGZv ciBpdCB0byBwcmV2ZW50IHNvbWUgb3RoZXIgbW9yZQo+IG9ic2N1cmUgYnVnIGxhdGVyLgoKRG8g Y2hlY2sgZm9yIGludmFsaWQgcGlwZSwgYnV0IHBsZWFzZSBqdXN0IGxpbXAgb24gaW5zdGVhZCBv ZiBiYWlsaW5nCm91dCBvZiB0aGUgZnVuY3Rpb25zLiBTZWUgbm90ZXMgaW5saW5lLgoKQlIsCkph bmkuCgo+Cj4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jIHwgMTQgKysrKysrKysr KysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiBpbmRleCBjYjUwYzUyLi5kYmUwNWVj IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4gQEAgLTg4OCwxMCArODg4LDE0 IEBAIHN0YXRpYyB2b2lkIHBjaF9lbmFibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0 b3IgKmNvbm5lY3RvcikKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRv X2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4gIAlzdHJ1Y3QgaW50ZWxfcGFuZWwgKnBhbmVs ID0gJmNvbm5lY3Rvci0+cGFuZWw7Cj4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBl X2Zyb21fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gLQllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5z Y29kZXIgPQo+IC0JCWludGVsX3BpcGVfdG9fY3B1X3RyYW5zY29kZXIoZGV2X3ByaXYsIHBpcGUp Owo+ICsJZW51bSB0cmFuc2NvZGVyIGNwdV90cmFuc2NvZGVyOwo+ICAJdTMyIGNwdV9jdGwyLCBw Y2hfY3RsMSwgcGNoX2N0bDI7Cj4gIAo+ICsJaWYgKFdBUk5fT05fT05DRShwaXBlID09IElOVkFM SURfUElQRSkpCj4gKwkJcmV0dXJuOwoKUGxlYXNlIGp1c3QgYXNzaWduIGUuZy4gVFJBTlNDT0RF Ul9FRFAgdG8gY3B1X3RyYW5zY29kZXIgaW4gdGhpcyBjYXNlLApnbyBvbiwgYW5kIGhvcGUgZm9y IHRoZSBiZXN0LiBEbyBsZWF2ZSB0aGUgd2FybiBpbiBwbGFjZSB0aG91Z2guCgo+ICsKPiArCWNw dV90cmFuc2NvZGVyID0gaW50ZWxfcGlwZV90b19jcHVfdHJhbnNjb2RlcihkZXZfcHJpdiwgcGlw ZSk7Cj4gKwo+ICAJY3B1X2N0bDIgPSBJOTE1X1JFQUQoQkxDX1BXTV9DUFVfQ1RMMik7Cj4gIAlp ZiAoY3B1X2N0bDIgJiBCTE1fUFdNX0VOQUJMRSkgewo+ICAJCURSTV9ERUJVR19LTVMoImNwdSBi YWNrbGlnaHQgYWxyZWFkeSBlbmFibGVkXG4iKTsKPiBAQCAtOTczLDYgKzk3Nyw5IEBAIHN0YXRp YyB2b2lkIGk5NjVfZW5hYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25u ZWN0b3IpCj4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9y KGNvbm5lY3Rvcik7Cj4gIAl1MzIgY3RsLCBjdGwyLCBmcmVxOwo+ICAKPiArCWlmIChXQVJOX09O X09OQ0UocGlwZSA9PSBJTlZBTElEX1BJUEUpKQo+ICsJCXJldHVybjsKClNhbWUgaGVyZSwgcGxl YXNlIGp1c3QgYXNzaWduIGUuZy4gUElQRV9BIGhlcmUgd2l0aCB0aGUgd2FybmluZywgYW5kCmxp bXAgb24uCgo+ICsKPiAgCWN0bDIgPSBJOTE1X1JFQUQoQkxDX1BXTV9DVEwyKTsKPiAgCWlmIChj dGwyICYgQkxNX1BXTV9FTkFCTEUpIHsKPiAgCQlEUk1fREVCVUdfS01TKCJiYWNrbGlnaHQgYWxy ZWFkeSBlbmFibGVkXG4iKTsKPiBAQCAtMTA5Myw2ICsxMTAwLDkgQEAgdm9pZCBpbnRlbF9wYW5l bF9lbmFibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAg CWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50KQo+ICAJCXJldHVybjsKPiAgCj4gKwlpZiAo V0FSTl9PTl9PTkNFKHBpcGUgPT0gSU5WQUxJRF9QSVBFKSkKPiArCQlyZXR1cm47CgpIZXJlLCBw aXBlIGlzIG9ubHkgdXNlZCBmb3IgdGhlIGRlYnVnIGxvZ2dpbmcsIGp1c3Qgc2tpcCB0aGF0IGlu c3RlYWQuCgo+ICsKPiAgCURSTV9ERUJVR19LTVMoInBpcGUgJWNcbiIsIHBpcGVfbmFtZShwaXBl KSk7Cj4gIAo+ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmJhY2tsaWdodF9sb2NrKTsKCi0tIApK YW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==