* [PATCH v2] drm/i915/audio: fix hdmi audio noise issue
@ 2016-11-10 5:14 libin.yang
2016-11-10 5:47 ` ✓ Fi.CI.BAT: success for drm/i915/audio: fix hdmi audio noise issue (rev2) Patchwork
2016-11-10 10:37 ` [PATCH v2] drm/i915/audio: fix hdmi audio noise issue Jani Nikula
0 siblings, 2 replies; 6+ messages in thread
From: libin.yang @ 2016-11-10 5:14 UTC (permalink / raw)
To: intel-gfx, jani.nikula, ville.syrjala, daniel.vetter, tiwai
From: Libin Yang <libin.yang@intel.com>
Some monitors will have noise or even no sound after
applying the patch 6014ac12.
In patch 6014ac12, it will reset the cts value to 0 for HDMI.
However, we need to disable Enable CTS or M Prog bit. This is
the initial setting after HW reset.
Fixes: 6014ac122ed0 ("drm/i915/audio: set proper N/M in modeset")
Signed-off-by: Libin Yang <libin.yang@intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 813fd74..a472d35 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -332,6 +332,13 @@ hsw_hdmi_audio_config_update(struct intel_crtc *intel_crtc, enum port port,
int n;
u32 tmp;
+ /* reset CTS value to 0 */
+ tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe));
+ tmp &= ~AUD_CONFIG_M_MASK;
+ tmp &= ~AUD_M_CTS_M_VALUE_INDEX;
+ tmp |= AUD_M_CTS_M_PROG_ENABLE;
+ I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp);
+
tmp = I915_READ(HSW_AUD_CFG(pipe));
tmp &= ~AUD_CONFIG_N_VALUE_INDEX;
tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK;
@@ -351,10 +358,12 @@ hsw_hdmi_audio_config_update(struct intel_crtc *intel_crtc, enum port port,
I915_WRITE(HSW_AUD_CFG(pipe), tmp);
+ /*
+ * Let's disable "Enable CTS or M Prog bit"
+ * and let HW calculate the value
+ */
tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe));
- tmp &= ~AUD_CONFIG_M_MASK;
- tmp &= ~AUD_M_CTS_M_VALUE_INDEX;
- tmp |= AUD_M_CTS_M_PROG_ENABLE;
+ tmp &= ~AUD_M_CTS_M_PROG_ENABLE;
I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp);
}
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/audio: fix hdmi audio noise issue (rev2) 2016-11-10 5:14 [PATCH v2] drm/i915/audio: fix hdmi audio noise issue libin.yang @ 2016-11-10 5:47 ` Patchwork 2016-11-10 10:37 ` [PATCH v2] drm/i915/audio: fix hdmi audio noise issue Jani Nikula 1 sibling, 0 replies; 6+ messages in thread From: Patchwork @ 2016-11-10 5:47 UTC (permalink / raw) To: libin.yang; +Cc: intel-gfx == Series Details == Series: drm/i915/audio: fix hdmi audio noise issue (rev2) URL : https://patchwork.freedesktop.org/series/15012/ State : success == Summary == Series 15012v2 drm/i915/audio: fix hdmi audio noise issue https://patchwork.freedesktop.org/api/1.0/series/15012/revisions/2/mbox/ Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-a: fail -> PASS (fi-ivb-3520m) Subgroup suspend-read-crc-pipe-b: fail -> PASS (fi-ivb-3520m) Subgroup suspend-read-crc-pipe-c: fail -> PASS (fi-ivb-3520m) fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:204 dwarn:0 dfail:0 fail:0 skip:40 fi-bxt-t5700 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28 fi-byt-j1900 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28 fi-byt-n2820 total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32 fi-hsw-4770 total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20 fi-hsw-4770r total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20 fi-ilk-650 total:244 pass:191 dwarn:0 dfail:0 fail:0 skip:53 fi-ivb-3520m total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ivb-3770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-kbl-7200u total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:223 dwarn:0 dfail:0 fail:0 skip:21 fi-skl-6700k total:244 pass:222 dwarn:1 dfail:0 fail:0 skip:21 fi-snb-2520m total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32 fi-snb-2600 total:244 pass:211 dwarn:0 dfail:0 fail:0 skip:33 1afd351596b6deaead14d5812f0d6850379e30ad drm-intel-nightly: 2016y-11m-09d-21h-03m-31s UTC integration manifest 65718a7 drm/i915/audio: fix hdmi audio noise issue == Logs == For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_2950/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/i915/audio: fix hdmi audio noise issue 2016-11-10 5:14 [PATCH v2] drm/i915/audio: fix hdmi audio noise issue libin.yang 2016-11-10 5:47 ` ✓ Fi.CI.BAT: success for drm/i915/audio: fix hdmi audio noise issue (rev2) Patchwork @ 2016-11-10 10:37 ` Jani Nikula 2016-11-11 2:14 ` Yang, Libin 1 sibling, 1 reply; 6+ messages in thread From: Jani Nikula @ 2016-11-10 10:37 UTC (permalink / raw) To: libin.yang, intel-gfx, ville.syrjala, daniel.vetter, tiwai On Thu, 10 Nov 2016, libin.yang@intel.com wrote: > From: Libin Yang <libin.yang@intel.com> > > Some monitors will have noise or even no sound after > applying the patch 6014ac12. > > In patch 6014ac12, it will reset the cts value to 0 for HDMI. > However, we need to disable Enable CTS or M Prog bit. This is > the initial setting after HW reset. > > Fixes: 6014ac122ed0 ("drm/i915/audio: set proper N/M in modeset") > Signed-off-by: Libin Yang <libin.yang@intel.com> > --- > drivers/gpu/drm/i915/intel_audio.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c > index 813fd74..a472d35 100644 > --- a/drivers/gpu/drm/i915/intel_audio.c > +++ b/drivers/gpu/drm/i915/intel_audio.c > @@ -332,6 +332,13 @@ hsw_hdmi_audio_config_update(struct intel_crtc *intel_crtc, enum port port, > int n; > u32 tmp; > > + /* reset CTS value to 0 */ > + tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe)); > + tmp &= ~AUD_CONFIG_M_MASK; > + tmp &= ~AUD_M_CTS_M_VALUE_INDEX; > + tmp |= AUD_M_CTS_M_PROG_ENABLE; > + I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp); > + > tmp = I915_READ(HSW_AUD_CFG(pipe)); > tmp &= ~AUD_CONFIG_N_VALUE_INDEX; > tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK; > @@ -351,10 +358,12 @@ hsw_hdmi_audio_config_update(struct intel_crtc *intel_crtc, enum port port, > > I915_WRITE(HSW_AUD_CFG(pipe), tmp); > > + /* > + * Let's disable "Enable CTS or M Prog bit" > + * and let HW calculate the value > + */ > tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe)); > - tmp &= ~AUD_CONFIG_M_MASK; > - tmp &= ~AUD_M_CTS_M_VALUE_INDEX; > - tmp |= AUD_M_CTS_M_PROG_ENABLE; > + tmp &= ~AUD_M_CTS_M_PROG_ENABLE; > I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp); You did not address my review comment on the earlier version: Is it necessary to do the HSW_AUD_M_CTS_ENABLE updates in two places? Why do you both enable and disable AUD_M_CTS_M_PROG_ENABLE bit here? BR, Jani. > } -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/i915/audio: fix hdmi audio noise issue 2016-11-10 10:37 ` [PATCH v2] drm/i915/audio: fix hdmi audio noise issue Jani Nikula @ 2016-11-11 2:14 ` Yang, Libin 2016-11-11 8:41 ` Jani Nikula 0 siblings, 1 reply; 6+ messages in thread From: Yang, Libin @ 2016-11-11 2:14 UTC (permalink / raw) To: Jani Nikula, intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com, Vetter, Daniel, tiwai@suse.de Hi Jani, > -----Original Message----- > From: Jani Nikula [mailto:jani.nikula@linux.intel.com] > Sent: Thursday, November 10, 2016 6:37 PM > To: Yang, Libin <libin.yang@intel.com>; intel-gfx@lists.freedesktop.org; > ville.syrjala@linux.intel.com; Vetter, Daniel <daniel.vetter@intel.com>; > tiwai@suse.de > Cc: Yang, Libin <libin.yang@intel.com> > Subject: Re: [PATCH v2] drm/i915/audio: fix hdmi audio noise issue > > On Thu, 10 Nov 2016, libin.yang@intel.com wrote: > > From: Libin Yang <libin.yang@intel.com> > > > > Some monitors will have noise or even no sound after applying the > > patch 6014ac12. > > > > In patch 6014ac12, it will reset the cts value to 0 for HDMI. > > However, we need to disable Enable CTS or M Prog bit. This is the > > initial setting after HW reset. > > > > Fixes: 6014ac122ed0 ("drm/i915/audio: set proper N/M in modeset") > > Signed-off-by: Libin Yang <libin.yang@intel.com> > > --- > > drivers/gpu/drm/i915/intel_audio.c | 15 ++++++++++++--- > > 1 file changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_audio.c > > b/drivers/gpu/drm/i915/intel_audio.c > > index 813fd74..a472d35 100644 > > --- a/drivers/gpu/drm/i915/intel_audio.c > > +++ b/drivers/gpu/drm/i915/intel_audio.c > > @@ -332,6 +332,13 @@ hsw_hdmi_audio_config_update(struct intel_crtc > *intel_crtc, enum port port, > > int n; > > u32 tmp; > > > > + /* reset CTS value to 0 */ > > + tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe)); > > + tmp &= ~AUD_CONFIG_M_MASK; > > + tmp &= ~AUD_M_CTS_M_VALUE_INDEX; > > + tmp |= AUD_M_CTS_M_PROG_ENABLE; > > + I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp); > > + > > tmp = I915_READ(HSW_AUD_CFG(pipe)); > > tmp &= ~AUD_CONFIG_N_VALUE_INDEX; > > tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK; > > @@ -351,10 +358,12 @@ hsw_hdmi_audio_config_update(struct intel_crtc > > *intel_crtc, enum port port, > > > > I915_WRITE(HSW_AUD_CFG(pipe), tmp); > > > > + /* > > + * Let's disable "Enable CTS or M Prog bit" > > + * and let HW calculate the value > > + */ > > tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe)); > > - tmp &= ~AUD_CONFIG_M_MASK; > > - tmp &= ~AUD_M_CTS_M_VALUE_INDEX; > > - tmp |= AUD_M_CTS_M_PROG_ENABLE; > > + tmp &= ~AUD_M_CTS_M_PROG_ENABLE; > > I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp); > > You did not address my review comment on the earlier version: > > Is it necessary to do the HSW_AUD_M_CTS_ENABLE updates in two places? > Why do you both enable and disable AUD_M_CTS_M_PROG_ENABLE bit here? Sorry, I missed your comments. The first doing the HSW_AUD_M_CTS_ENABLE is to reset the M value to 0. The second doing the HSW_AUD_M_CTS_ENABLE is to let HW calculate the M value. Or we can just try to disable the HSW_AUD_M_CTS_ENABLE bit. What's your opinion? Regards, Libin > > BR, > Jani. > > > > } > > -- > Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/i915/audio: fix hdmi audio noise issue 2016-11-11 2:14 ` Yang, Libin @ 2016-11-11 8:41 ` Jani Nikula 2016-11-11 8:46 ` Yang, Libin 0 siblings, 1 reply; 6+ messages in thread From: Jani Nikula @ 2016-11-11 8:41 UTC (permalink / raw) To: Yang, Libin, intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com, Vetter, Daniel, tiwai@suse.de On Fri, 11 Nov 2016, "Yang, Libin" <libin.yang@intel.com> wrote: > Hi Jani, > >> -----Original Message----- >> From: Jani Nikula [mailto:jani.nikula@linux.intel.com] >> Sent: Thursday, November 10, 2016 6:37 PM >> To: Yang, Libin <libin.yang@intel.com>; intel-gfx@lists.freedesktop.org; >> ville.syrjala@linux.intel.com; Vetter, Daniel <daniel.vetter@intel.com>; >> tiwai@suse.de >> Cc: Yang, Libin <libin.yang@intel.com> >> Subject: Re: [PATCH v2] drm/i915/audio: fix hdmi audio noise issue >> >> On Thu, 10 Nov 2016, libin.yang@intel.com wrote: >> > From: Libin Yang <libin.yang@intel.com> >> > >> > Some monitors will have noise or even no sound after applying the >> > patch 6014ac12. >> > >> > In patch 6014ac12, it will reset the cts value to 0 for HDMI. >> > However, we need to disable Enable CTS or M Prog bit. This is the >> > initial setting after HW reset. >> > >> > Fixes: 6014ac122ed0 ("drm/i915/audio: set proper N/M in modeset") >> > Signed-off-by: Libin Yang <libin.yang@intel.com> >> > --- >> > drivers/gpu/drm/i915/intel_audio.c | 15 ++++++++++++--- >> > 1 file changed, 12 insertions(+), 3 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/i915/intel_audio.c >> > b/drivers/gpu/drm/i915/intel_audio.c >> > index 813fd74..a472d35 100644 >> > --- a/drivers/gpu/drm/i915/intel_audio.c >> > +++ b/drivers/gpu/drm/i915/intel_audio.c >> > @@ -332,6 +332,13 @@ hsw_hdmi_audio_config_update(struct intel_crtc >> *intel_crtc, enum port port, >> > int n; >> > u32 tmp; >> > >> > + /* reset CTS value to 0 */ >> > + tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe)); >> > + tmp &= ~AUD_CONFIG_M_MASK; >> > + tmp &= ~AUD_M_CTS_M_VALUE_INDEX; >> > + tmp |= AUD_M_CTS_M_PROG_ENABLE; >> > + I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp); >> > + >> > tmp = I915_READ(HSW_AUD_CFG(pipe)); >> > tmp &= ~AUD_CONFIG_N_VALUE_INDEX; >> > tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK; >> > @@ -351,10 +358,12 @@ hsw_hdmi_audio_config_update(struct intel_crtc >> > *intel_crtc, enum port port, >> > >> > I915_WRITE(HSW_AUD_CFG(pipe), tmp); >> > >> > + /* >> > + * Let's disable "Enable CTS or M Prog bit" >> > + * and let HW calculate the value >> > + */ >> > tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe)); >> > - tmp &= ~AUD_CONFIG_M_MASK; >> > - tmp &= ~AUD_M_CTS_M_VALUE_INDEX; >> > - tmp |= AUD_M_CTS_M_PROG_ENABLE; >> > + tmp &= ~AUD_M_CTS_M_PROG_ENABLE; >> > I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp); >> >> You did not address my review comment on the earlier version: >> >> Is it necessary to do the HSW_AUD_M_CTS_ENABLE updates in two places? >> Why do you both enable and disable AUD_M_CTS_M_PROG_ENABLE bit here? > > Sorry, I missed your comments. > > The first doing the HSW_AUD_M_CTS_ENABLE is to reset the M value to 0. > The second doing the HSW_AUD_M_CTS_ENABLE is to let HW calculate the M value. > > Or we can just try to disable the HSW_AUD_M_CTS_ENABLE bit. What's your opinion? I would have thought just doing the latter would be sufficient. Please test. BR, Jani. > > Regards, > Libin > >> >> BR, >> Jani. >> >> >> > } >> >> -- >> Jani Nikula, Intel Open Source Technology Center -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/i915/audio: fix hdmi audio noise issue 2016-11-11 8:41 ` Jani Nikula @ 2016-11-11 8:46 ` Yang, Libin 0 siblings, 0 replies; 6+ messages in thread From: Yang, Libin @ 2016-11-11 8:46 UTC (permalink / raw) To: Jani Nikula, intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com, Vetter, Daniel, tiwai@suse.de > -----Original Message----- > From: Jani Nikula [mailto:jani.nikula@linux.intel.com] > Sent: Friday, November 11, 2016 4:41 PM > To: Yang, Libin <libin.yang@intel.com>; intel-gfx@lists.freedesktop.org; > ville.syrjala@linux.intel.com; Vetter, Daniel <daniel.vetter@intel.com>; > tiwai@suse.de > Subject: RE: [PATCH v2] drm/i915/audio: fix hdmi audio noise issue > > On Fri, 11 Nov 2016, "Yang, Libin" <libin.yang@intel.com> wrote: > > Hi Jani, > > > >> -----Original Message----- > >> From: Jani Nikula [mailto:jani.nikula@linux.intel.com] > >> Sent: Thursday, November 10, 2016 6:37 PM > >> To: Yang, Libin <libin.yang@intel.com>; > >> intel-gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; > >> Vetter, Daniel <daniel.vetter@intel.com>; tiwai@suse.de > >> Cc: Yang, Libin <libin.yang@intel.com> > >> Subject: Re: [PATCH v2] drm/i915/audio: fix hdmi audio noise issue > >> > >> On Thu, 10 Nov 2016, libin.yang@intel.com wrote: > >> > From: Libin Yang <libin.yang@intel.com> > >> > > >> > Some monitors will have noise or even no sound after applying the > >> > patch 6014ac12. > >> > > >> > In patch 6014ac12, it will reset the cts value to 0 for HDMI. > >> > However, we need to disable Enable CTS or M Prog bit. This is the > >> > initial setting after HW reset. > >> > > >> > Fixes: 6014ac122ed0 ("drm/i915/audio: set proper N/M in modeset") > >> > Signed-off-by: Libin Yang <libin.yang@intel.com> > >> > --- > >> > drivers/gpu/drm/i915/intel_audio.c | 15 ++++++++++++--- > >> > 1 file changed, 12 insertions(+), 3 deletions(-) > >> > > >> > diff --git a/drivers/gpu/drm/i915/intel_audio.c > >> > b/drivers/gpu/drm/i915/intel_audio.c > >> > index 813fd74..a472d35 100644 > >> > --- a/drivers/gpu/drm/i915/intel_audio.c > >> > +++ b/drivers/gpu/drm/i915/intel_audio.c > >> > @@ -332,6 +332,13 @@ hsw_hdmi_audio_config_update(struct > intel_crtc > >> *intel_crtc, enum port port, > >> > int n; > >> > u32 tmp; > >> > > >> > + /* reset CTS value to 0 */ > >> > + tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe)); > >> > + tmp &= ~AUD_CONFIG_M_MASK; > >> > + tmp &= ~AUD_M_CTS_M_VALUE_INDEX; > >> > + tmp |= AUD_M_CTS_M_PROG_ENABLE; > >> > + I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp); > >> > + > >> > tmp = I915_READ(HSW_AUD_CFG(pipe)); > >> > tmp &= ~AUD_CONFIG_N_VALUE_INDEX; > >> > tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK; > >> > @@ -351,10 +358,12 @@ hsw_hdmi_audio_config_update(struct > >> > intel_crtc *intel_crtc, enum port port, > >> > > >> > I915_WRITE(HSW_AUD_CFG(pipe), tmp); > >> > > >> > + /* > >> > + * Let's disable "Enable CTS or M Prog bit" > >> > + * and let HW calculate the value > >> > + */ > >> > tmp = I915_READ(HSW_AUD_M_CTS_ENABLE(pipe)); > >> > - tmp &= ~AUD_CONFIG_M_MASK; > >> > - tmp &= ~AUD_M_CTS_M_VALUE_INDEX; > >> > - tmp |= AUD_M_CTS_M_PROG_ENABLE; > >> > + tmp &= ~AUD_M_CTS_M_PROG_ENABLE; > >> > I915_WRITE(HSW_AUD_M_CTS_ENABLE(pipe), tmp); > >> > >> You did not address my review comment on the earlier version: > >> > >> Is it necessary to do the HSW_AUD_M_CTS_ENABLE updates in two places? > >> Why do you both enable and disable AUD_M_CTS_M_PROG_ENABLE bit > here? > > > > Sorry, I missed your comments. > > > > The first doing the HSW_AUD_M_CTS_ENABLE is to reset the M value to 0. > > The second doing the HSW_AUD_M_CTS_ENABLE is to let HW calculate the > M value. > > > > Or we can just try to disable the HSW_AUD_M_CTS_ENABLE bit. What's > your opinion? > > I would have thought just doing the latter would be sufficient. Please test. I have done the test on 32KHz, 44.1KHz, 48KHz, 88KHz, it is OK. Regards, Libin > > BR, > Jani. > > > > > Regards, > > Libin > > > >> > >> BR, > >> Jani. > >> > >> > >> > } > >> > >> -- > >> Jani Nikula, Intel Open Source Technology Center > > -- > Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-11 8:46 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-10 5:14 [PATCH v2] drm/i915/audio: fix hdmi audio noise issue libin.yang 2016-11-10 5:47 ` ✓ Fi.CI.BAT: success for drm/i915/audio: fix hdmi audio noise issue (rev2) Patchwork 2016-11-10 10:37 ` [PATCH v2] drm/i915/audio: fix hdmi audio noise issue Jani Nikula 2016-11-11 2:14 ` Yang, Libin 2016-11-11 8:41 ` Jani Nikula 2016-11-11 8:46 ` Yang, Libin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).