From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org, "Lv,
Zhiyuan" <zhiyuan.lv@intel.com>,
igvt-g-dev@lists.01.org, Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PULL] GVT-g device model core
Date: Mon, 17 Oct 2016 17:06:27 +0300 [thread overview]
Message-ID: <87vawrrrx8.fsf@intel.com> (raw)
In-Reply-To: <20161017073045.GD20761@phenom.ffwll.local>
On Mon, 17 Oct 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> Ok applied, but a few things to keep in mind before your next pull
> request:
>
> - Dont rebase everything 5 seconds before sending out the pull request.
> That just invalidates all the testing you've done, so not a good idea.
> In general try to avoid rebases as much as possible, and only rebase to
> take out a truly embarassing mistake. And then only rebase up to the
> patch that needs a hotfix, not your entire tree.
CONFIG_DRM_I915_GVT=y
drivers/gpu/drm/i915/gvt/handlers.c: In function ‘render_mmio_to_ring_id’:
drivers/gpu/drm/i915/gvt/handlers.c:137:31: error: request for member ‘mmio_base’ in something not a structure or union
if (gvt->dev_priv->engine[i].mmio_base == reg)
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-17 14:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 10:30 [PULL] GVT-g device model core Zhenyu Wang
2016-10-17 7:30 ` Daniel Vetter
2016-10-17 7:33 ` Daniel Vetter
2016-10-17 7:45 ` Zhenyu Wang
2016-10-17 14:07 ` Daniel Vetter
2016-10-18 1:45 ` Zhenyu Wang
2016-10-17 14:06 ` Jani Nikula [this message]
2016-10-18 11:59 ` Jani Nikula
2016-10-19 1:52 ` Zhenyu Wang
2016-10-18 14:43 ` Chris Wilson
2016-10-19 7:50 ` Chris Wilson
2016-10-19 7:58 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vawrrrx8.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=igvt-g-dev@lists.01.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox