Re: [PULL] GVT-g device model core

Jani Nikula
2016-10-17T14:07:02Z

On Mon, 17 Oct 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> Ok applied, but a few things to keep in mind before your next pull
> request:
>
> - Dont rebase everything 5 seconds before sending out the pull request.
> That just invalidates all the testing you've done, so not a good idea.
> In general try to avoid rebases as much as possible, and only rebase to
> take out a truly embarassing mistake. And then only rebase up to the
> patch that needs a hotfix, not your entire tree.

CONFIG_DRM_I915_GVT=y

drivers/gpu/drm/i915/gvt/handlers.c: In function ‘render_mmio_to_ring_id’:
drivers/gpu/drm/i915/gvt/handlers.c:137:31: error: request for member ‘mmio_base’ in something not a structure or union
if (gvt->dev_priv->engine[i].mmio_base == reg)

BR,
Jani.

--
Jani Nikula, Intel Open Source Technology Center