Re: [PULL] GVT-g device model core

Zhenyu Wang
2016-10-19T01:56:20Z

[-- Attachment #1.1: Type: text/plain, Size: 1411 bytes --]

On 2016.10.18 14:59:14 +0300, Jani Nikula wrote:
> On Mon, 17 Oct 2016, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Mon, 17 Oct 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> >> Ok applied, but a few things to keep in mind before your next pull
> >> request:
> >>
> >> - Dont rebase everything 5 seconds before sending out the pull request.
> >> That just invalidates all the testing you've done, so not a good idea.
> >> In general try to avoid rebases as much as possible, and only rebase to
> >> take out a truly embarassing mistake. And then only rebase up to the
> >> patch that needs a hotfix, not your entire tree.
> >
> > CONFIG_DRM_I915_GVT=y
> >
> > drivers/gpu/drm/i915/gvt/handlers.c: In function ‘render_mmio_to_ring_id’:
> > drivers/gpu/drm/i915/gvt/handlers.c:137:31: error: request for member ‘mmio_base’ in something not a structure or union
> > if (gvt->dev_priv->engine[i].mmio_base == reg)
>
> This is now fixed, thanks, but there's still a load of sparse warnings
> coming from gvt. Please install sparse, and run e.g.
>
> $ make
> $ rm drivers/gpu/drm/i915/gvt/*.o
> $ make C=1
>
> Below is a list of current warnings.
>

yeah, sorry that we ignored sparse step, will address that in next pull request too.

thanks.

--
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]