From: Jani Nikula <jani.nikula@linux.intel.com>
To: Dave Gordon <david.s.gordon@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: prefer INTEL_GEN(dev_priv) to INTEL_INFO(dev)->gen
Date: Tue, 13 Sep 2016 12:10:48 +0300 [thread overview]
Message-ID: <87vay0tbaf.fsf@intel.com> (raw)
In-Reply-To: <114303c7-76bf-15be-211c-ac80443c0c38@intel.com>
On Sat, 10 Sep 2016, Dave Gordon <david.s.gordon@intel.com> wrote:
> Thanks, the other things I was thinking of fixing in the remaining files
> were generally things like
>
> if (INTEL_INFO(dev)->gen < 5 || IS_G33(dev))
Is that a real or a made up example? IS_G33() would be redundant. But
I'd like to see the semantic patch to fix that! ;)
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-13 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 21:37 [PATCH] drm/i915: prefer INTEL_GEN(dev_priv) to INTEL_INFO(dev)->gen Dave Gordon
2016-09-09 21:58 ` Chris Wilson
2016-09-09 22:43 ` Dave Gordon
2016-09-13 9:10 ` Jani Nikula [this message]
2016-09-14 12:32 ` Dave Gordon
2016-09-14 12:37 ` Dave Gordon
-- strict thread matches above, loose matches on Subject: below --
2016-06-10 17:35 Dave Gordon
2016-06-13 9:28 ` Tvrtko Ursulin
2016-06-13 14:59 ` Dave Gordon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vay0tbaf.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox