Fixing i915/opregion issues with firmware which lists more then 8 output devices

Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Nicolas Repentin]

[-- Attachment #1.1: Type: text/plain, Size: 261 bytes --]

Hello

I'm searching for a fix for thread 
http://www.spinics.net/lists/intel-gfx/msg79628.html

Does someone know how to ask the intel drm team to fix this issue?

Following kernel bug: https://bugzilla.kernel.org/show_bug.cgi?id=98931



Thanks,

-- 
Nicolas

[-- Attachment #1.2: Type: text/html, Size: 813 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Jani Nikula]

On Tue, 22 Mar 2016, Nicolas Repentin <nicolas@shivaserv.fr> wrote:
> I'm searching for a fix for thread 
> http://www.spinics.net/lists/intel-gfx/msg79628.html
>
> Does someone know how to ask the intel drm team to fix this issue?

You just have. ;)

Please try this patch series [1]. It's untested, but might
help. Feedback appreciated.

BR,
Jani.


[1] https://patchwork.freedesktop.org/series/4783/



-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Nicolas Repentin]

[-- Attachment #1.1: Type: text/plain, Size: 608 bytes --]

Thanks ;)

I'm sorry, but do you have a "howto" for doing this?

Not very familiar with patching things.

Nicolas

Le 23/03/2016 12:36, Jani Nikula a écrit :
> On Tue, 22 Mar 2016, Nicolas Repentin <nicolas@shivaserv.fr> wrote:
>> I'm searching for a fix for thread
>> http://www.spinics.net/lists/intel-gfx/msg79628.html
>>
>> Does someone know how to ask the intel drm team to fix this issue?
> You just have. ;)
>
> Please try this patch series [1]. It's untested, but might
> help. Feedback appreciated.
>
> BR,
> Jani.
>
>
> [1] https://patchwork.freedesktop.org/series/4783/
>

[-- Attachment #1.2: Type: text/html, Size: 1412 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Jani Nikula]

On Wed, 23 Mar 2016, Nicolas Repentin <nicolas@shivaserv.fr> wrote:
> Thanks ;)
>
> I'm sorry, but do you have a "howto" for doing this?
>
> Not very familiar with patching things.

This should get you started:

http://kernelnewbies.org/KernelBuild

HTH,
Jani.

>
> Nicolas
>
> Le 23/03/2016 12:36, Jani Nikula a écrit :
>> On Tue, 22 Mar 2016, Nicolas Repentin <nicolas@shivaserv.fr> wrote:
>>> I'm searching for a fix for thread
>>> http://www.spinics.net/lists/intel-gfx/msg79628.html
>>>
>>> Does someone know how to ask the intel drm team to fix this issue?
>> You just have. ;)
>>
>> Please try this patch series [1]. It's untested, but might
>> help. Feedback appreciated.
>>
>> BR,
>> Jani.
>>
>>
>> [1] https://patchwork.freedesktop.org/series/4783/
>>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Nicolas Repentin]

Hello

It seems this patch works on 4.4 kernel.

https://bugzilla.kernel.org/attachment.cgi?id=195071

Maybe we can have it directly in future releases?

:)

Regards,



Le 23/03/2016 12:36, Jani Nikula a écrit :
> On Tue, 22 Mar 2016, Nicolas Repentin <nicolas@shivaserv.fr> wrote:
>> I'm searching for a fix for thread
>> http://www.spinics.net/lists/intel-gfx/msg79628.html
>>
>> Does someone know how to ask the intel drm team to fix this issue?
> You just have. ;)
>
> Please try this patch series [1]. It's untested, but might
> help. Feedback appreciated.
>
> BR,
> Jani.
>
>
> [1] https://patchwork.freedesktop.org/series/4783/
>
>
>

-- 
Nicolas
<nicolas@shivaserv.fr>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Jani Nikula]

On Fri, 15 Apr 2016, Nicolas Repentin <nicolas@shivaserv.fr> wrote:
> Hello
>
> It seems this patch works on 4.4 kernel.
>
> https://bugzilla.kernel.org/attachment.cgi?id=195071
>
> Maybe we can have it directly in future releases?

Sorry, no.

Please try the patch series referred as [1] below and report back.

BR,
Jani.


>
> :)
>
> Regards,
>
>
>
> Le 23/03/2016 12:36, Jani Nikula a écrit :
>> On Tue, 22 Mar 2016, Nicolas Repentin <nicolas@shivaserv.fr> wrote:
>>> I'm searching for a fix for thread
>>> http://www.spinics.net/lists/intel-gfx/msg79628.html
>>>
>>> Does someone know how to ask the intel drm team to fix this issue?
>> You just have. ;)
>>
>> Please try this patch series [1]. It's untested, but might
>> help. Feedback appreciated.
>>
>> BR,
>> Jani.
>>
>>
>> [1] https://patchwork.freedesktop.org/series/4783/
>>
>>
>>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[tasev.stefanoska]

Hi Jani

Following the thread :
http://www.spinics.net/lists/intel-gfx/msg92832.html

I tried to build a kernel with the patch 
https://patchwork.freedesktop.org/series/4783/ but did not succeed.

What i did is: git clone git https://cgit.freedesktop.org/~jani/drm/
then i looked into the intel_opregion.c file but it doesn't seems that 
[v4] drm/i915/opregion: update cadl based on actually active outputs
[v4] drm/i915: make i915 the source of acpi device ids for _DOD
are included.

I tried to apply the patches manually, but after that, building the 
kernel fails with errors. What is the right way to test the patches?

Thanks,
Nikola
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[thermatk(EZN)]

[-- Attachment #1.1: Type: text/plain, Size: 399 bytes --]

Hello!
I have tried the patch https://patchwork.freedesktop.org/series/4783/ by
compiling manjaro kernel 4.6-rc4 with it, the brightness keys still don't
work on an Asus UX305FA.
FYI, applying the hacky https://bugzilla.kernel.org/attachment.cgi?id=195071
certainly makes them work.
If I can provide any further information that can be used to fix this, I'm
ready to help!
Sincerely,
Ruslan Boitsov

[-- Attachment #1.2: Type: text/html, Size: 649 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Ruslan Boitsov]

[-- Attachment #1.1: Type: text/plain, Size: 399 bytes --]

Hello!
I have tried the patch https://patchwork.freedesktop.org/series/4783/ by
compiling manjaro kernel 4.6-rc4 with it, the brightness keys still don't
work on an Asus UX305FA.
FYI, applying the hacky https://bugzilla.kernel.org/attachment.cgi?id=195071
certainly makes them work.
If I can provide any further information that can be used to fix this, I'm
ready to help!
Sincerely,
Ruslan Boitsov

[-- Attachment #1.2: Type: text/html, Size: 621 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Hans de Goede]

Hi,

As discussed in the past, the i915 opregion code does not do the
right thing wrt the CADL field when there are more then 8 outputs,
this is causing issues on many different types of Asus laptops.

This thread has details and a number of attempts to fix this:

https://lkml.org/lkml/2014/2/11/1032

This is impacting many users, here is an incomplete list of bug reports:

https://bugzilla.kernel.org/show_bug.cgi?id=70241
https://bugzilla.kernel.org/show_bug.cgi?id=88941
https://bugzilla.redhat.com/show_bug.cgi?id=1144866
https://bugzilla.redhat.com/show_bug.cgi?id=1277785

And I'm pretty sure that is just the tip of the iceberg, some users
have even analyzed their BIOS AML code and come up with an AML
hack in an attempt to fix this:

http://blog.yjwong.name/fixing-display-backlight-hotkeys-on-asus-n550jk/

It would be really great of someone from Intel could step up and start
working on a proper fix for this.

Regards,

Hans

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Jani Nikula]

On Thu, 05 Nov 2015, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> As discussed in the past, the i915 opregion code does not do the
> right thing wrt the CADL field when there are more then 8 outputs,
> this is causing issues on many different types of Asus laptops.
>
> This thread has details and a number of attempts to fix this:
>
> https://lkml.org/lkml/2014/2/11/1032
>
> This is impacting many users, here is an incomplete list of bug reports:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=70241
> https://bugzilla.kernel.org/show_bug.cgi?id=88941
> https://bugzilla.redhat.com/show_bug.cgi?id=1144866
> https://bugzilla.redhat.com/show_bug.cgi?id=1277785
>
> And I'm pretty sure that is just the tip of the iceberg, some users
> have even analyzed their BIOS AML code and come up with an AML
> hack in an attempt to fix this:
>
> http://blog.yjwong.name/fixing-display-backlight-hotkeys-on-asus-n550jk/
>
> It would be really great of someone from Intel could step up and start
> working on a proper fix for this.

Hans, thanks for bringing this up again.

IIUC this would require something along the lines of:

- Properly map acpi video bus children and DRM connectors in
  intel_didl_outputs(). This is likely the hardest part. Save the
  display ids in struct intel_connector.

- Replace intel_setup_cadls() with functions to add/remove display ids
  from opregion CADL.

- Call the above functions as part of the modeset sequence (either from
  intel_display.c or from the encoder hooks, whichever is best) to keep
  CADL up-to-date about active outputs. Here, getting DP MST right is
  probably the hard one.

If the mapping goes wrong, and some id that used to be in CADL with the
current code gets dropped, this may regress. That's the biggest risk,
really.

For the backlight/hotkey stuff, the minimal fix may be to keep the
stupid static initialization of the CADL in intel_setup_cadls() like we
have now, but ensuring the embedded displays are included in the list.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Hans de Goede]

Hi,

On 06-11-15 11:19, Jani Nikula wrote:
> On Thu, 05 Nov 2015, Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi,
>>
>> As discussed in the past, the i915 opregion code does not do the
>> right thing wrt the CADL field when there are more then 8 outputs,
>> this is causing issues on many different types of Asus laptops.
>>
>> This thread has details and a number of attempts to fix this:
>>
>> https://lkml.org/lkml/2014/2/11/1032
>>
>> This is impacting many users, here is an incomplete list of bug reports:
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=70241
>> https://bugzilla.kernel.org/show_bug.cgi?id=88941
>> https://bugzilla.redhat.com/show_bug.cgi?id=1144866
>> https://bugzilla.redhat.com/show_bug.cgi?id=1277785
>>
>> And I'm pretty sure that is just the tip of the iceberg, some users
>> have even analyzed their BIOS AML code and come up with an AML
>> hack in an attempt to fix this:
>>
>> http://blog.yjwong.name/fixing-display-backlight-hotkeys-on-asus-n550jk/
>>
>> It would be really great of someone from Intel could step up and start
>> working on a proper fix for this.
>
> Hans, thanks for bringing this up again.
>
> IIUC this would require something along the lines of:
>
> - Properly map acpi video bus children and DRM connectors in
>    intel_didl_outputs(). This is likely the hardest part. Save the
>    display ids in struct intel_connector.
>
> - Replace intel_setup_cadls() with functions to add/remove display ids
>    from opregion CADL.
>
> - Call the above functions as part of the modeset sequence (either from
>    intel_display.c or from the encoder hooks, whichever is best) to keep
>    CADL up-to-date about active outputs. Here, getting DP MST right is
>    probably the hard one.
>
> If the mapping goes wrong, and some id that used to be in CADL with the
> current code gets dropped, this may regress. That's the biggest risk,
> really.
>
> For the backlight/hotkey stuff, the minimal fix may be to keep the
> stupid static initialization of the CADL in intel_setup_cadls() like we
> have now, but ensuring the embedded displays are included in the list.

This is what Aaron's first attempt at fixing this more or less did:

https://lkml.org/lkml/2014/2/11/1032

Unless someone actually steps up to do a proper fix for this *now*,
maybe the i915 driver needs to incorporate a slightly revised / improved
version of that patch as a work around for now ?

Regards,

Hans
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Jani Nikula]

On Fri, 06 Nov 2015, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 06-11-15 11:19, Jani Nikula wrote:
>> On Thu, 05 Nov 2015, Hans de Goede <hdegoede@redhat.com> wrote:
>>> Hi,
>>>
>>> As discussed in the past, the i915 opregion code does not do the
>>> right thing wrt the CADL field when there are more then 8 outputs,
>>> this is causing issues on many different types of Asus laptops.
>>>
>>> This thread has details and a number of attempts to fix this:
>>>
>>> https://lkml.org/lkml/2014/2/11/1032
>>>
>>> This is impacting many users, here is an incomplete list of bug reports:
>>>
>>> https://bugzilla.kernel.org/show_bug.cgi?id=70241
>>> https://bugzilla.kernel.org/show_bug.cgi?id=88941
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1144866
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1277785
>>>
>>> And I'm pretty sure that is just the tip of the iceberg, some users
>>> have even analyzed their BIOS AML code and come up with an AML
>>> hack in an attempt to fix this:
>>>
>>> http://blog.yjwong.name/fixing-display-backlight-hotkeys-on-asus-n550jk/
>>>
>>> It would be really great of someone from Intel could step up and start
>>> working on a proper fix for this.
>>
>> Hans, thanks for bringing this up again.
>>
>> IIUC this would require something along the lines of:
>>
>> - Properly map acpi video bus children and DRM connectors in
>>    intel_didl_outputs(). This is likely the hardest part. Save the
>>    display ids in struct intel_connector.
>>
>> - Replace intel_setup_cadls() with functions to add/remove display ids
>>    from opregion CADL.
>>
>> - Call the above functions as part of the modeset sequence (either from
>>    intel_display.c or from the encoder hooks, whichever is best) to keep
>>    CADL up-to-date about active outputs. Here, getting DP MST right is
>>    probably the hard one.
>>
>> If the mapping goes wrong, and some id that used to be in CADL with the
>> current code gets dropped, this may regress. That's the biggest risk,
>> really.
>>
>> For the backlight/hotkey stuff, the minimal fix may be to keep the
>> stupid static initialization of the CADL in intel_setup_cadls() like we
>> have now, but ensuring the embedded displays are included in the list.
>
> This is what Aaron's first attempt at fixing this more or less did:
>
> https://lkml.org/lkml/2014/2/11/1032
>
> Unless someone actually steps up to do a proper fix for this *now*,
> maybe the i915 driver needs to incorporate a slightly revised / improved
> version of that patch as a work around for now ?

I dug into this a bit. (Well, more than just a bit. Friday night, doing
ACPI dumps and deciphering AML. What was I thinking?)

It seems that part of the problem is caused by

commit 3143751ff51a163b77f7efd389043e038f3e008e
Author: Zhang Rui <rui.zhang@intel.com>
Date:   Mon Mar 29 15:12:16 2010 +0800

    drm/i915: set DIDL using the ACPI video output device _ADR method return.

which apparently caters for buggy bioses. The relevant bug report is
[1].

IIUC, the graphics driver is supposed to set up the IDs (so that would
take care of the "hardest part" above). On a couple of modern machines
that I checked, the above commit causes i915 to ask the AML code using
_ADR, which looks at DIDL, which is what we're trying to initialize so
it's zero, and then AML pulls IDs out of thin air, also for devices that
don't really exist because AML doesn't know.

I'll probably submit a patch doing a revert of the above, if only to
test. But we'll still have to figure out something for the regressions
it probably causes for the buggy machines. *sigh*.

This just reinforces my opinion that adding hacks to fix some broken
machines is not worth it. The no regressions rule turns the hacks into a
nightmare when it breaks good hardware.


BR,
Jani.


[1] https://bugzilla.kernel.org/show_bug.cgi?id=15054


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Jani Nikula]

On Fri, 06 Nov 2015, Hans de Goede <hdegoede@redhat.com> wrote:
> On 06-11-15 11:19, Jani Nikula wrote:
>> On Thu, 05 Nov 2015, Hans de Goede <hdegoede@redhat.com> wrote:
>>> Hi,
>>>
>>> As discussed in the past, the i915 opregion code does not do the
>>> right thing wrt the CADL field when there are more then 8 outputs,
>>> this is causing issues on many different types of Asus laptops.
>>>
>>> This thread has details and a number of attempts to fix this:
>>>
>>> https://lkml.org/lkml/2014/2/11/1032
>>>
>>> This is impacting many users, here is an incomplete list of bug reports:
>>>
>>> https://bugzilla.kernel.org/show_bug.cgi?id=70241
>>> https://bugzilla.kernel.org/show_bug.cgi?id=88941
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1144866
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1277785
>>>
>>> And I'm pretty sure that is just the tip of the iceberg, some users
>>> have even analyzed their BIOS AML code and come up with an AML
>>> hack in an attempt to fix this:
>>>
>>> http://blog.yjwong.name/fixing-display-backlight-hotkeys-on-asus-n550jk/
>>>
>>> It would be really great of someone from Intel could step up and start
>>> working on a proper fix for this.
>>
>> Hans, thanks for bringing this up again.
>>
>> IIUC this would require something along the lines of:
>>
>> - Properly map acpi video bus children and DRM connectors in
>>    intel_didl_outputs(). This is likely the hardest part. Save the
>>    display ids in struct intel_connector.
>>
>> - Replace intel_setup_cadls() with functions to add/remove display ids
>>    from opregion CADL.
>>
>> - Call the above functions as part of the modeset sequence (either from
>>    intel_display.c or from the encoder hooks, whichever is best) to keep
>>    CADL up-to-date about active outputs. Here, getting DP MST right is
>>    probably the hard one.
>>
>> If the mapping goes wrong, and some id that used to be in CADL with the
>> current code gets dropped, this may regress. That's the biggest risk,
>> really.
>>
>> For the backlight/hotkey stuff, the minimal fix may be to keep the
>> stupid static initialization of the CADL in intel_setup_cadls() like we
>> have now, but ensuring the embedded displays are included in the list.
>
> This is what Aaron's first attempt at fixing this more or less did:
>
> https://lkml.org/lkml/2014/2/11/1032
>
> Unless someone actually steps up to do a proper fix for this *now*,
> maybe the i915 driver needs to incorporate a slightly revised / improved
> version of that patch as a work around for now ?

"now" took a long time, but there's this series to try now:
https://patchwork.freedesktop.org/series/4783/

BR,
Jani.



-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fixing i915/opregion issues with firmware which lists more then 8 output devices

[Hans de Goede]

Hi Jani,

On 23-03-16 12:48, Jani Nikula wrote:
> On Fri, 06 Nov 2015, Hans de Goede <hdegoede@redhat.com> wrote:
>> On 06-11-15 11:19, Jani Nikula wrote:
>>> On Thu, 05 Nov 2015, Hans de Goede <hdegoede@redhat.com> wrote:
>>>> Hi,
>>>>
>>>> As discussed in the past, the i915 opregion code does not do the
>>>> right thing wrt the CADL field when there are more then 8 outputs,
>>>> this is causing issues on many different types of Asus laptops.
>>>>
>>>> This thread has details and a number of attempts to fix this:
>>>>
>>>> https://lkml.org/lkml/2014/2/11/1032
>>>>
>>>> This is impacting many users, here is an incomplete list of bug reports:
>>>>
>>>> https://bugzilla.kernel.org/show_bug.cgi?id=70241
>>>> https://bugzilla.kernel.org/show_bug.cgi?id=88941
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1144866
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1277785
>>>>
>>>> And I'm pretty sure that is just the tip of the iceberg, some users
>>>> have even analyzed their BIOS AML code and come up with an AML
>>>> hack in an attempt to fix this:
>>>>
>>>> http://blog.yjwong.name/fixing-display-backlight-hotkeys-on-asus-n550jk/
>>>>
>>>> It would be really great of someone from Intel could step up and start
>>>> working on a proper fix for this.
>>>
>>> Hans, thanks for bringing this up again.
>>>
>>> IIUC this would require something along the lines of:
>>>
>>> - Properly map acpi video bus children and DRM connectors in
>>>     intel_didl_outputs(). This is likely the hardest part. Save the
>>>     display ids in struct intel_connector.
>>>
>>> - Replace intel_setup_cadls() with functions to add/remove display ids
>>>     from opregion CADL.
>>>
>>> - Call the above functions as part of the modeset sequence (either from
>>>     intel_display.c or from the encoder hooks, whichever is best) to keep
>>>     CADL up-to-date about active outputs. Here, getting DP MST right is
>>>     probably the hard one.
>>>
>>> If the mapping goes wrong, and some id that used to be in CADL with the
>>> current code gets dropped, this may regress. That's the biggest risk,
>>> really.
>>>
>>> For the backlight/hotkey stuff, the minimal fix may be to keep the
>>> stupid static initialization of the CADL in intel_setup_cadls() like we
>>> have now, but ensuring the embedded displays are included in the list.
>>
>> This is what Aaron's first attempt at fixing this more or less did:
>>
>> https://lkml.org/lkml/2014/2/11/1032
>>
>> Unless someone actually steps up to do a proper fix for this *now*,
>> maybe the i915 driver needs to incorporate a slightly revised / improved
>> version of that patch as a work around for now ?
>
> "now" took a long time, but there's this series to try now:
> https://patchwork.freedesktop.org/series/4783/

Cool. Note I do not have hardware to test this.

I think it would be good if you add a link to that series to all the relevant
bugreports, quoting from my original mail that would be the following bug
reports:

https://bugzilla.kernel.org/show_bug.cgi?id=70241
https://bugzilla.kernel.org/show_bug.cgi?id=88941
https://bugzilla.redhat.com/show_bug.cgi?id=1144866
https://bugzilla.redhat.com/show_bug.cgi?id=1277785

Regards,

Hans
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx