intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Shashank Sharma <shashank.sharma@intel.com>, rodrigo.vivi@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/5] drm: add picture aspect ratio flags
Date: Thu, 24 Mar 2016 14:55:45 +0200	[thread overview]
Message-ID: <87vb4c3ui6.fsf@intel.com> (raw)
In-Reply-To: <1458819054-32293-2-git-send-email-shashank.sharma@intel.com>

On Thu, 24 Mar 2016, Shashank Sharma <shashank.sharma@intel.com> wrote:
> This patch adds drm flag bits for aspect ratio information
>
> Currently drm flag bits don't have field for mode's picture
> aspect ratio. This field will help the driver to pick mode with
> right aspect ratio, and help in setting right VIC field in avi
> infoframes.
>
> Signed-off-by: Shashank Sharma <shashank.sharma@intel.com>
> ---
>  include/uapi/drm/drm_mode.h | 18 +++++++++++++-----

Please use scripts/get_maintainer.pl on the patch to figure out who it
should be sent to. This file is not maintained by us, so we can't just
merge it.

For example:

$ scripts/get_maintainer.pl 0001-drm-add-picture-aspect-ratio-flags.patch 
David Airlie <airlied@linux.ie> (maintainer:DRM DRIVERS)
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS)
linux-kernel@vger.kernel.org (open list)

Of course, since you ultimately aim for a change in drm/i915, you should
also Cc: intel-gfx.

BR,
Jani.


>  1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index 50adb46..3389bd1 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -73,6 +73,19 @@
>  #define  DRM_MODE_FLAG_3D_TOP_AND_BOTTOM	(7<<14)
>  #define  DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF	(8<<14)
>  
> +/* Picture aspect ratio options */
> +#define DRM_MODE_PICTURE_ASPECT_NONE		0
> +#define DRM_MODE_PICTURE_ASPECT_4_3		1
> +#define DRM_MODE_PICTURE_ASPECT_16_9		2
> +
> +/* Aspect ratio flag bitmask (4 bits 21:19) */
> +#define	 DRM_MODE_FLAG_PARMASK		(0x0F<<19)
> +#define  DRM_MODE_FLAG_PARNONE \
> +		(DRM_MODE_PICTURE_ASPECT_NONE << 19)
> +#define  DRM_MODE_FLAG_PAR4_3 \
> +		(DRM_MODE_PICTURE_ASPECT_4_3 << 19)
> +#define  DRM_MODE_FLAG_PAR16_9 \
> +		(DRM_MODE_PICTURE_ASPECT_16_9 << 19)
>  
>  /* DPMS flags */
>  /* bit compatible with the xorg definitions. */
> @@ -88,11 +101,6 @@
>  #define DRM_MODE_SCALE_CENTER		2 /* Centered, no scaling */
>  #define DRM_MODE_SCALE_ASPECT		3 /* Full screen, preserve aspect */
>  
> -/* Picture aspect ratio options */
> -#define DRM_MODE_PICTURE_ASPECT_NONE	0
> -#define DRM_MODE_PICTURE_ASPECT_4_3	1
> -#define DRM_MODE_PICTURE_ASPECT_16_9	2
> -
>  /* Dithering mode options */
>  #define DRM_MODE_DITHERING_OFF	0
>  #define DRM_MODE_DITHERING_ON	1

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-03-24 12:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 11:30 [PATCH v2 0/5] Add aspect ratio parsing Shashank Sharma
2016-03-24 11:30 ` [PATCH v2 1/5] drm: add picture aspect ratio flags Shashank Sharma
2016-03-24 12:55   ` Jani Nikula [this message]
2016-03-24 12:57     ` Sharma, Shashank
2016-03-24 16:39       ` Vivi, Rodrigo
2016-03-24 11:30 ` [PATCH v2 2/5] drm: Add aspect ratio parsing in DRM layer Shashank Sharma
2016-03-24 11:30 ` [PATCH v2 3/5] video: Add new aspect ratios for HDMI 2.0 Shashank Sharma
2016-03-24 11:30 ` [PATCH v2 4/5] drm: Add flags for new aspect ratios Shashank Sharma
2016-03-24 11:30 ` [PATCH v2 5/5] drm/i915: Add support " Shashank Sharma
2016-03-29 11:39   ` Daniel Vetter
2016-03-24 12:34 ` ✗ Fi.CI.BAT: failure for Add aspect ratio parsing (rev2) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2015-12-17 13:42 [PATCH v2 0/5] Add aspect ratio parsing Shashank Sharma
2015-12-17 13:42 ` [PATCH v2 1/5] drm: add picture aspect ratio flags Shashank Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb4c3ui6.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=shashank.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).