public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/bxt: add missing DSI power domain to power well 1
@ 2016-03-08 19:00 Jani Nikula
  2016-03-08 19:21 ` Ville Syrjälä
  2016-03-09  7:32 ` ✗ Fi.CI.BAT: failure for " Patchwork
  0 siblings, 2 replies; 4+ messages in thread
From: Jani Nikula @ 2016-03-08 19:00 UTC (permalink / raw)
  To: intel-gfx; +Cc: m.deepak

The DSI power domain was missing from BXT power well 1 definitions,
failing to get the power well for DSI transcoders. As pipe A is in the
same power well as DSI transcoders, the problem should only occur with
pipes B and C.

Cc: Ramalingam C <ramalingam.c@intel.com>
Cc: Deepak M <m.deepak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

---

This should superseed [1], but a change will be required in
haswell_get_pipe_config() or [2] to check the DSI power domain.

[1] http://patchwork.freedesktop.org/patch/msgid/1456239619-14808-1-git-send-email-ramalingam.c@intel.com
[2] http://patchwork.freedesktop.org/patch/msgid/1456771760-18823-1-git-send-email-ramalingam.c@intel.com
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 5adf4b337de3..2e88a5e06884 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -421,6 +421,7 @@ static void hsw_set_power_well(struct drm_i915_private *dev_priv,
 	BIT(POWER_DOMAIN_TRANSCODER_EDP) |		\
 	BIT(POWER_DOMAIN_PIPE_A_PANEL_FITTER) |		\
 	BIT(POWER_DOMAIN_PORT_DDI_A_LANES) |		\
+	BIT(POWER_DOMAIN_PORT_DSI) |			\
 	BIT(POWER_DOMAIN_AUX_A) |			\
 	BIT(POWER_DOMAIN_PLLS) |			\
 	BIT(POWER_DOMAIN_INIT))
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/bxt: add missing DSI power domain to power well 1
  2016-03-08 19:00 [PATCH] drm/i915/bxt: add missing DSI power domain to power well 1 Jani Nikula
@ 2016-03-08 19:21 ` Ville Syrjälä
  2016-03-09  8:03   ` Jani Nikula
  2016-03-09  7:32 ` ✗ Fi.CI.BAT: failure for " Patchwork
  1 sibling, 1 reply; 4+ messages in thread
From: Ville Syrjälä @ 2016-03-08 19:21 UTC (permalink / raw)
  To: Jani Nikula; +Cc: m.deepak, intel-gfx

On Tue, Mar 08, 2016 at 09:00:56PM +0200, Jani Nikula wrote:
> The DSI power domain was missing from BXT power well 1 definitions,
> failing to get the power well for DSI transcoders. As pipe A is in the
> same power well as DSI transcoders, the problem should only occur with
> pipes B and C.
> 
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Deepak M <m.deepak@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> 
> ---
> 
> This should superseed [1], but a change will be required in
> haswell_get_pipe_config() or [2] to check the DSI power domain.
> 
> [1] http://patchwork.freedesktop.org/patch/msgid/1456239619-14808-1-git-send-email-ramalingam.c@intel.com
> [2] http://patchwork.freedesktop.org/patch/msgid/1456771760-18823-1-git-send-email-ramalingam.c@intel.com
> ---
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 5adf4b337de3..2e88a5e06884 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -421,6 +421,7 @@ static void hsw_set_power_well(struct drm_i915_private *dev_priv,
>  	BIT(POWER_DOMAIN_TRANSCODER_EDP) |		\
>  	BIT(POWER_DOMAIN_PIPE_A_PANEL_FITTER) |		\
>  	BIT(POWER_DOMAIN_PORT_DDI_A_LANES) |		\
> +	BIT(POWER_DOMAIN_PORT_DSI) |			\

This is basically a nop since pw1 is under dmc control. But given that
we still have this stuff defined here, it's clearly correct to include
DSI here.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  	BIT(POWER_DOMAIN_AUX_A) |			\
>  	BIT(POWER_DOMAIN_PLLS) |			\
>  	BIT(POWER_DOMAIN_INIT))
> -- 
> 2.1.4

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/bxt: add missing DSI power domain to power well 1
  2016-03-08 19:00 [PATCH] drm/i915/bxt: add missing DSI power domain to power well 1 Jani Nikula
  2016-03-08 19:21 ` Ville Syrjälä
@ 2016-03-09  7:32 ` Patchwork
  1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-03-09  7:32 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/bxt: add missing DSI power domain to power well 1
URL   : https://patchwork.freedesktop.org/series/4223/
State : failure

== Summary ==

Series 4223v1 drm/i915/bxt: add missing DSI power domain to power well 1
http://patchwork.freedesktop.org/api/1.0/series/4223/revisions/1/mbox/

Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                dmesg-warn -> PASS       (bdw-ultra)
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> FAIL       (hsw-brixbox)
Test kms_force_connector_basic:
        Subgroup force-edid:
                pass       -> SKIP       (ilk-hp8440p)
Test pm_rpm:
        Subgroup basic-rte:
                dmesg-warn -> PASS       (bsw-nuc-2)

bdw-nuci7        total:186  pass:174  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:186  pass:167  dwarn:0   dfail:0   fail:0   skip:19 
bsw-nuc-2        total:186  pass:151  dwarn:0   dfail:0   fail:0   skip:35 
byt-nuc          total:186  pass:154  dwarn:0   dfail:0   fail:0   skip:32 
hsw-brixbox      total:186  pass:165  dwarn:0   dfail:0   fail:1   skip:20 
ilk-hp8440p      total:186  pass:126  dwarn:0   dfail:0   fail:0   skip:60 
ivb-t430s        total:186  pass:164  dwarn:0   dfail:0   fail:0   skip:22 
skl-i5k-2        total:186  pass:165  dwarn:0   dfail:0   fail:0   skip:21 
skl-i7k-2        total:186  pass:165  dwarn:0   dfail:0   fail:0   skip:21 
snb-dellxps      total:186  pass:155  dwarn:1   dfail:0   fail:0   skip:30 

Results at /archive/results/CI_IGT_test/Patchwork_1544/

b519bbd9633eca6bc8e8e80588b48bcee447c330 drm-intel-nightly: 2016y-03m-08d-13h-00m-35s UTC integration manifest
5e8ff1d78ce62335b2709b3adec92015291b6ed6 drm/i915/bxt: add missing DSI power domain to power well 1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/bxt: add missing DSI power domain to power well 1
  2016-03-08 19:21 ` Ville Syrjälä
@ 2016-03-09  8:03   ` Jani Nikula
  0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-03-09  8:03 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: m.deepak, intel-gfx

On Tue, 08 Mar 2016, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Mar 08, 2016 at 09:00:56PM +0200, Jani Nikula wrote:
>> The DSI power domain was missing from BXT power well 1 definitions,
>> failing to get the power well for DSI transcoders. As pipe A is in the
>> same power well as DSI transcoders, the problem should only occur with
>> pipes B and C.
>> 
>> Cc: Ramalingam C <ramalingam.c@intel.com>
>> Cc: Deepak M <m.deepak@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> 
>> ---
>> 
>> This should superseed [1], but a change will be required in
>> haswell_get_pipe_config() or [2] to check the DSI power domain.
>> 
>> [1] http://patchwork.freedesktop.org/patch/msgid/1456239619-14808-1-git-send-email-ramalingam.c@intel.com
>> [2] http://patchwork.freedesktop.org/patch/msgid/1456771760-18823-1-git-send-email-ramalingam.c@intel.com
>> ---
>>  drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
>> index 5adf4b337de3..2e88a5e06884 100644
>> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
>> @@ -421,6 +421,7 @@ static void hsw_set_power_well(struct drm_i915_private *dev_priv,
>>  	BIT(POWER_DOMAIN_TRANSCODER_EDP) |		\
>>  	BIT(POWER_DOMAIN_PIPE_A_PANEL_FITTER) |		\
>>  	BIT(POWER_DOMAIN_PORT_DDI_A_LANES) |		\
>> +	BIT(POWER_DOMAIN_PORT_DSI) |			\
>
> This is basically a nop since pw1 is under dmc control. But given that
> we still have this stuff defined here, it's clearly correct to include
> DSI here.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Pushed to drm-intel-next-queued, thanks for the review.

None of the CI fails have anything to do with this.

BR,
Jani.


>
>>  	BIT(POWER_DOMAIN_AUX_A) |			\
>>  	BIT(POWER_DOMAIN_PLLS) |			\
>>  	BIT(POWER_DOMAIN_INIT))
>> -- 
>> 2.1.4

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-09  8:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-08 19:00 [PATCH] drm/i915/bxt: add missing DSI power domain to power well 1 Jani Nikula
2016-03-08 19:21 ` Ville Syrjälä
2016-03-09  8:03   ` Jani Nikula
2016-03-09  7:32 ` ✗ Fi.CI.BAT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox