From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [SKL-DMC-BUGFIX 1/5] drm/i915/gen9: Removed byte swapping for csr firmware Date: Fri, 11 Sep 2015 18:29:19 +0300 Message-ID: <87vbbhx9dc.fsf@gaia.fi.intel.com> References: <1438619136-18268-1-git-send-email-animesh.manna@intel.com> <1438619136-18268-2-git-send-email-animesh.manna@intel.com> <55C053DC.3080303@intel.com> <20150805090150.GN17734@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E92206E48B for ; Fri, 11 Sep 2015 08:29:31 -0700 (PDT) In-Reply-To: <20150805090150.GN17734@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Animesh Manna Cc: "Vetter, Daniel" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org RGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cml0ZXM6Cgo+IE9uIFR1ZSwgQXVnIDA0 LCAyMDE1IGF0IDExOjI1OjQwQU0gKzA1MzAsIEFuaW1lc2ggTWFubmEgd3JvdGU6Cj4+IAo+PiAK Pj4gT24gOC80LzIwMTUgOToxNiBBTSwgTmFnYXJhanUsIFZhdGhzYWxhIHdyb3RlOgo+PiA+IlRo aXMgcGF0Y2ggY29udGFpbnMgdGhlIGNoYW5nZXMgdG8gcmVtb3ZlIHRoZSBieXRlIHN3YXBwaW5n IGxvZ2ljIGludHJvZHVjZWQgd2l0aCBvbGQgZG1jIGZpcm13YXJlLiIKPj4gPldoaWNoIHZlcnNp b24gb2YgRE1DIG5lZWQgcmV2ZXJzYWwgIGxvZ2ljPyAgQXRsZWFzdCAsIDQsMS4xNiwxLjE4IGZv bGxvdyB0aGUgc2FtZSBmb3JtYXQuCj4+IAo+PiBQYWNrYWdpbmcgb2YgZmlybXdhcmUgYmluYXJ5 IGNvbXBsZXRlbHkgY2hhbmdlZCBhZnRlciBhcGkgdmVyc2lvbiAxLjAsIHNvIGJ5IG9sZCBmaXJt d2FyZSBJIHdhbnQgdG8gbWVhbgo+PiB0aGUgaW5pdGlhbCB2ZXJzaW9uIGJlZm9yZSBkbWMgMS4w Lgo+Cj4gVGhpcyBraW5kIG9mIGluZm9ybWF0aW9uIHJlYWxseSBtdXN0IGJlIGluY2x1ZGVkIGlu IHRoZSBjb21taXQgbWVzc2FnZS4KPiBWZXJ5IGxpa2VseSBzb21lb25lIHdpdGggb2xkIGZpcm13 YXJlIHdpbGwgYmlzZWN0IHRvIHRoaXMgY29tbWl0LCBhbmQgaWYKPiB5b3UgZG9uJ3QgaW5jbHVk ZSB0aGF0IHBlb3BsZSBuZWVkIGxhdGVzdCBkbWMgZmlybXdhcmUgdGhlcmUgd2lsbCBiZQo+IGNv bmZ1c2lvbi4KPgo+IENvbW1pdCBtZXNzYWdlIF9tdXN0XyBiZSBjb21wbGV0ZSBhbmQgY29udGFp biBldmVyeXRoaW5nIHRoYXQgd2FzCj4gZGlzY3Vzc2VkIHdoaWxlIHJldmlld2luZyBhbmQgZGV2 ZWxvcGluZyBhIHBhdGNoLgo+Cj4gSSBhZGRlZCBhIG5vdGUgd2hpbGUgbWVyZ2luZyB0aGUgcGF0 Y2guCj4gLURhbmllbAo+CgpIaSwKClRoZXJlIGlzIHByb2JsZW0gd2l0aCBnZW1fZXhlY19ub3Ag dGhyb3dpbmcgZ3B1IGhhbmcgd2l0aCBHUFUgSEFORzoKZWNvZGUgOTowOjB4ZmZmZmZmZmUgb24g c29tZSBza2xzLiBMb29rcyBsaWtlIGZhc3RlciBvbmVzIGFyZQptb3JlIHN1c3BlY3RpYmxlLgoK TXkgYmlzZWN0IHBvaW50ZWQgdG8gdGhpcyBjb21taXQuIEFzIHRoaXMgbG9va3MgbGlrZSBjb21t aXQKdG8gZml4IHRoZSBsb2FkaW5nLCBvbmUgY291bGQgYXNzdW1lIHRoYXQgYXQgdGhpcyBwb2lu dCB0aGUgZmlybXdhcmUKc3RhcnRlZCB0byBhY3R1YWxseSBkbyBzb21ldGhpbmcuCgpTbyBteSBm YWlsdXJlIGh5cG90aGVzaXMgaXMgdGhhdCBvdXIgZHJpdmVyIHJ1bnRpbWUgcG93ZXIgd2VsbApi b29ra2VlcGluZyBhbmQgaGFuZG92ZXIgdG8gZG1jIGlzIHJhY3kuIExvdHMgb2Ygc3BlY3VsYXRp b24gaGVyZSBidXQKaSBzdXNwZWN0IHRoYXQgZHVyaW5nIGluaXRpYWxpemF0aW9uLCB3aGVuIHRo ZSBncHUgaXMgYnVzeSB3aXRoIHRoZQp3b3JrYXJvdW5kcyBhbmQgbnVsbCBzdGF0ZSBiYXRjaCwg aGFuZG92ZXIgdG8gZG1jIGhhcHBlbnMKYW5kIHNvbWV0aGluZyBiYWQgd2l0aCBpdCwgbGlrZSBy ZW5kZXIgc2lkZSBwb3dlciB0b2dnbGVzCndoaWxlIHRoZSBkbWMgaW5pdGlhbGl6ZXM/CgpJIGhh dmVuJ3QgeWV0IHRlc3RlZCB0aGUgcmVkZXNpZ24gc2VyaWVzIGZvciBjdXJlL2NsdWUsIGJ1dCBj aGFuZ2luZwp0aGUgZmlybXdhcmUgZnJvbSAxLjE5IHRvIDEuMjEgbWFrZXMgaXQgdmVyeSBoYXJk IHRvIHJlcHJvZHVjZQp0aGUgaXNzdWUuCgpPbiBhIHJlbGF0ZWQgbm90ZSwgd2UgbmVlZCB0aGUg ZmlybXdhcmUgdmVyc2lvbiB0byBiZSBwYXJ0IG9mCmVycm9yIHN0YXRlLiBBbHNvIHRoZSBkcml2 ZXIgY291bGQgd2FybiBpZiBub3QtbmV3LWVub3VnaCBmaXJtd2FyZQppcyBmb3VuZCwgdG8gYXRs ZWFzdCBwdXNoIHRoZSB1bmx1Y2t5IGJpc2VjdGVyIHRvIGEgcmlnaHQKZGlyZWN0aW9uLgoKLSBN aWthCgo+PiAKPj4gPgo+PiA+LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPj4gPkZyb206IE1h bm5hLCBBbmltZXNoCj4+ID5TZW50OiBNb25kYXksIEF1Z3VzdCAzLCAyMDE1IDk6NTYgUE0KPj4g PlRvOiBpbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+ID5DYzogTWFubmEsIEFuaW1l c2g7IFZldHRlciwgRGFuaWVsOyBMZXNwaWF1LCBEYW1pZW47IERlYWssIEltcmU7IEthbWF0aCwg U3VuaWw7IE5hZ2FyYWp1LCBWYXRoc2FsYQo+PiA+U3ViamVjdDogW1NLTC1ETUMtQlVHRklYIDEv NV0gZHJtL2k5MTUvZ2VuOTogUmVtb3ZlZCBieXRlIHN3YXBwaW5nIGZvciBjc3IgZmlybXdhcmUK Pj4gPgo+PiA+VGhpcyBwYXRjaCBjb250YWlucyB0aGUgY2hhbmdlcyB0byByZW1vdmUgdGhlIGJ5 dGUgc3dhcHBpbmcgbG9naWMgaW50cm9kdWNlZCB3aXRoIG9sZCBkbWMgZmlybXdhcmUuCj4+ID5X aGlsZSBkZWJ1Z2dpbmcgUEMxMCBlbnRyeSBpc3N1ZSBmb3Igc2t5bGFrZSBmb3VuZCB3aXRoIGxh dGVzdCBkbWMgZmlybXdhcmUgdmVyc2lvbiAxLjE4IHdpdGhvdXQgYnl0ZSBzd2FwcGluZyBkbWMg aXMgd29ya2luZyBmaW5lIGFuZCBhYmxlIHRvIGVudGVyIFBDMTAuCj4+ID4KPj4gPnYxOiBJbml0 aWFsIHZlcnNpb24uCj4+ID4KPj4gPnYyOiBDb3JyZWN0ZWQgZmlybXdhcmUgc2l6ZSBkdXJpbmcg bWVtY3B5KCkuIChTdWdnZXN0ZWQgYnkgU3VuaWwpCj4+ID4KPj4gPkNjOiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPj4gPkNjOiBEYW1pZW4gTGVzcGlhdSA8ZGFtaWVu Lmxlc3BpYXVAaW50ZWwuY29tPgo+PiA+Q2M6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNv bT4KPj4gPkNjOiBTdW5pbCBLYW1hdGggPHN1bmlsLmthbWF0aEBpbnRlbC5jb20+Cj4+ID5TaWdu ZWQtb2ZmLWJ5OiBBbmltZXNoIE1hbm5hIDxhbmltZXNoLm1hbm5hQGludGVsLmNvbT4KPj4gPlNp Z25lZC1vZmYtYnk6IFZhdGhzYWxhIE5hZ2FyYWp1IDx2YXRoc2FsYS5uYWdhcmFqdUBpbnRlbC5j b20+Cj4+ID4tLS0KPj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgfCAgMiAr LSAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3NyLmMgfCAxNiArKysrLS0tLS0tLS0tLS0t Cj4+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkK Pj4gPgo+PiA+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGluZGV4IGI5NGFkYTkuLjlkMGVlNTggMTAw NjQ0Cj4+ID4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+ID4rKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+ID5AQCAtNzQyLDcgKzc0Miw3IEBAIGVu dW0gY3NyX3N0YXRlIHsKPj4gPiAgc3RydWN0IGludGVsX2NzciB7Cj4+ID4gIAljb25zdCBjaGFy ICpmd19wYXRoOwo+PiA+LQlfX2JlMzIgKmRtY19wYXlsb2FkOwo+PiA+Kwl1aW50MzJfdCAqZG1j X3BheWxvYWQ7Cj4+ID4gIAl1aW50MzJfdCBkbWNfZndfc2l6ZTsKPj4gPiAgCXVpbnQzMl90IG1t aW9fY291bnQ7Cj4+ID4gIAl1aW50MzJfdCBtbWlvYWRkcls4XTsKPj4gPmRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Nzci5jCj4+ID5pbmRleCA2ZDhhN2JmLi5iYTFhZTAzIDEwMDY0NAo+PiA+LS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3NyLmMKPj4gPisrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Nzci5jCj4+ID5AQCAtMjQ0LDcgKzI0NCw3IEBAIHZvaWQgaW50ZWxfY3NyX2xv YWRfc3RhdHVzX3NldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsICB2b2lkIGlu dGVsX2Nzcl9sb2FkX3Byb2dyYW0oc3RydWN0IGRybV9kZXZpY2UgKmRldikgIHsKPj4gPiAgCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4+ID4t CV9fYmUzMiAqcGF5bG9hZCA9IGRldl9wcml2LT5jc3IuZG1jX3BheWxvYWQ7Cj4+ID4rCXUzMiAq cGF5bG9hZCA9IGRldl9wcml2LT5jc3IuZG1jX3BheWxvYWQ7Cj4+ID4gIAl1aW50MzJfdCBpLCBm d19zaXplOwo+PiA+ICAJaWYgKCFJU19HRU45KGRldikpIHsKPj4gPkBAIC0yNTYsNyArMjU2LDcg QEAgdm9pZCBpbnRlbF9jc3JfbG9hZF9wcm9ncmFtKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ ID4gIAlmd19zaXplID0gZGV2X3ByaXYtPmNzci5kbWNfZndfc2l6ZTsKPj4gPiAgCWZvciAoaSA9 IDA7IGkgPCBmd19zaXplOyBpKyspCj4+ID4gIAkJSTkxNV9XUklURShDU1JfUFJPR1JBTV9CQVNF ICsgaSAqIDQsCj4+ID4tCQkJKHUzMiBfX2ZvcmNlKXBheWxvYWRbaV0pOwo+PiA+KwkJCXBheWxv YWRbaV0pOwo+PiA+ICAJZm9yIChpID0gMDsgaSA8IGRldl9wcml2LT5jc3IubW1pb19jb3VudDsg aSsrKSB7Cj4+ID4gIAkJSTkxNV9XUklURShkZXZfcHJpdi0+Y3NyLm1taW9hZGRyW2ldLAo+PiA+ QEAgLTI3OSw3ICsyNzksNyBAQCBzdGF0aWMgdm9pZCBmaW5pc2hfY3NyX2xvYWQoY29uc3Qgc3Ry dWN0IGZpcm13YXJlICpmdywgdm9pZCAqY29udGV4dCkKPj4gPiAgCWNoYXIgc3Vic3RlcHBpbmcg PSBpbnRlbF9nZXRfc3Vic3RlcHBpbmcoZGV2KTsKPj4gPiAgCXVpbnQzMl90IGRtY19vZmZzZXQg PSBDU1JfREVGQVVMVF9GV19PRkZTRVQsIHJlYWRjb3VudCA9IDAsIG5ieXRlczsKPj4gPiAgCXVp bnQzMl90IGk7Cj4+ID4tCV9fYmUzMiAqZG1jX3BheWxvYWQ7Cj4+ID4rCXVpbnQzMl90ICpkbWNf cGF5bG9hZDsKPj4gPiAgCWJvb2wgZndfbG9hZGVkID0gZmFsc2U7Cj4+ID4gIAlpZiAoIWZ3KSB7 Cj4+ID5AQCAtMzc1LDE1ICszNzUsNyBAQCBzdGF0aWMgdm9pZCBmaW5pc2hfY3NyX2xvYWQoY29u c3Qgc3RydWN0IGZpcm13YXJlICpmdywgdm9pZCAqY29udGV4dCkKPj4gPiAgCX0KPj4gPiAgCWRt Y19wYXlsb2FkID0gY3NyLT5kbWNfcGF5bG9hZDsKPj4gPi0JZm9yIChpID0gMDsgaSA8IGRtY19o ZWFkZXItPmZ3X3NpemU7IGkrKykgewo+PiA+LQkJdWludDMyX3QgKnRtcCA9ICh1MzIgKikmZnct PmRhdGFbcmVhZGNvdW50ICsgaSAqIDRdOwo+PiA+LQkJLyoKPj4gPi0JCSAqIFRoZSBmaXJtd2Fy ZSBwYXlsb2FkIGlzIGFuIGFycmF5IG9mIDMyIGJpdCB3b3JkcyBzdG9yZWQgaW4KPj4gPi0JCSAq IGxpdHRsZS1lbmRpYW4gZm9ybWF0IGluIHRoZSBmaXJtd2FyZSBpbWFnZSBhbmQgcHJvZ3JhbW1l ZAo+PiA+LQkJICogYXMgMzIgYml0IGJpZy1lbmRpYW4gZm9ybWF0IHRvIG1lbW9yeS4KPj4gPi0J CSAqLwo+PiA+LQkJZG1jX3BheWxvYWRbaV0gPSBjcHVfdG9fYmUzMigqdG1wKTsKPj4gPi0JfQo+ PiA+KwltZW1jcHkoZG1jX3BheWxvYWQsICZmdy0+ZGF0YVtyZWFkY291bnRdLCBuYnl0ZXMpOwo+ PiA+ICAJLyogbG9hZCBjc3IgcHJvZ3JhbSBkdXJpbmcgc3lzdGVtIGJvb3QsIGFzIG5lZWRlZCBm b3IgREMgc3RhdGVzICovCj4+ID4gIAlpbnRlbF9jc3JfbG9hZF9wcm9ncmFtKGRldik7Cj4+ID4t LQo+PiA+Mi4wLjIKPj4gPgo+PiAKPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngKPgo+IC0tIAo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBF bmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiBodHRwOi8vYmxvZy5mZndsbC5jaAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==