From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v6 3/8] drm/i915: Unify ilk and hsw .get_aux_clock_divider Date: Fri, 05 Jun 2015 10:58:22 +0300 Message-ID: <87vbf2a8o1.fsf@intel.com> References: <1433335514-4156-1-git-send-email-mika.kahola@intel.com> <1433335514-4156-4-git-send-email-mika.kahola@intel.com> <877frjbo84.fsf@intel.com> <20150604151748.GO5176@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 41EEF6E26B for ; Fri, 5 Jun 2015 00:56:06 -0700 (PDT) In-Reply-To: <20150604151748.GO5176@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, "Syrjala, Ville" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAwNCBKdW4gMjAxNSwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gVGh1LCBKdW4gMDQsIDIwMTUgYXQgMDQ6MjQ6NDNQTSAr MDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IE9uIFdlZCwgMDMgSnVuIDIwMTUsIE1pa2EgS2Fo b2xhIDxtaWthLmthaG9sYUBpbnRlbC5jb20+IHdyb3RlOgo+PiA+IEZyb206IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4+ID4KPj4gPiBpbGtfZ2V0X2F1 eF9jbG9ja19kaXZpZGVyKCkgaXMgbm93IGEgc3Vic2V0IG9mCj4+ID4gaHN3X2dldF9hdXhfY2xv Y2tfZGl2aWRlcigpIHNvIHVuaWZ5IHRoZW0uCj4+IAo+PiBJIGRvIGxpa2UgdGhlIGNsYXJpdHkg b2YgaGF2aW5nIHRoZXNlIHR3byBzZXBhcmF0ZSwKPgo+IEkgc2VlIG5vIGNsYXJpdHkuIEp1c3Qg cG9pbnRsZXNzIGR1cGxpY2F0aW9uIHdoaWNoIHJpc2tzIGRpZmZlcmVudAo+IGJ1Z3MgaW4gZGlm ZmVyZW50IHN1YnNldHMgb2YgdGhlIHBsYXRmb3Jtcy4KCkknbSBvbmx5IHJlcGx5aW5nIGJlY2F1 c2UgdGhpcyBpcyBhIG11Y2ggbGFyZ2VyIGRpc2N1c3Npb24gdGhhbiBqdXN0CnRoaXMgcGF0Y2gu CgpUaGUgd2F5IEkgc2VlIGl0LCBpdCdzIGN1cnJlbnRseSBtb3JlIGxpa2VseSB0aGF0IHdlJ2xs IGhhdmUgc3VidGxlCnBsYXRmb3JtIHNwZWNpZmljIGJ1Z3MgYmVjYXVzZSBvZiBhIGJ1bmNoIG9m IGlmIGNvbmRpdGlvbnMgaW4gZnVuY3Rpb25zCmNvbWJpbmVkIGZvciB0aGUgc2FrZSBvZiBkZWR1 cGxpY2F0aW5nIDEwIGxpbmVzLiBXaGVuIHdlIGFkZCBtb3JlCmNvbmRpdGlvbnMgdG8gc3VjaCBj b21iaW5lZCBmdW5jdGlvbnMsIGl0J3MgbW9yZSBsaWtlbHkgdGhhdCB3ZQppbnRyb2R1Y2UgYnVn cyB0byBwbGF0Zm9ybXMgd2UgZGlkbid0IGV2ZW4gaW50ZW5kIHRvIHRvdWNoLgoKVGhlIGlsaysg Y29kZSByZXR1cm5zIGVhcmx5IGZvciBpbmRleCAhPSAwLiBIZXksIG9uZSBzdWJzZWNvbmQgZ2xh bmNlCmFuZCB5b3Uga25vdyB0aGVyZSBhcmUgbm8gcmV0cmllcy4KClRoZSBpbGsrIGNvZGUgZG9l cyBub3QgY2hlY2sgZm9yIGEgUENIIElEIHdoaWNoIGl0IGRvZXNuJ3Qgc2hpcAp3aXRoLiBPbmUg ZmV3ZXIgYnJpZWYgV1RGIHBhdXNlcyB3aGlsZSByZWFkaW5nIHRoZSBjb2RlLgoKV2hlbiB5b3Ug cmVhZCB0aGUgY29kZSwgaXQncyBtb3N0IG9mdGVuIG5vdCBqdXN0IHRoZXNlIGxvd2VzdCBsZXZl bApmdW5jdGlvbnMuIEl0J3MgYSBiaWdnZXIgY29udGV4dCwgYW5kIGVhY2ggc3RlcCBoZXJlIGFk ZHMgdG8gYSBjb2duaXRpdmUKYnVyZGVuIHlvdSBoYXZlIHRvIGNhcnJ5LiBJZiB5b3UgaGF2ZSB0 byBjb25zaWRlciBtb3JlIHN0dWZmLCB5b3UnbGwKc3dhcCBvdXQgc29tZXRoaW5nIGVsc2UsIGFu ZCBpdCBiZWNvbWVzIGhhcmRlciBhbmQgc2xvd2VyLgoKQXMgYSB3aG9sZSwgdGhpcyBpcyBoYXJk IHN0dWZmLCBhbmQgdGhlIHJlYWRhYmlsaXR5IGhhcyB0byBiZSBhdCBhIGxldmVsCndoZXJlIHlv dSBkb24ndCBoYXZlIHRvIHBhdXNlIHRvIHdvbmRlciB3aGF0J3MgZ29pbmcgb24uIEl0IGFsbCBh ZGRzIHVwLgoKQlIsCkphbmkuCgoKPj4gZXNwZWNpYWxseSB3aXRoIHRoZQo+PiBlYXJseSByZXR1 cm4gaW4gdGhlIGlsayB2ZXJzaW9uIGFuZCB0aGUgdy9hIGluIHRoZSBoc3cvYmR3IHZlcnNpb24K Pj4gTW9yZW92ZXIgdGhlcmUncyB0aGUgc3VidGxlIHJvdW5kIHVwIHZzLiBjbG9zZXN0IGRpZmZl cmVuY2UsIGFuZCBhCj4+IGhpc3Rvcnkgb2YgYXV4IGJ1Z3MuLi4KPgo+IFRoZSB1cCB2cy4gY2xv c2VzdCBtYWtlcyBubyBkaWZmZXJlbmNlIGZvciBJTEstSVZCIHNpbmNlIHRoZSBjZGNsayBpcwo+ IGVpdGhlciA0NTAgb3IgNDAwIE1Iei4gQW55d2F5IEkgc3VwcG9zZSB3ZSBzaG91bGQganVzdCBj aGFuZ2UgdGhlbSBhbGwKPiB0byB1c2UgRElWX1JPVU5EX0NMT1NFU1QoKS4KPgo+PiAKPj4gSSdt IGRyb3BwaW5nIHRoaXMgb25lLCBkb2Vzbid0IHNlZW0gdG8gYWZmZWN0IGxhdGVyIHBhdGNoZXMu Cj4KPiBObyBiaWdnaWUuIEJ1dCBJJ20gZmFpcmx5IHN1cmUgSSdsbCBldmVudHVhbGx5IHNlbmQg cGF0Y2hlcyB0byBzdG9yZQo+IHRoZSByYXdjbGsgaW4gZGV2X3ByaXYsIGF0IHdoaWNoIHBvaW50 IEknbGwgcHJvcG9zZSBraWxsaW5nIGFsbCBvZgo+IHRoZXNlICh3ZWxsLCBtYXliZSBzZXR0bGlu ZyBmb3Igc2tsKyB2cy4gdGhlIHJlc3QpLgo+Cj4+IAo+PiBCUiwKPj4gSmFuaS4KPj4gCj4+IAo+ PiA+Cj4+ID4gdjI6IFJlYmFzZWQgdG8gdGhlIGxhdGVzdAo+PiA+IHYzOiBSZWJhc2VkIHRvIHRo ZSBsYXRlc3QKPj4gPiB2NDogRml4IGZvciBwYXRjaCBzdHlsZSBwcm9ibGVtcwo+PiA+Cj4+ID4g U2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBNaWthIEthaG9sYSA8bWlrYS5rYWhvbGFAaW50ZWwu Y29tPgo+PiA+Cj4+ID4gQXV0aG9yOiAgICBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+PiA+IC0tLQo+PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcC5jIHwgMjMgKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4gPiAgMSBmaWxlIGNoYW5nZWQs IDMgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4+ID4KPj4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMKPj4gPiBpbmRleCA5YTY1MTdkLi45NTlmMTE1IDEwMDY0NAo+PiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcC5jCj4+ID4gQEAgLTcwNCwyMyArNzA0LDYgQEAgc3RhdGljIHVpbnQzMl90 IGlsa19nZXRfYXV4X2Nsb2NrX2RpdmlkZXIoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgaW50 IGluZGV4KQo+PiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RpZ19wb3J0LT5i YXNlLmJhc2UuZGV2Owo+PiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g ZGV2LT5kZXZfcHJpdmF0ZTsKPj4gPiAgCj4+ID4gLQlpZiAoaW5kZXgpCj4+ID4gLQkJcmV0dXJu IDA7Cj4+ID4gLQo+PiA+IC0JaWYgKGludGVsX2RpZ19wb3J0LT5wb3J0ID09IFBPUlRfQSkgewo+ PiA+IC0JCXJldHVybiBESVZfUk9VTkRfVVAoZGV2X3ByaXYtPmNkY2xrX2ZyZXEsIDIwMDApOwo+ PiA+IC0KPj4gPiAtCX0gZWxzZSB7Cj4+ID4gLQkJcmV0dXJuIERJVl9ST1VORF9VUChpbnRlbF9w Y2hfcmF3Y2xrKGRldiksIDIpOwo+PiA+IC0JfQo+PiA+IC19Cj4+ID4gLQo+PiA+IC1zdGF0aWMg dWludDMyX3QgaHN3X2dldF9hdXhfY2xvY2tfZGl2aWRlcihzdHJ1Y3QgaW50ZWxfZHAgKmludGVs X2RwLCBpbnQgaW5kZXgpCj4+ID4gLXsKPj4gPiAtCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQg KmludGVsX2RpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+PiA+IC0Jc3RydWN0 IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RpZ19wb3J0LT5iYXNlLmJhc2UuZGV2Owo+PiA+IC0J c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4g PiAtCj4+ID4gIAlpZiAoaW50ZWxfZGlnX3BvcnQtPnBvcnQgPT0gUE9SVF9BKSB7Cj4+ID4gIAkJ aWYgKGluZGV4KQo+PiA+ICAJCQlyZXR1cm4gMDsKPj4gPiBAQCAtNzMzLDcgKzcxNiw5IEBAIHN0 YXRpYyB1aW50MzJfdCBoc3dfZ2V0X2F1eF9jbG9ja19kaXZpZGVyKHN0cnVjdCBpbnRlbF9kcCAq aW50ZWxfZHAsIGludCBpbmRleCkKPj4gPiAgCQlkZWZhdWx0OiByZXR1cm4gMDsKPj4gPiAgCQl9 Cj4+ID4gIAl9IGVsc2UgIHsKPj4gPiAtCQlyZXR1cm4gaW5kZXggPyAwIDogRElWX1JPVU5EX1VQ KGludGVsX3BjaF9yYXdjbGsoZGV2KSwgMik7Cj4+ID4gKwkJaWYgKGluZGV4KQo+PiA+ICsJCQly ZXR1cm4gMDsKPj4gPiArCQlyZXR1cm4gRElWX1JPVU5EX1VQKGludGVsX3BjaF9yYXdjbGsoZGV2 KSwgMik7Cj4+ID4gIAl9Cj4+ID4gIH0KPj4gPiAgCj4+ID4gQEAgLTU3NDYsOCArNTczMSw2IEBA IGludGVsX2RwX2luaXRfY29ubmVjdG9yKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVs X2RpZ19wb3J0LAo+PiA+ICAJCWludGVsX2RwLT5nZXRfYXV4X2Nsb2NrX2RpdmlkZXIgPSBza2xf Z2V0X2F1eF9jbG9ja19kaXZpZGVyOwo+PiA+ICAJZWxzZSBpZiAoSVNfVkFMTEVZVklFVyhkZXYp KQo+PiA+ICAJCWludGVsX2RwLT5nZXRfYXV4X2Nsb2NrX2RpdmlkZXIgPSB2bHZfZ2V0X2F1eF9j bG9ja19kaXZpZGVyOwo+PiA+IC0JZWxzZSBpZiAoSVNfSEFTV0VMTChkZXYpIHx8IElTX0JST0FE V0VMTChkZXYpKQo+PiA+IC0JCWludGVsX2RwLT5nZXRfYXV4X2Nsb2NrX2RpdmlkZXIgPSBoc3df Z2V0X2F1eF9jbG9ja19kaXZpZGVyOwo+PiA+ICAJZWxzZSBpZiAoSEFTX1BDSF9TUExJVChkZXYp KQo+PiA+ICAJCWludGVsX2RwLT5nZXRfYXV4X2Nsb2NrX2RpdmlkZXIgPSBpbGtfZ2V0X2F1eF9j bG9ja19kaXZpZGVyOwo+PiA+ICAJZWxzZQo+PiA+IC0tIAo+PiA+IDEuOS4xCj4+ID4KPj4gPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiA+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+ ID4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo+PiAKPj4gLS0gCj4+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRlcgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo+Cj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwgT1RDCgotLSAKSmFuaSBO aWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==