public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Dont enable CS_PARSER_ERROR	interrupts at all
Date: Tue, 14 Apr 2015 12:05:54 +0300	[thread overview]
Message-ID: <87vbgz2i6l.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <1427888626-28900-1-git-send-email-daniel.vetter@ffwll.ch>

Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> We stopped handling them in
>
> commit aaecdf611a05cac26a94713bad25297e60225c29
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Tue Nov 4 15:52:22 2014 +0100
>
>     drm/i915: Stop gathering error states for CS error interrupts
>
> but just clearing is apparently not enough: A sufficiently dead gpu
> left behind by firmware (*cough* coreboot *cough*) can keep the gpu in
> an endless loop of such interrupts, eventually leading to the nmi
> firing. And definitely to what looks like a machine hang.
>
> Since we don't even enable these interrupts on gen5+ let's do the same
> on earlier platforms.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=93171
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_irq.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 14ecb4d13a1a..6d494432b19f 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3598,14 +3598,12 @@ static int i8xx_irq_postinstall(struct drm_device *dev)
>  		~(I915_DISPLAY_PIPE_A_EVENT_INTERRUPT |
>  		  I915_DISPLAY_PIPE_B_EVENT_INTERRUPT |
>  		  I915_DISPLAY_PLANE_A_FLIP_PENDING_INTERRUPT |
> -		  I915_DISPLAY_PLANE_B_FLIP_PENDING_INTERRUPT |
> -		  I915_RENDER_COMMAND_PARSER_ERROR_INTERRUPT);
> +		  I915_DISPLAY_PLANE_B_FLIP_PENDING_INTERRUPT);
>  	I915_WRITE16(IMR, dev_priv->irq_mask);
>  
>  	I915_WRITE16(IER,
>  		     I915_DISPLAY_PIPE_A_EVENT_INTERRUPT |
>  		     I915_DISPLAY_PIPE_B_EVENT_INTERRUPT |
> -		     I915_RENDER_COMMAND_PARSER_ERROR_INTERRUPT |
>  		     I915_USER_INTERRUPT);
>  	POSTING_READ16(IER);
>  
> @@ -3767,14 +3765,12 @@ static int i915_irq_postinstall(struct drm_device *dev)
>  		  I915_DISPLAY_PIPE_A_EVENT_INTERRUPT |
>  		  I915_DISPLAY_PIPE_B_EVENT_INTERRUPT |
>  		  I915_DISPLAY_PLANE_A_FLIP_PENDING_INTERRUPT |
> -		  I915_DISPLAY_PLANE_B_FLIP_PENDING_INTERRUPT |
> -		  I915_RENDER_COMMAND_PARSER_ERROR_INTERRUPT);
> +		  I915_DISPLAY_PLANE_B_FLIP_PENDING_INTERRUPT);
>  
>  	enable_mask =
>  		I915_ASLE_INTERRUPT |
>  		I915_DISPLAY_PIPE_A_EVENT_INTERRUPT |
>  		I915_DISPLAY_PIPE_B_EVENT_INTERRUPT |
> -		I915_RENDER_COMMAND_PARSER_ERROR_INTERRUPT |
>  		I915_USER_INTERRUPT;
>  
>  	if (I915_HAS_HOTPLUG(dev)) {
> -- 
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-04-14  9:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 11:43 [PATCH] drm/i915: Dont enable CS_PARSER_ERROR interrupts at all Daniel Vetter
2015-04-02  0:50 ` shuang.he
2015-04-07  8:30 ` Daniel Vetter
2015-04-14  9:05 ` Mika Kuoppala [this message]
2015-04-14 14:07   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbgz2i6l.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox