From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jeff McGee <jeff.mcgee@intel.com>,
Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT
Date: Fri, 30 Jan 2015 09:30:07 +0200 [thread overview]
Message-ID: <87vbjoybcw.fsf@intel.com> (raw)
In-Reply-To: <20150129201113.GM12268@jeffdesk>
On Thu, 29 Jan 2015, Jeff McGee <jeff.mcgee@intel.com> wrote:
> On Thu, Jan 29, 2015 at 02:13:38PM +0000, Damien Lespiau wrote:
>> We need to have a separate GT3 struct intel_device_info to declare they
>> have a second VCS. Let's start by splitting the PCI ids per-GT.
>>
> Would it be a good idea to do more programmatic population of
> these fields, rather than creating an entire new instance of the
> struct just to alter one field? This relates to our other
> conversation about the memory consumed by the 30+ device infos
> and the concern when adding new fields.
From a debugging perspective, I do like the way it is. You can look at
or search the info structs and you know which platforms have what, no
thinking involved.
On a related note, I'm contemplating sending a patch to obliterate the
_INTEL_BDW_M and _INTEL_BDW_D macros from i915_pciids.h because it hides
the IDs from a simple grep.
See how I try to optimize space and time resources - of my brain!
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-30 7:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 14:13 [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT Damien Lespiau
2015-01-29 14:13 ` [PATCH 2/3] drm/i915/skl: Declare that GT3 has a second VCS Damien Lespiau
2015-02-04 1:55 ` Rodrigo Vivi
2015-02-04 9:27 ` Daniel Vetter
2015-02-04 13:22 ` [PATCH 2/3 v2] " Damien Lespiau
2015-02-04 15:43 ` Rodrigo Vivi
2015-01-29 14:13 ` [PATCH 3/3] drm/i915/skl: Remove the check enforcing VCS2 to be gen8 only Damien Lespiau
2015-01-31 17:17 ` shuang.he
2015-02-04 1:55 ` Rodrigo Vivi
2015-02-04 9:28 ` Daniel Vetter
2015-01-29 20:11 ` [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT Jeff McGee
2015-01-30 7:30 ` Jani Nikula [this message]
2015-01-30 16:05 ` Jeff McGee
2015-02-02 12:01 ` Damien Lespiau
2015-01-30 16:25 ` Daniel Vetter
2015-02-04 1:51 ` Rodrigo Vivi
2015-02-04 11:58 ` Damien Lespiau
2015-02-04 13:10 ` Damien Lespiau
2015-02-04 15:41 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbjoybcw.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jeff.mcgee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox