[PATCH 0/4] Reduce intel_display.c

Paulo Zanoni
2014-04-09T21:44:47Z

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

Hi

We always talk about how intel_display.c is a giant file and how we would like
to reduce it, so this is my attempt. Currently the file has 12090 lines, and
after my patch series it has 8850 lines.

I don't know if right now is the appropriate time to merge patches like this. I
don't remember seeing too many patches on the list touching cursor/fdi/eld/pll
functions, but I know there is never an appropriate time for huge changes.

Also, this change will obviously make the lives of people who backport our
patches more complicated. So if we don't want this series at all, feel free to
NACK it.

I also didn't really know what kind of changes I needed to do to the file
headers, so I just copied the header from intel_display.c, kept Eric's name and
added a "2014" to Intel's copyright. I am not a lawyer and this may be not the
best thing to do, so please tell me the correct approach here :)

There are also some things that we might want to migrate from intel_ddi.c to
intel_pll.c, but I'll leave this to another patch.

Also, feel free to propose better ways to split intel_display.c.

Thanks,
Paulo

Paulo Zanoni (4):
drm/i915: extract intel_eld.c from intel_display.c
drm/i915: extract intel_cursor.c from intel_display.c
drm/i915: extract intel_fdi.c from intel_display.c
drm/i915: extract intel_pll.c from intel_display.c

drivers/gpu/drm/i915/Makefile | 4 +
drivers/gpu/drm/i915/intel_cursor.c | 357 ++++
drivers/gpu/drm/i915/intel_ddi.c | 142 +-
drivers/gpu/drm/i915/intel_display.c | 3622 ++--------------------------------
drivers/gpu/drm/i915/intel_drv.h | 143 +-
drivers/gpu/drm/i915/intel_eld.c | 355 ++++
drivers/gpu/drm/i915/intel_fdi.c | 959 +++++++++
drivers/gpu/drm/i915/intel_panel.c | 36 +
drivers/gpu/drm/i915/intel_pll.c | 1779 +++++++++++++++++
9 files changed, 3808 insertions(+), 3589 deletions(-)
create mode 100644 drivers/gpu/drm/i915/intel_cursor.c
create mode 100644 drivers/gpu/drm/i915/intel_eld.c
create mode 100644 drivers/gpu/drm/i915/intel_fdi.c
create mode 100644 drivers/gpu/drm/i915/intel_pll.c

--
1.9.0