From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/4] drm/i915: Factor out a function returning the AUX_CTL value to start a send Date: Tue, 21 Jan 2014 14:12:48 +0200 Message-ID: <87vbxd5y9r.fsf@intel.com> References: <1390233152-2913-1-git-send-email-damien.lespiau@intel.com> <1390233152-2913-3-git-send-email-damien.lespiau@intel.com> <878uu97in8.fsf@intel.com> <20140121115927.GE8968@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id CB05110585A for ; Tue, 21 Jan 2014 04:09:35 -0800 (PST) In-Reply-To: <20140121115927.GE8968@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Damien Lespiau Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 21 Jan 2014, Damien Lespiau wrote: > On Tue, Jan 21, 2014 at 12:07:23PM +0200, Jani Nikula wrote: >> Some general bikeshedding... >> >> I really wish everyone would write commit messages that work independent >> of the patch subject. Just like a newspaper article should make sense >> and tell a story also in the absence of a headline. > > Will keep this in mind next time (one could argue we're in deep > bikeshedding water here!). Well, yeah. Nothing personal, Damien, times_this_has_annoyed_me++ just grew beyond some threshold at this patch. ;) BR, Jani. -- Jani Nikula, Intel Open Source Technology Center