From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90C3EC52D6F for ; Wed, 21 Aug 2024 14:02:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 370AA10E5D8; Wed, 21 Aug 2024 14:02:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="BMwpvWqj"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4ED910E591 for ; Wed, 21 Aug 2024 14:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724248923; x=1755784923; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=h764bVDF5ZDGPuGXDD94nT+SNYlcjudNeEqwk6AgjpI=; b=BMwpvWqjrykXP9RUzoJdC2fvtso3iavfgOcYfZR/JJn6ymi/P9ISSmFd yvoPRCdHiQ26SuM3AFpL1NmE0u1e5s6Acsn5E6Nc3fZQ2PbtebEWMG5Fn JThfCnOHW5/aUGMrcV9/iuiFLBW2tqBCnw/btTI0A0GACQJf3XmVkisJ2 yqf110UZrzxfsK1O0JSuLAxi7ZY5wRMc9fO7D2jDwl4LGrv/ilkkinEJ4 GM1Q1QWJk3aweNQGU2OsIhLixL0q0AHmb4b+22MfeNKMIdAzr+uQmULhQ ps+uQMnSDr+/7+1Nm4bQHXPWrVzfrqaeP+tP7e8BRhGFCC8OdE9YjsoAt Q==; X-CSE-ConnectionGUID: AMR97SArS2uFT++jx7fKbg== X-CSE-MsgGUID: X7WrhgHISbyH9TSnMjWkrQ== X-IronPort-AV: E=McAfee;i="6700,10204,11171"; a="33178109" X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="33178109" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2024 07:02:03 -0700 X-CSE-ConnectionGUID: I8CDDeI0Qc6zL4UXN2M6dA== X-CSE-MsgGUID: osph2UvQSZu0DCeU3NgrDg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="65934752" Received: from sbutnari-mobl1.ti.intel.com (HELO localhost) ([10.245.246.20]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2024 07:02:01 -0700 From: Jani Nikula To: Jouni =?utf-8?Q?H=C3=B6gander?= , intel-gfx@lists.freedesktop.org Cc: ville.syrjala@linux.intel.com, Jouni =?utf-8?Q?H=C3=B6gander?= Subject: Re: [PATCH 2/2] drm/i915/display: Increase Fast Wake Sync length as a quirk In-Reply-To: <20240820161429.2213343-3-jouni.hogander@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240820161429.2213343-1-jouni.hogander@intel.com> <20240820161429.2213343-3-jouni.hogander@intel.com> Date: Wed, 21 Aug 2024 17:01:56 +0300 Message-ID: <87wmka3rfv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 20 Aug 2024, Jouni H=C3=B6gander wrote: > In commit "drm/i915/display: Increase number of fast wake precharge pulse= s" > we were increasing Fast Wake sync pulse length to fix problems observed on > Dell Precision 5490 laptop with AUO panel. Later we have observed this is > causing problems on other panels. > > Fix these problems by increasing Fast Wake sync pulse length as a quirk > applied for Dell Precision 5490 with problematic panel. > > Fixes: f77772866385 ("drm/i915/display: Increase number of fast wake prec= harge pulses") > Cc: Ville Syrj=C3=A4l=C3=A4 > Closes: http://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9739 > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2246 > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11762 > Signed-off-by: Jouni H=C3=B6gander > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 2 +- > drivers/gpu/drm/i915/display/intel_dp_aux.c | 17 ++++++++++++----- > drivers/gpu/drm/i915/display/intel_dp_aux.h | 2 +- > drivers/gpu/drm/i915/display/intel_quirks.c | 9 +++++++++ > drivers/gpu/drm/i915/display/intel_quirks.h | 1 + > 5 files changed, 24 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/= i915/display/intel_alpm.c > index 82ee778b2efe9..186cf4833f716 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > @@ -228,7 +228,7 @@ bool intel_alpm_compute_params(struct intel_dp *intel= _dp, > int tfw_exit_latency =3D 20; /* eDP spec */ > int phy_wake =3D 4; /* eDP spec */ > int preamble =3D 8; /* eDP spec */ > - int precharge =3D intel_dp_aux_fw_sync_len() - preamble; > + int precharge =3D intel_dp_aux_fw_sync_len(intel_dp) - preamble; > u8 max_wake_lines; >=20=20 > io_wake_time =3D max(precharge, io_buffer_wake_time(crtc_state)) + > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/dr= m/i915/display/intel_dp_aux.c > index b8a53bb174dab..7adb1af252678 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c > @@ -13,6 +13,7 @@ > #include "intel_dp_aux.h" > #include "intel_dp_aux_regs.h" > #include "intel_pps.h" > +#include "intel_quirks.h" > #include "intel_tc.h" >=20=20 > #define AUX_CH_NAME_BUFSIZE 6 > @@ -142,16 +143,22 @@ static int intel_dp_aux_sync_len(void) > return precharge + preamble; > } >=20=20 > -int intel_dp_aux_fw_sync_len(void) > +int intel_dp_aux_fw_sync_len(struct intel_dp *intel_dp) > { > + int precharge =3D 10; /* 10-16 */ > + int preamble =3D 8; > + > /* > * We faced some glitches on Dell Precision 5490 MTL laptop with panel: > * "Manufacturer: AUO, Model: 63898" when using HW default 18. Using 20 > * is fixing these problems with the panel. It is still within range > - * mentioned in eDP specification. > + * mentioned in eDP specification. Increasing Fast Wake sync length is > + * causing problems with other panels: increase length as a quirk for > + * this specific laptop. > */ > - int precharge =3D 12; /* 10-16 */ > - int preamble =3D 8; > + if (intel_has_quirk(__intel_dp_to_intel_display(intel_dp), Please don't use __intel_dp_to_intel_display() or *any* of the __xxx_to_intel_display() directly. to_intel_display() is magic and handles them all via _Generic(). Also add the local variable: struct intel_display *display =3D to_intel_display(intel_dp); Anyway, as I noted before, what if one sink has the issue, then it's applied to all sinks here. Yeah it's unlikely with an eDP panel, but let's not add such a mechanism. It should be sink specific, because we may just end up having to do that anyway for some sinks. > + QUIRK_FW_SYNC_LEN)) > + precharge +=3D 2; >=20=20 > return precharge + preamble; > } > @@ -211,7 +218,7 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *inte= l_dp, > DP_AUX_CH_CTL_TIME_OUT_MAX | > DP_AUX_CH_CTL_RECEIVE_ERROR | > DP_AUX_CH_CTL_MESSAGE_SIZE(send_bytes) | > - DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(intel_dp_aux_fw_sync_len()) | > + DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(intel_dp_aux_fw_sync_len(intel_dp)) | > DP_AUX_CH_CTL_SYNC_PULSE_SKL(intel_dp_aux_sync_len()); >=20=20 > if (intel_tc_port_in_tbt_alt_mode(dig_port)) > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.h b/drivers/gpu/dr= m/i915/display/intel_dp_aux.h > index 76d1f2ed7c2f4..593f58fafab71 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.h > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.h > @@ -20,6 +20,6 @@ enum aux_ch intel_dp_aux_ch(struct intel_encoder *encod= er); >=20=20 > void intel_dp_aux_irq_handler(struct drm_i915_private *i915); > u32 intel_dp_aux_pack(const u8 *src, int src_bytes); > -int intel_dp_aux_fw_sync_len(void); > +int intel_dp_aux_fw_sync_len(struct intel_dp *intel_dp); >=20=20 > #endif /* __INTEL_DP_AUX_H__ */ > diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/dr= m/i915/display/intel_quirks.c > index d9045b317cd16..acdd2ff1dd422 100644 > --- a/drivers/gpu/drm/i915/display/intel_quirks.c > +++ b/drivers/gpu/drm/i915/display/intel_quirks.c > @@ -65,6 +65,12 @@ static void quirk_no_pps_backlight_power_hook(struct i= ntel_display *display) > drm_info(display->drm, "Applying no pps backlight power quirk\n"); > } >=20=20 > +static void quirk_fw_sync_len(struct intel_display *display) > +{ > + intel_set_quirk(display, QUIRK_FW_SYNC_LEN); > + drm_info(display->drm, "Applying Fast Wake sync pulse count quirk\n"); > +} > + > struct intel_quirk { > int device; > int subsystem_vendor; > @@ -196,6 +202,9 @@ static struct intel_quirk intel_quirks[] =3D { > /* Dell Chromebook 11 (2015 version) */ > { 0x0a16, 0x1028, 0x0a35, SINK_OUI_ANY, SINK_DEVICE_ID_ANY, quirk_backl= ight_present }, >=20=20 > + /* Dell Precision 5490 */ > + { 0x7d55, 0x1028, 0x0cc7, SINK_OUI(0x38, 0xec, 0x11), SINK_DEVICE_ID_AN= Y, quirk_fw_sync_len }, > + > /* Toshiba Satellite P50-C-18C */ > { 0x191B, 0x1179, 0xF840, SINK_OUI_ANY, SINK_DEVICE_ID_ANY, quirk_incre= ase_t12_delay }, >=20=20 > diff --git a/drivers/gpu/drm/i915/display/intel_quirks.h b/drivers/gpu/dr= m/i915/display/intel_quirks.h > index 2d664af7e89f7..3c3e74310b7f2 100644 > --- a/drivers/gpu/drm/i915/display/intel_quirks.h > +++ b/drivers/gpu/drm/i915/display/intel_quirks.h > @@ -18,6 +18,7 @@ enum intel_quirk_id { > QUIRK_INVERT_BRIGHTNESS, > QUIRK_LVDS_SSC_DISABLE, > QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK, > + QUIRK_FW_SYNC_LEN, > }; >=20=20 > void intel_init_quirks(struct intel_display *display); --=20 Jani Nikula, Intel