From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F4B0C7EE22 for ; Thu, 11 May 2023 18:57:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E9EC710E5D6; Thu, 11 May 2023 18:57:48 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4BAD10E5D6 for ; Thu, 11 May 2023 18:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683831466; x=1715367466; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=q4wIJQZtbXbj/AHmFKrYSwQGXbZBaxuTeybEONgqj80=; b=AW8T04tWDOTMN104YOYqIxPMZensLkrlg9h6kSD04OjAOC2pkCw/Kl2E PHX96gO4HrAQjSn/IEuhWc3M33SZVi2p48lyXB67vKut6X030ZaxlwrsP rPsw0YgAUgdAaiZ6t9UcmGH2feHszjbU6Y1dgCN+cN9EhPEzoIrCcT5FJ tN7TWwOXBUYfbojnAEp0aWcGgVN5ijs28bil9lNxfx0U4eHJEiaCy8vN8 PRpwev8RsEW8V6I3esYcCUEAt2TYITkTmcwEU+/xcG+nhi3ihmb/3wZj5 Q/KCWMaQa6/kicLrS4GBKSl/IEa2hepJXEwFuBYNLaSgbgZNlJaJO2SVR Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="378732103" X-IronPort-AV: E=Sophos;i="5.99,268,1677571200"; d="scan'208";a="378732103" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2023 11:57:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="650328393" X-IronPort-AV: E=Sophos;i="5.99,268,1677571200"; d="scan'208";a="650328393" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.97.176]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2023 11:57:43 -0700 Date: Thu, 11 May 2023 11:57:27 -0700 Message-ID: <87wn1eelwo.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <20230506005816.1891043-7-umesh.nerlige.ramappa@intel.com> References: <20230506005816.1891043-1-umesh.nerlige.ramappa@intel.com> <20230506005816.1891043-7-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 6/6] drm/i915/pmu: Export counters from all tiles X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 05 May 2023 17:58:16 -0700, Umesh Nerlige Ramappa wrote: > One drive-by comment: > diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > index 12b2f3169abf..284e5c5b97bb 100644 > --- a/drivers/gpu/drm/i915/i915_pmu.c > +++ b/drivers/gpu/drm/i915/i915_pmu.c > @@ -546,8 +546,9 @@ config_status(struct drm_i915_private *i915, u64 config) > struct intel_gt *gt = to_gt(i915); > > unsigned int gt_id = config_gt_id(config); > + unsigned int max_gt_id = HAS_EXTRA_GT_LIST(i915) ? 1 : 0; But in Patch 5 we have: #define I915_PMU_MAX_GTS (4) > > - if (gt_id) > + if (gt_id > max_gt_id) > return -ENOENT; > > switch (config_counter(config)) { > @@ -561,6 +562,8 @@ config_status(struct drm_i915_private *i915, u64 config) > return -ENODEV; > break; > case I915_PMU_INTERRUPTS: > + if (gt_id) > + return -ENOENT; > break; > case I915_PMU_RC6_RESIDENCY: > if (!gt->rc6.supported) Thanks. -- Ashutosh