From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B3D6C433F5 for ; Thu, 6 Jan 2022 20:39:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 30F4010E5B6; Thu, 6 Jan 2022 20:39:53 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1567910E5B6; Thu, 6 Jan 2022 20:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641501591; x=1673037591; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=arkEy+u+VplrHP6rJHvqXblJcDaSF1mjM1j8cfFwBOU=; b=jLJHmxkKGvRR7Z40hEH6RFSc3t8S/YXkT+oBWbP/yKMDEF8nh//Mm137 PdZ6krffHnageTpZ6n3zVZi5oCxhXlzG8PrPWGup/d2GI7r2phRPt9tKU U1yDw3T79aIw5ew75nKedfi3mqn1Qtb6NX5Xa44FHYzg/jjgNzPY46B5j j5aZGD0S+WcpEqtiCGxjUil/4VqRfhxexio8PJYX9QWZt9r2b/q35/qXn JisC6XNkzh5THS2vx70N8B6fEkmyTmcLX9OBu/g7ELIxNdVMFWpFxJMXq 8iTQzTM2BJipL11mKxYDkBfVRJitj9XNV9OR+zf6/+owwBMTTMnss4Omm Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10217"; a="241550845" X-IronPort-AV: E=Sophos;i="5.88,267,1635231600"; d="scan'208";a="241550845" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2022 12:39:39 -0800 X-IronPort-AV: E=Sophos;i="5.88,267,1635231600"; d="scan'208";a="527118175" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.76.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2022 12:39:38 -0800 Date: Thu, 06 Jan 2022 12:39:38 -0800 Message-ID: <87wnjcha45.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Tvrtko Ursulin In-Reply-To: <20220106164258.56648-1-tvrtko.ursulin@linux.intel.com> References: <20220106164258.56648-1-tvrtko.ursulin@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/i915/perf_pmu: Fix allow hang handling X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 06 Jan 2022 08:42:58 -0800, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Commit d7a74b959eea ("tests/i915/perf_pmu: Convert to intel_ctx_t (v3)") > broke the test when it is run in its entirety. > > Correct context id needs to be used with igt_allow_hang to avoid context > ban preventing the test to run to completion. Reviewed-by: Ashutosh Dixit > Signed-off-by: Tvrtko Ursulin > Fixes: d7a74b959eea ("tests/i915/perf_pmu: Convert to intel_ctx_t (v3)") > Cc: Ashutosh Dixit > Cc: Maarten Lankhorst > --- > I haven't audited more tests apart from grep showing a lot of > igt_allow_hang with the default context so someone needs to go through > them and see if more are affected. Thanks, will do. > --- > tests/i915/perf_pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c > index 581da8483f0c..1665dc5e6317 100644 > --- a/tests/i915/perf_pmu.c > +++ b/tests/i915/perf_pmu.c > @@ -2319,7 +2319,7 @@ igt_main > } > > test_each_engine("busy-hang", fd, ctx, e) { > - igt_hang_t hang = igt_allow_hang(fd, 0, 0); > + igt_hang_t hang = igt_allow_hang(fd, ctx->id, 0); > > single(fd, ctx, e, TEST_BUSY | FLAG_HANG); > > -- > 2.32.0 >