public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/2] drm: Always include the debugfs dentry in drm_crtc
@ 2021-12-21 19:37 Ville Syrjala
  2021-12-21 19:37 ` [Intel-gfx] [PATCH 2/2] drm/dbi: Use a static inline stub for mipi_dbi_debugfs_init() Ville Syrjala
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Ville Syrjala @ 2021-12-21 19:37 UTC (permalink / raw)
  To: dri-devel; +Cc: Jani Nikula, Nathan Chancellor, intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Remove the counterproductive CONFIG_DEBUG_FS ifdef and just include
the debugfs dentry in drm_crtc always. This way we don't need
annoying ifdefs in the actual code with DEBUGFS=n. Also we don't
have these ifdefs around any of the other debugfs dentries either
so can't see why drm_crtc should be special.

This fixes the i915 DEBUGFS=n build because I assumed the dentry
would always be there.

Cc: Jani Nikula <jani.nikula@intel.com>
Reported-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Fixes: e74c6aa955ca ("drm/i915/fbc: Register per-crtc debugfs files")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 include/drm/drm_crtc.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 13eeba2a750a..4d01b4d89775 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -1135,14 +1135,12 @@ struct drm_crtc {
 	 */
 	spinlock_t commit_lock;
 
-#ifdef CONFIG_DEBUG_FS
 	/**
 	 * @debugfs_entry:
 	 *
 	 * Debugfs directory for this CRTC.
 	 */
 	struct dentry *debugfs_entry;
-#endif
 
 	/**
 	 * @crc:
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-12-22  8:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-21 19:37 [Intel-gfx] [PATCH 1/2] drm: Always include the debugfs dentry in drm_crtc Ville Syrjala
2021-12-21 19:37 ` [Intel-gfx] [PATCH 2/2] drm/dbi: Use a static inline stub for mipi_dbi_debugfs_init() Ville Syrjala
2021-12-21 20:00 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm: Always include the debugfs dentry in drm_crtc Patchwork
2021-12-21 20:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-21 22:54 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-12-22  8:11 ` [Intel-gfx] [PATCH 1/2] " Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox