From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CABC9C4338F for ; Wed, 11 Aug 2021 08:00:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83E1760F38 for ; Wed, 11 Aug 2021 08:00:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 83E1760F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BEB7F6E0CD; Wed, 11 Aug 2021 08:00:47 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 397D96E0CA; Wed, 11 Aug 2021 08:00:46 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="215066034" X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="215066034" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 01:00:38 -0700 X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="516578787" Received: from fbrausse-mobl.ger.corp.intel.com (HELO localhost) ([10.251.209.112]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 01:00:35 -0700 From: Jani Nikula To: Dave Airlie Cc: Joonas Lahtinen , Daniel Vetter , Matt Roper , Intel Graphics Development , dri-devel In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <162866195438.4169.13003970815194920952@jlahtine-mobl.ger.corp.intel.com> <877dgso3qx.fsf@intel.com> Date: Wed, 11 Aug 2021 11:00:32 +0300 Message-ID: <87wnosmmvz.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] missing signoff on drm-intel-gt-next pull X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 11 Aug 2021, Dave Airlie wrote: > On Wed, 11 Aug 2021 at 17:11, Jani Nikula wrote: >> >> On Wed, 11 Aug 2021, Joonas Lahtinen wrote: >> > Quoting Dave Airlie (2021-08-11 06:48:39) >> >> dim: db47fe727e1f ("drm/i915/step: >> >> s/_revid_tbl/_revids"): committer Signed-off-by >> >> missing. >> >> >> >> I'm not sure how much pain it is to fix that up, but >> >> commit db47fe727e1fc516cf60fc9ab8299605ef3c2d54 >> >> Author: Anusha Srivatsa >> >> Commit: Matt Roper >> >> >> >> drm/i915/step: s/_revid_tbl/_revids >> >> >> >> Simplify the stepping info array name. >> >> >> >> Cc: Jani Nikula >> >> Signed-off-by: Anusha Srivatsa >> >> Reviewed-by: Jani Nikula >> >> Link: https://patchwork.freedesktop.org/patch/msgid/20210713193635.3390052-2-matthew.d.roper@intel.com >> >> >> >> It's definitely missing an S-o-b by anyone who handled the patch. >> >> >> >> Let me know if it's insanely painful to fix that. >> > >> > Added you to the earlier mail thread that discussed the incident. >> > >> > There are now 277 patches on top of that patch, so means rebasing all of >> > those and changing the hashes and trying to fixup all the Fixes:. >> > >> > So it's painful but not insanely so. Let me know if you want the tree >> > rebased. >> > >> > Regards, Joonas >> >> The commit came in via a topic branch also to drm-intel-next, so that's >> another 168 commits to rebase. There's a lot of people working on top of >> those trees, so I'm leaning on the very painful side. > > Okay I think we can let that one slide. Having an S-o-b by someone in > the org on it is also technically enough for legal purposes anyways. > > I'll finish the pulls from both trees tomorrow. Thanks; in the mean time we'll need to eyeball the tooling to see if we can plug some of these holes. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center