From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [v5 1/4] drm/i915: Fix the pipe state timing mismatch warnings Date: Tue, 14 May 2019 10:38:37 +0300 Message-ID: <87woitjxj6.fsf@intel.com> References: <1556809862-31203-1-git-send-email-vandita.kulkarni@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FBAB89113 for ; Tue, 14 May 2019 07:36:37 +0000 (UTC) In-Reply-To: <1556809862-31203-1-git-send-email-vandita.kulkarni@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Vandita Kulkarni , intel-gfx@lists.freedesktop.org Cc: ville.syrjala@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAwMiBNYXkgMjAxOSwgVmFuZGl0YSBLdWxrYXJuaSA8dmFuZGl0YS5rdWxrYXJuaUBp bnRlbC5jb20+IHdyb3RlOgo+IEFkanVzdCB0aGUgZ2V0IHRyYW5zY29kZXIgdGltaW5ncyBmb3Ig bWlwaSBkc2kgYXMgcGVyIHRoZQo+IHNldCB0aW1pbmcgY2FsY3VsYXRpb25zLgo+Cj4gdjI6IFVz ZSB0aGUgZXhpc3RpbmcgaW50ZWxfZ2V0X3BpcGVfdGltaW5ncyBhbmQgZG8gdGhlIGRzaQo+ICAg ICBzcGVjaWZpYyBhZGp1c3RtZW50cyBpbiB0aGUgZW5jb2RlciBnZXRfY29uZmlnIGhvb2suKFZp bGxlLCBKYW5pKQo+Cj4gdjM6IEV4Y2x1ZGUgVkJMQU5LIGFuZCBIQkxBTksgcmVnaXN0ZXJzIGZv ciBkc2kgdHJhbnNjb2Rlci4KPgo+IHY0OiBGaXggdGhlIGluY29tcGxldGUgY29uZGl0aW9uYWwg bG9naWMuCj4KPiBTaWduZWQtb2ZmLWJ5OiBWYW5kaXRhIEt1bGthcm5pIDx2YW5kaXRhLmt1bGth cm5pQGludGVsLmNvbT4KClB1c2hlZCB0aGUgc2VyaWVzLCB0aGFua3MgZm9yIHRoZSBwYXRjaGVz LgoKQlIsCkphbmkuCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pY2xfZHNpLmMgICAg ICAgfCAyOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyMiArKysrKysrKysrKysrKysrLS0tLS0tCj4gIDIgZmls ZXMgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pY2xfZHNpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pY2xfZHNpLmMKPiBpbmRleCBjNmVjYzAwLi40NWZlNjljIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ljbF9kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lj bF9kc2kuYwo+IEBAIC0xMTk0LDYgKzExOTQsMzQgQEAgc3RhdGljIHZvaWQgZ2VuMTFfZHNpX2Rp c2FibGUoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAlnZW4xMV9kc2lfZGlzYWJs ZV9pb19wb3dlcihlbmNvZGVyKTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgZ2VuMTFfZHNpX2dl dF90aW1pbmdzKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICsJCQkJICBzdHJ1Y3Qg aW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9kc2kg KmludGVsX2RzaSA9IGVuY190b19pbnRlbF9kc2koJmVuY29kZXItPmJhc2UpOwo+ICsJc3RydWN0 IGRybV9kaXNwbGF5X21vZGUgKmFkanVzdGVkX21vZGUgPQo+ICsJCQkJCSZwaXBlX2NvbmZpZy0+ YmFzZS5hZGp1c3RlZF9tb2RlOwo+ICsKPiArCWlmIChpbnRlbF9kc2ktPmR1YWxfbGluaykgewo+ ICsJCWFkanVzdGVkX21vZGUtPmNydGNfaGRpc3BsYXkgKj0gMjsKPiArCQlpZiAoaW50ZWxfZHNp LT5kdWFsX2xpbmsgPT0gRFNJX0RVQUxfTElOS19GUk9OVF9CQUNLKQo+ICsJCQlhZGp1c3RlZF9t b2RlLT5jcnRjX2hkaXNwbGF5IC09Cj4gKwkJCQkJCWludGVsX2RzaS0+cGl4ZWxfb3ZlcmxhcDsK PiArCQlhZGp1c3RlZF9tb2RlLT5jcnRjX2h0b3RhbCAqPSAyOwo+ICsJfQo+ICsJYWRqdXN0ZWRf bW9kZS0+Y3J0Y19oYmxhbmtfc3RhcnQgPSBhZGp1c3RlZF9tb2RlLT5jcnRjX2hkaXNwbGF5Owo+ ICsJYWRqdXN0ZWRfbW9kZS0+Y3J0Y19oYmxhbmtfZW5kID0gYWRqdXN0ZWRfbW9kZS0+Y3J0Y19o dG90YWw7Cj4gKwo+ICsJaWYgKGludGVsX2RzaS0+b3BlcmF0aW9uX21vZGUgPT0gSU5URUxfRFNJ X1ZJREVPX01PREUpIHsKPiArCQlpZiAoaW50ZWxfZHNpLT5kdWFsX2xpbmspIHsKPiArCQkJYWRq dXN0ZWRfbW9kZS0+Y3J0Y19oc3luY19zdGFydCAqPSAyOwo+ICsJCQlhZGp1c3RlZF9tb2RlLT5j cnRjX2hzeW5jX2VuZCAqPSAyOwo+ICsJCX0KPiArCX0KPiArCWFkanVzdGVkX21vZGUtPmNydGNf dmJsYW5rX3N0YXJ0ID0gYWRqdXN0ZWRfbW9kZS0+Y3J0Y192ZGlzcGxheTsKPiArCWFkanVzdGVk X21vZGUtPmNydGNfdmJsYW5rX2VuZCA9IGFkanVzdGVkX21vZGUtPmNydGNfdnRvdGFsOwo+ICsK PiArfQo+ICsKPiAgc3RhdGljIHZvaWQgZ2VuMTFfZHNpX2dldF9jb25maWcoc3RydWN0IGludGVs X2VuY29kZXIgKmVuY29kZXIsCj4gIAkJCQkgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVf Y29uZmlnKQo+ICB7Cj4gQEAgLTEyMDQsNiArMTIzMiw3IEBAIHN0YXRpYyB2b2lkIGdlbjExX2Rz aV9nZXRfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJcGlwZV9jb25m aWctPnBvcnRfY2xvY2sgPQo+ICAJCWNubF9jYWxjX3dycGxsX2xpbmsoZGV2X3ByaXYsICZwaXBl X2NvbmZpZy0+ZHBsbF9od19zdGF0ZSk7Cj4gIAlwaXBlX2NvbmZpZy0+YmFzZS5hZGp1c3RlZF9t b2RlLmNydGNfY2xvY2sgPSBpbnRlbF9kc2ktPnBjbGs7Cj4gKwlnZW4xMV9kc2lfZ2V0X3RpbWlu Z3MoZW5jb2RlciwgcGlwZV9jb25maWcpOwo+ICAJcGlwZV9jb25maWctPm91dHB1dF90eXBlcyB8 PSBCSVQoSU5URUxfT1VUUFVUX0RTSSk7Cj4gIH0KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+IGluZGV4IGRkNjVkN2MuLmM4Y2ZkZGMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTc3MzYsOSArNzczNiwxNCBAQCBzdGF0aWMgdm9pZCBp bnRlbF9nZXRfcGlwZV90aW1pbmdzKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJdG1wID0g STkxNV9SRUFEKEhUT1RBTChjcHVfdHJhbnNjb2RlcikpOwo+ICAJcGlwZV9jb25maWctPmJhc2Uu YWRqdXN0ZWRfbW9kZS5jcnRjX2hkaXNwbGF5ID0gKHRtcCAmIDB4ZmZmZikgKyAxOwo+ICAJcGlw ZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2h0b3RhbCA9ICgodG1wID4+IDE2KSAm IDB4ZmZmZikgKyAxOwo+IC0JdG1wID0gSTkxNV9SRUFEKEhCTEFOSyhjcHVfdHJhbnNjb2Rlcikp Owo+IC0JcGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2hibGFua19zdGFydCA9 ICh0bXAgJiAweGZmZmYpICsgMTsKPiAtCXBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUu Y3J0Y19oYmxhbmtfZW5kID0gKCh0bXAgPj4gMTYpICYgMHhmZmZmKSArIDE7Cj4gKwo+ICsJaWYg KCF0cmFuc2NvZGVyX2lzX2RzaShjcHVfdHJhbnNjb2RlcikpIHsKPiArCQl0bXAgPSBJOTE1X1JF QUQoSEJMQU5LKGNwdV90cmFuc2NvZGVyKSk7Cj4gKwkJcGlwZV9jb25maWctPmJhc2UuYWRqdXN0 ZWRfbW9kZS5jcnRjX2hibGFua19zdGFydCA9Cj4gKwkJCQkJCQkodG1wICYgMHhmZmZmKSArIDE7 Cj4gKwkJcGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2hibGFua19lbmQgPQo+ ICsJCQkJCQkoKHRtcCA+PiAxNikgJiAweGZmZmYpICsgMTsKPiArCX0KPiAgCXRtcCA9IEk5MTVf UkVBRChIU1lOQyhjcHVfdHJhbnNjb2RlcikpOwo+ICAJcGlwZV9jb25maWctPmJhc2UuYWRqdXN0 ZWRfbW9kZS5jcnRjX2hzeW5jX3N0YXJ0ID0gKHRtcCAmIDB4ZmZmZikgKyAxOwo+ICAJcGlwZV9j b25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2hzeW5jX2VuZCA9ICgodG1wID4+IDE2KSAm IDB4ZmZmZikgKyAxOwo+IEBAIC03NzQ2LDkgKzc3NTEsMTQgQEAgc3RhdGljIHZvaWQgaW50ZWxf Z2V0X3BpcGVfdGltaW5ncyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCXRtcCA9IEk5MTVf UkVBRChWVE9UQUwoY3B1X3RyYW5zY29kZXIpKTsKPiAgCXBpcGVfY29uZmlnLT5iYXNlLmFkanVz dGVkX21vZGUuY3J0Y192ZGlzcGxheSA9ICh0bXAgJiAweGZmZmYpICsgMTsKPiAgCXBpcGVfY29u ZmlnLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y192dG90YWwgPSAoKHRtcCA+PiAxNikgJiAweGZm ZmYpICsgMTsKPiAtCXRtcCA9IEk5MTVfUkVBRChWQkxBTksoY3B1X3RyYW5zY29kZXIpKTsKPiAt CXBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y192Ymxhbmtfc3RhcnQgPSAodG1w ICYgMHhmZmZmKSArIDE7Cj4gLQlwaXBlX2NvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlLmNydGNf dmJsYW5rX2VuZCA9ICgodG1wID4+IDE2KSAmIDB4ZmZmZikgKyAxOwo+ICsKPiArCWlmICghdHJh bnNjb2Rlcl9pc19kc2koY3B1X3RyYW5zY29kZXIpKSB7Cj4gKwkJdG1wID0gSTkxNV9SRUFEKFZC TEFOSyhjcHVfdHJhbnNjb2RlcikpOwo+ICsJCXBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21v ZGUuY3J0Y192Ymxhbmtfc3RhcnQgPQo+ICsJCQkJCQkJKHRtcCAmIDB4ZmZmZikgKyAxOwo+ICsJ CXBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y192YmxhbmtfZW5kID0KPiArCQkJ CQkJKCh0bXAgPj4gMTYpICYgMHhmZmZmKSArIDE7Cj4gKwl9Cj4gIAl0bXAgPSBJOTE1X1JFQUQo VlNZTkMoY3B1X3RyYW5zY29kZXIpKTsKPiAgCXBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21v ZGUuY3J0Y192c3luY19zdGFydCA9ICh0bXAgJiAweGZmZmYpICsgMTsKPiAgCXBpcGVfY29uZmln LT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y192c3luY19lbmQgPSAoKHRtcCA+PiAxNikgJiAweGZm ZmYpICsgMTsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2Vu dGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==