* [PATCH] drm/i915: remove excess line continuation backslashes
@ 2018-11-14 11:21 Jani Nikula
2018-11-14 11:35 ` Ville Syrjälä
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Jani Nikula @ 2018-11-14 11:21 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
While removing .palette_offsets, I removed the commas after
.trans_offsets in the macros, but failed to remove the line continuation
backslashes.
While at it, also remove another extra comma to be in line with the
other related macros.
Fixes: 74c1e826427a ("drm/i915: remove palette_offsets from device info in favor of _PICK()")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 4ccab8372dd4..983ae7fd8217 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -36,13 +36,13 @@
.pipe_offsets = { PIPE_A_OFFSET, PIPE_B_OFFSET, \
PIPE_C_OFFSET, PIPE_EDP_OFFSET }, \
.trans_offsets = { TRANSCODER_A_OFFSET, TRANSCODER_B_OFFSET, \
- TRANSCODER_C_OFFSET, TRANSCODER_EDP_OFFSET } \
+ TRANSCODER_C_OFFSET, TRANSCODER_EDP_OFFSET }
#define GEN_CHV_PIPEOFFSETS \
.pipe_offsets = { PIPE_A_OFFSET, PIPE_B_OFFSET, \
CHV_PIPE_C_OFFSET }, \
.trans_offsets = { TRANSCODER_A_OFFSET, TRANSCODER_B_OFFSET, \
- CHV_TRANSCODER_C_OFFSET, } \
+ CHV_TRANSCODER_C_OFFSET }
#define CURSOR_OFFSETS \
.cursor_offsets = { CURSOR_A_OFFSET, CURSOR_B_OFFSET, CHV_CURSOR_C_OFFSET }
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: remove excess line continuation backslashes
2018-11-14 11:21 [PATCH] drm/i915: remove excess line continuation backslashes Jani Nikula
@ 2018-11-14 11:35 ` Ville Syrjälä
2018-11-14 11:48 ` Jani Nikula
2018-11-14 14:13 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Ville Syrjälä @ 2018-11-14 11:35 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Nov 14, 2018 at 01:21:30PM +0200, Jani Nikula wrote:
> While removing .palette_offsets, I removed the commas after
> .trans_offsets in the macros, but failed to remove the line continuation
> backslashes.
>
> While at it, also remove another extra comma to be in line with the
> other related macros.
In general I like having the comma after the last element in an
array/enum/whatever. In this case it doesn't really matter, but
in cases like
enum {
yes,
no,
+ maybe,
};
it will result in a cleaner diff.
Anyways, patch is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Fixes: 74c1e826427a ("drm/i915: remove palette_offsets from device info in favor of _PICK()")
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 4ccab8372dd4..983ae7fd8217 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -36,13 +36,13 @@
> .pipe_offsets = { PIPE_A_OFFSET, PIPE_B_OFFSET, \
> PIPE_C_OFFSET, PIPE_EDP_OFFSET }, \
> .trans_offsets = { TRANSCODER_A_OFFSET, TRANSCODER_B_OFFSET, \
> - TRANSCODER_C_OFFSET, TRANSCODER_EDP_OFFSET } \
> + TRANSCODER_C_OFFSET, TRANSCODER_EDP_OFFSET }
>
> #define GEN_CHV_PIPEOFFSETS \
> .pipe_offsets = { PIPE_A_OFFSET, PIPE_B_OFFSET, \
> CHV_PIPE_C_OFFSET }, \
> .trans_offsets = { TRANSCODER_A_OFFSET, TRANSCODER_B_OFFSET, \
> - CHV_TRANSCODER_C_OFFSET, } \
> + CHV_TRANSCODER_C_OFFSET }
>
> #define CURSOR_OFFSETS \
> .cursor_offsets = { CURSOR_A_OFFSET, CURSOR_B_OFFSET, CHV_CURSOR_C_OFFSET }
> --
> 2.11.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: remove excess line continuation backslashes
2018-11-14 11:35 ` Ville Syrjälä
@ 2018-11-14 11:48 ` Jani Nikula
2018-11-15 11:54 ` Jani Nikula
0 siblings, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2018-11-14 11:48 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, 14 Nov 2018, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Nov 14, 2018 at 01:21:30PM +0200, Jani Nikula wrote:
>> While removing .palette_offsets, I removed the commas after
>> .trans_offsets in the macros, but failed to remove the line continuation
>> backslashes.
>>
>> While at it, also remove another extra comma to be in line with the
>> other related macros.
>
> In general I like having the comma after the last element in an
> array/enum/whatever. In this case it doesn't really matter, but
> in cases like
>
> enum {
> yes,
> no,
> + maybe,
> };
>
> it will result in a cleaner diff.
Totally agreed; it just doesn't make a difference here, and none of the
other places here have it, so off it goes.
> Anyways, patch is
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks. /me looks at CI expectantly.
BR,
Jani.
>
>>
>> Fixes: 74c1e826427a ("drm/i915: remove palette_offsets from device info in favor of _PICK()")
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_pci.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
>> index 4ccab8372dd4..983ae7fd8217 100644
>> --- a/drivers/gpu/drm/i915/i915_pci.c
>> +++ b/drivers/gpu/drm/i915/i915_pci.c
>> @@ -36,13 +36,13 @@
>> .pipe_offsets = { PIPE_A_OFFSET, PIPE_B_OFFSET, \
>> PIPE_C_OFFSET, PIPE_EDP_OFFSET }, \
>> .trans_offsets = { TRANSCODER_A_OFFSET, TRANSCODER_B_OFFSET, \
>> - TRANSCODER_C_OFFSET, TRANSCODER_EDP_OFFSET } \
>> + TRANSCODER_C_OFFSET, TRANSCODER_EDP_OFFSET }
>>
>> #define GEN_CHV_PIPEOFFSETS \
>> .pipe_offsets = { PIPE_A_OFFSET, PIPE_B_OFFSET, \
>> CHV_PIPE_C_OFFSET }, \
>> .trans_offsets = { TRANSCODER_A_OFFSET, TRANSCODER_B_OFFSET, \
>> - CHV_TRANSCODER_C_OFFSET, } \
>> + CHV_TRANSCODER_C_OFFSET }
>>
>> #define CURSOR_OFFSETS \
>> .cursor_offsets = { CURSOR_A_OFFSET, CURSOR_B_OFFSET, CHV_CURSOR_C_OFFSET }
>> --
>> 2.11.0
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: remove excess line continuation backslashes
2018-11-14 11:21 [PATCH] drm/i915: remove excess line continuation backslashes Jani Nikula
2018-11-14 11:35 ` Ville Syrjälä
@ 2018-11-14 14:13 ` Patchwork
2018-11-14 15:01 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-15 11:21 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-11-14 14:13 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: remove excess line continuation backslashes
URL : https://patchwork.freedesktop.org/series/52477/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5138 -> Patchwork_10823 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10823 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10823, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52477/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10823:
=== IGT changes ===
==== Possible regressions ====
igt@drv_selftest@live_contexts:
fi-kbl-7560u: PASS -> INCOMPLETE
== Known issues ==
Here are the changes found in Patchwork_10823 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@basic-flip-vs-modeset:
fi-hsw-4770r: PASS -> DMESG-WARN (fdo#105602)
==== Possible fixes ====
igt@drv_selftest@live_contexts:
fi-bsw-n3050: DMESG-FAIL (fdo#108656, fdo#108626) -> PASS
igt@drv_selftest@live_hangcheck:
fi-skl-6700k2: INCOMPLETE -> PASS
igt@gem_ctx_create@basic-files:
fi-bsw-n3050: FAIL (fdo#108656) -> PASS
igt@kms_chamelium@common-hpd-after-suspend:
fi-skl-6700k2: FAIL (fdo#103841) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-skl-6600u: INCOMPLETE (fdo#104108) -> PASS
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108626 https://bugs.freedesktop.org/show_bug.cgi?id=108626
fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656
== Participating hosts (52 -> 44) ==
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-icl-u2 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_5138 -> Patchwork_10823
CI_DRM_5138: 60c8a0cfdd1e3f7eb3e093a39f231e5d8aa507e3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10823: c30300b64541c9715ac7f83312d805ca0c03e43b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c30300b64541 drm/i915: remove excess line continuation backslashes
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10823/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: remove excess line continuation backslashes
2018-11-14 11:21 [PATCH] drm/i915: remove excess line continuation backslashes Jani Nikula
2018-11-14 11:35 ` Ville Syrjälä
2018-11-14 14:13 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-11-14 15:01 ` Patchwork
2018-11-15 11:21 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-11-14 15:01 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: remove excess line continuation backslashes
URL : https://patchwork.freedesktop.org/series/52477/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5139 -> Patchwork_10825 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10825 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10825, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52477/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10825:
=== IGT changes ===
==== Warnings ====
igt@pm_rpm@module-reload:
fi-kbl-7567u: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10825 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-no-display:
fi-kbl-7567u: PASS -> DMESG-WARN (fdo#105602) +2
igt@drv_selftest@live_contexts:
fi-icl-u: NOTRUN -> DMESG-FAIL (fdo#108569)
igt@kms_frontbuffer_tracking@basic:
fi-icl-u2: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
==== Possible fixes ====
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-icl-u: INCOMPLETE (fdo#107713) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
== Participating hosts (54 -> 47) ==
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
== Build changes ==
* Linux: CI_DRM_5139 -> Patchwork_10825
CI_DRM_5139: 5552717626ee1261b76154399b002a3cde69b0a5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10825: bc94bc0400d5d851ab509925f9ddece4cdbfe89a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
bc94bc0400d5 drm/i915: remove excess line continuation backslashes
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10825/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: remove excess line continuation backslashes
2018-11-14 11:21 [PATCH] drm/i915: remove excess line continuation backslashes Jani Nikula
` (2 preceding siblings ...)
2018-11-14 15:01 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-11-15 11:21 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-11-15 11:21 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: remove excess line continuation backslashes
URL : https://patchwork.freedesktop.org/series/52477/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5139_full -> Patchwork_10825_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10825_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ctx_isolation@rcs0-s3:
shard-skl: PASS -> INCOMPLETE (fdo#107773, fdo#104108)
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@kms_atomic_transition@plane-all-modeset-transition:
shard-hsw: PASS -> DMESG-WARN (fdo#102614)
igt@kms_busy@extended-pageflip-hang-newfb-render-a:
shard-apl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
shard-hsw: PASS -> DMESG-WARN (fdo#107956)
igt@kms_color@pipe-a-ctm-0-75:
shard-skl: PASS -> FAIL (fdo#108682)
igt@kms_cursor_crc@cursor-256x256-onscreen:
shard-skl: PASS -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-skl: PASS -> INCOMPLETE (fdo#104108)
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#102887, fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
shard-glk: PASS -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
shard-apl: PASS -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-stridechange:
shard-skl: NOTRUN -> FAIL (fdo#105683)
igt@kms_plane@plane-position-covered-pipe-b-planes:
shard-glk: PASS -> FAIL (fdo#103166)
igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
shard-skl: NOTRUN -> FAIL (fdo#108145) +1
igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
shard-skl: PASS -> FAIL (fdo#107815)
igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
shard-apl: PASS -> FAIL (fdo#103166)
igt@pm_rpm@pc8-residency:
shard-skl: SKIP -> INCOMPLETE (fdo#107807)
==== Possible fixes ====
igt@drm_import_export@import-close-race-flink:
shard-skl: TIMEOUT (fdo#108667) -> PASS
igt@drv_suspend@shrink:
shard-skl: INCOMPLETE (fdo#106886) -> PASS
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-hsw: DMESG-WARN (fdo#107956) -> PASS
igt@kms_busy@extended-modeset-hang-newfb-render-b:
shard-snb: DMESG-WARN (fdo#107956) -> PASS
igt@kms_busy@extended-pageflip-hang-newfb-render-c:
shard-glk: DMESG-WARN (fdo#107956) -> PASS
igt@kms_chv_cursor_fail@pipe-b-64x64-right-edge:
shard-glk: DMESG-FAIL (fdo#106538, fdo#104671) -> PASS
igt@kms_chv_cursor_fail@pipe-c-256x256-top-edge:
shard-skl: FAIL (fdo#104671) -> PASS
igt@kms_color@pipe-c-ctm-blue-to-red:
shard-skl: FAIL (fdo#107201) -> PASS
igt@kms_color@pipe-c-legacy-gamma:
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-128x128-random:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_flip@flip-vs-expired-vblank:
shard-skl: FAIL (fdo#105363) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
shard-apl: FAIL (fdo#103167) -> PASS +1
igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
shard-skl: FAIL (fdo#107815) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-apl: FAIL (fdo#103166) -> PASS +1
igt@kms_properties@connector-properties-legacy:
shard-kbl: DMESG-WARN (fdo#105345, fdo#103313) -> PASS
igt@kms_setmode@basic:
shard-hsw: FAIL (fdo#99912) -> PASS
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105683 https://bugs.freedesktop.org/show_bug.cgi?id=105683
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107201 https://bugs.freedesktop.org/show_bug.cgi?id=107201
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108667 https://bugs.freedesktop.org/show_bug.cgi?id=108667
fdo#108682 https://bugs.freedesktop.org/show_bug.cgi?id=108682
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5139 -> Patchwork_10825
CI_DRM_5139: 5552717626ee1261b76154399b002a3cde69b0a5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4714: cab148ca3ec904a94d0cd43476cf7e1f8663f906 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10825: bc94bc0400d5d851ab509925f9ddece4cdbfe89a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10825/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: remove excess line continuation backslashes
2018-11-14 11:48 ` Jani Nikula
@ 2018-11-15 11:54 ` Jani Nikula
0 siblings, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2018-11-15 11:54 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, 14 Nov 2018, Jani Nikula <jani.nikula@intel.com> wrote:
> On Wed, 14 Nov 2018, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>> On Wed, Nov 14, 2018 at 01:21:30PM +0200, Jani Nikula wrote:
>>> While removing .palette_offsets, I removed the commas after
>>> .trans_offsets in the macros, but failed to remove the line continuation
>>> backslashes.
>>>
>>> While at it, also remove another extra comma to be in line with the
>>> other related macros.
>>
>> In general I like having the comma after the last element in an
>> array/enum/whatever. In this case it doesn't really matter, but
>> in cases like
>>
>> enum {
>> yes,
>> no,
>> + maybe,
>> };
>>
>> it will result in a cleaner diff.
>
> Totally agreed; it just doesn't make a difference here, and none of the
> other places here have it, so off it goes.
>
>> Anyways, patch is
>> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Thanks. /me looks at CI expectantly.
And pushed.
>
> BR,
> Jani.
>
>>
>>>
>>> Fixes: 74c1e826427a ("drm/i915: remove palette_offsets from device info in favor of _PICK()")
>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_pci.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
>>> index 4ccab8372dd4..983ae7fd8217 100644
>>> --- a/drivers/gpu/drm/i915/i915_pci.c
>>> +++ b/drivers/gpu/drm/i915/i915_pci.c
>>> @@ -36,13 +36,13 @@
>>> .pipe_offsets = { PIPE_A_OFFSET, PIPE_B_OFFSET, \
>>> PIPE_C_OFFSET, PIPE_EDP_OFFSET }, \
>>> .trans_offsets = { TRANSCODER_A_OFFSET, TRANSCODER_B_OFFSET, \
>>> - TRANSCODER_C_OFFSET, TRANSCODER_EDP_OFFSET } \
>>> + TRANSCODER_C_OFFSET, TRANSCODER_EDP_OFFSET }
>>>
>>> #define GEN_CHV_PIPEOFFSETS \
>>> .pipe_offsets = { PIPE_A_OFFSET, PIPE_B_OFFSET, \
>>> CHV_PIPE_C_OFFSET }, \
>>> .trans_offsets = { TRANSCODER_A_OFFSET, TRANSCODER_B_OFFSET, \
>>> - CHV_TRANSCODER_C_OFFSET, } \
>>> + CHV_TRANSCODER_C_OFFSET }
>>>
>>> #define CURSOR_OFFSETS \
>>> .cursor_offsets = { CURSOR_A_OFFSET, CURSOR_B_OFFSET, CHV_CURSOR_C_OFFSET }
>>> --
>>> 2.11.0
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-11-15 11:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-14 11:21 [PATCH] drm/i915: remove excess line continuation backslashes Jani Nikula
2018-11-14 11:35 ` Ville Syrjälä
2018-11-14 11:48 ` Jani Nikula
2018-11-15 11:54 ` Jani Nikula
2018-11-14 14:13 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-11-14 15:01 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-15 11:21 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).